You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@stanbol.apache.org by rw...@apache.org on 2014/01/22 16:15:26 UTC

svn commit: r1560376 - in /stanbol/branches/release-0.12/enhancer/jobmanager/event/src/main/java/org/apache/stanbol/enhancer/jobmanager/event/impl: EnhancementJobHandler.java EventJobManagerImpl.java

Author: rwesten
Date: Wed Jan 22 15:15:26 2014
New Revision: 1560376

URL: http://svn.apache.org/r1560376
Log:
Adapt log levels for STANBOL-1139: changed logging for EventJobManager 
 - durations are no longer logged on INFO (as this is now provided by STANBOL-1267)
 - extended INFO loggings for failed jobs are now logged in the EnhancementJobManager logger introduced by STANBOL-1267

Modified:
    stanbol/branches/release-0.12/enhancer/jobmanager/event/src/main/java/org/apache/stanbol/enhancer/jobmanager/event/impl/EnhancementJobHandler.java
    stanbol/branches/release-0.12/enhancer/jobmanager/event/src/main/java/org/apache/stanbol/enhancer/jobmanager/event/impl/EventJobManagerImpl.java

Modified: stanbol/branches/release-0.12/enhancer/jobmanager/event/src/main/java/org/apache/stanbol/enhancer/jobmanager/event/impl/EnhancementJobHandler.java
URL: http://svn.apache.org/viewvc/stanbol/branches/release-0.12/enhancer/jobmanager/event/src/main/java/org/apache/stanbol/enhancer/jobmanager/event/impl/EnhancementJobHandler.java?rev=1560376&r1=1560375&r2=1560376&view=diff
==============================================================================
--- stanbol/branches/release-0.12/enhancer/jobmanager/event/src/main/java/org/apache/stanbol/enhancer/jobmanager/event/impl/EnhancementJobHandler.java (original)
+++ stanbol/branches/release-0.12/enhancer/jobmanager/event/src/main/java/org/apache/stanbol/enhancer/jobmanager/event/impl/EnhancementJobHandler.java Wed Jan 22 15:15:26 2014
@@ -408,7 +408,10 @@ public class EnhancementJobHandler imple
      * @param job
      */
     protected static void logJobInfo(Logger log, EnhancementJob job, String header, boolean logExecutions) {
-        if(header != null){
+    	if(!log.isInfoEnabled()){
+    		return;
+    	}
+    	if(header != null){
             log.info(header);
         }
         log.info("   finished:     {}",job.isFinished());

Modified: stanbol/branches/release-0.12/enhancer/jobmanager/event/src/main/java/org/apache/stanbol/enhancer/jobmanager/event/impl/EventJobManagerImpl.java
URL: http://svn.apache.org/viewvc/stanbol/branches/release-0.12/enhancer/jobmanager/event/src/main/java/org/apache/stanbol/enhancer/jobmanager/event/impl/EventJobManagerImpl.java?rev=1560376&r1=1560375&r2=1560376&view=diff
==============================================================================
--- stanbol/branches/release-0.12/enhancer/jobmanager/event/src/main/java/org/apache/stanbol/enhancer/jobmanager/event/impl/EventJobManagerImpl.java (original)
+++ stanbol/branches/release-0.12/enhancer/jobmanager/event/src/main/java/org/apache/stanbol/enhancer/jobmanager/event/impl/EventJobManagerImpl.java Wed Jan 22 15:15:26 2014
@@ -179,10 +179,10 @@ public class EventJobManagerImpl impleme
                 + " \n To change the timeout change value of property '"+
                     MAX_ENHANCEMENT_JOB_WAIT_TIME+"' for the service "+getClass());
         }
-        log.info("Execution of Chain {} {} after {}ms for ContentItem {}",
-            new Object[]{ chain.getName(), job.isFailed() ? "failed" : "finished",
-                    System.currentTimeMillis()-start,
-                    job.getContentItem().getUri()});
+        log.debug("Execution of Chain {} {} after {}ms for ContentItem {}",
+                new Object[]{ chain.getName(), job.isFailed() ? "failed" : "finished",
+                        System.currentTimeMillis()-start,
+                        job.getContentItem().getUri()});
         //NOTE: ExecutionMetadata are not added to the metadata of the ContentItem
         //      by the EnhancementJobManager.
         //      However one could add this as an optional feature to the
@@ -190,7 +190,8 @@ public class EventJobManagerImpl impleme
         //ci.getMetadata().addAll(job.getExecutionMetadata());
         if(job.isFailed()){
         	Exception e = job.getError();
-            EnhancementJobHandler.logJobInfo(log, job, null, true);
+            EnhancementJobHandler.logJobInfo(enhancementJobManager, job, 
+            		"-- log information about failed EnhancementJob --", true);
             logExecutionMetadata(job);
             log.warn("ExecutionMetadata: ");
             for(Iterator<Triple> it = job.getExecutionMetadata().iterator();