You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/31 08:50:39 UTC
[GitHub] [flink] HuangZhenQiu opened a new pull request #10732:
[FLINK-14980][docs] add function ddl docs
HuangZhenQiu opened a new pull request #10732: [FLINK-14980][docs] add function ddl docs
URL: https://github.com/apache/flink/pull/10732
## What is the purpose of the change
Add function ddl syntax in table docs
## Brief change log
- Add docs to introduce how to create/alter/drop functions ddl
## Verifying this change
This change is just doc change for existing functionality
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (docs)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] bowenli86 commented on a change in pull request #10732:
[FLINK-14980][docs] add function ddl docs
Posted by GitBox <gi...@apache.org>.
bowenli86 commented on a change in pull request #10732: [FLINK-14980][docs] add function ddl docs
URL: https://github.com/apache/flink/pull/10732#discussion_r362301736
##########
File path: docs/dev/table/sql/alter.md
##########
@@ -134,4 +135,27 @@ Set one or more properties in the specified table. If a particular property is a
ALTER DATABASE [catalog_name.]db_name SET (key1=val1, key2=val2, ...)
{% endhighlight %}
-Set one or more properties in the specified database. If a particular property is already set in the database, override the old value with the new one.
\ No newline at end of file
+Set one or more properties in the specified database. If a particular property is already set in the database, override the old value with the new one.
+
+## ALTER FUNCTION
+
+{% highlight sql%}
+ALTER [TEMPORARY|TEMPORARY SYSTEM] FUNCTION
+ [IF EXISTS] [catalog_name.][db_name.] function_name
Review comment:
should be?
```suggestion
[IF EXISTS] [catalog_name.][db_name.]function_name
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] HuangZhenQiu commented on a change in pull request #10732:
[FLINK-14980][docs] add function ddl docs
Posted by GitBox <gi...@apache.org>.
HuangZhenQiu commented on a change in pull request #10732: [FLINK-14980][docs] add function ddl docs
URL: https://github.com/apache/flink/pull/10732#discussion_r362364779
##########
File path: docs/dev/table/sql/alter.md
##########
@@ -134,4 +135,27 @@ Set one or more properties in the specified table. If a particular property is a
ALTER DATABASE [catalog_name.]db_name SET (key1=val1, key2=val2, ...)
{% endhighlight %}
-Set one or more properties in the specified database. If a particular property is already set in the database, override the old value with the new one.
\ No newline at end of file
+Set one or more properties in the specified database. If a particular property is already set in the database, override the old value with the new one.
+
+## ALTER FUNCTION
+
+{% highlight sql%}
+ALTER [TEMPORARY|TEMPORARY SYSTEM] FUNCTION
+ [IF EXISTS] [catalog_name.][db_name.] function_name
+ AS identifier [LANGUAGE JAVA|SCALA|
+{% endhighlight %}
+
+Alter a catalog function with the new identifier and optional language tag. If a function doesn't exist in the catalog, an exception is thrown.
+
Review comment:
Good suggestion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] HuangZhenQiu commented on a change in pull request #10732:
[FLINK-14980][docs] add function ddl docs
Posted by GitBox <gi...@apache.org>.
HuangZhenQiu commented on a change in pull request #10732: [FLINK-14980][docs] add function ddl docs
URL: https://github.com/apache/flink/pull/10732#discussion_r362364797
##########
File path: docs/dev/table/sql/create.md
##########
@@ -225,3 +226,24 @@ Database properties used to store extra information related to this database.
The key and value of expression `key1=val1` should both be string literal.
{% top %}
+
+## CREATE FUNCTION
+{% highlight sql%}
+CREATE [TEMPORARY|TEMPORARY SYSTEM] FUNCTION
+ [IF NOT EXISTS] [catalog_name.][db_name.]function_name
+ AS identifier [LANGUAGE JAVA|SCALA]
+{% endhighlight %}
+
+Create a catalog function that has catalog and database namespaces with the identifier and optional language tag. If a function with the same name already exists in the catalog, an exception is thrown.
+
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] HuangZhenQiu commented on issue #10732: [FLINK-14980][docs]
add function ddl docs
Posted by GitBox <gi...@apache.org>.
HuangZhenQiu commented on issue #10732: [FLINK-14980][docs] add function ddl docs
URL: https://github.com/apache/flink/pull/10732#issuecomment-570111713
@bowenli86 Thanks for digging out these issues.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10732:
[FLINK-14980][docs] add function ddl docs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10732: [FLINK-14980][docs] add function ddl docs
URL: https://github.com/apache/flink/pull/10732#issuecomment-569896244
<!--
Meta data
Hash:6fd808adc772aa42c3ed9968bbd9593c28940539 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142732194 TriggerType:PUSH TriggerID:6fd808adc772aa42c3ed9968bbd9593c28940539
Hash:6fd808adc772aa42c3ed9968bbd9593c28940539 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4014 TriggerType:PUSH TriggerID:6fd808adc772aa42c3ed9968bbd9593c28940539
Hash:b5c952a2c63c55776a601d3ddf9d5b703784949e Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:b5c952a2c63c55776a601d3ddf9d5b703784949e
-->
## CI report:
* 6fd808adc772aa42c3ed9968bbd9593c28940539 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142732194) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4014)
* b5c952a2c63c55776a601d3ddf9d5b703784949e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10732: [FLINK-14980][docs] add
function ddl docs
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10732: [FLINK-14980][docs] add function ddl docs
URL: https://github.com/apache/flink/pull/10732#issuecomment-569891231
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 6fd808adc772aa42c3ed9968bbd9593c28940539 (Tue Dec 31 08:53:47 UTC 2019)
✅no warnings
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10732:
[FLINK-14980][docs] add function ddl docs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10732: [FLINK-14980][docs] add function ddl docs
URL: https://github.com/apache/flink/pull/10732#issuecomment-569896244
<!--
Meta data
Hash:6fd808adc772aa42c3ed9968bbd9593c28940539 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142732194 TriggerType:PUSH TriggerID:6fd808adc772aa42c3ed9968bbd9593c28940539
Hash:6fd808adc772aa42c3ed9968bbd9593c28940539 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4014 TriggerType:PUSH TriggerID:6fd808adc772aa42c3ed9968bbd9593c28940539
Hash:b5c952a2c63c55776a601d3ddf9d5b703784949e Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142835136 TriggerType:PUSH TriggerID:b5c952a2c63c55776a601d3ddf9d5b703784949e
Hash:b5c952a2c63c55776a601d3ddf9d5b703784949e Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4034 TriggerType:PUSH TriggerID:b5c952a2c63c55776a601d3ddf9d5b703784949e
-->
## CI report:
* 6fd808adc772aa42c3ed9968bbd9593c28940539 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142732194) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4014)
* b5c952a2c63c55776a601d3ddf9d5b703784949e Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142835136) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4034)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] bowenli86 commented on a change in pull request #10732:
[FLINK-14980][docs] add function ddl docs
Posted by GitBox <gi...@apache.org>.
bowenli86 commented on a change in pull request #10732: [FLINK-14980][docs] add function ddl docs
URL: https://github.com/apache/flink/pull/10732#discussion_r362301750
##########
File path: docs/dev/table/sql/alter.md
##########
@@ -134,4 +135,27 @@ Set one or more properties in the specified table. If a particular property is a
ALTER DATABASE [catalog_name.]db_name SET (key1=val1, key2=val2, ...)
{% endhighlight %}
-Set one or more properties in the specified database. If a particular property is already set in the database, override the old value with the new one.
\ No newline at end of file
+Set one or more properties in the specified database. If a particular property is already set in the database, override the old value with the new one.
+
+## ALTER FUNCTION
+
+{% highlight sql%}
+ALTER [TEMPORARY|TEMPORARY SYSTEM] FUNCTION
+ [IF EXISTS] [catalog_name.][db_name.] function_name
+ AS identifier [LANGUAGE JAVA|SCALA|
+{% endhighlight %}
+
+Alter a catalog function with the new identifier and optional language tag. If a function doesn't exist in the catalog, an exception is thrown.
+
Review comment:
maybe also document that 'identifier' for java/scala is the class name?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] bowenli86 commented on issue #10732: [FLINK-14980][docs]
add function ddl docs
Posted by GitBox <gi...@apache.org>.
bowenli86 commented on issue #10732: [FLINK-14980][docs] add function ddl docs
URL: https://github.com/apache/flink/pull/10732#issuecomment-570134836
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] bowenli86 closed pull request #10732: [FLINK-14980][docs]
add function ddl docs
Posted by GitBox <gi...@apache.org>.
bowenli86 closed pull request #10732: [FLINK-14980][docs] add function ddl docs
URL: https://github.com/apache/flink/pull/10732
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10732:
[FLINK-14980][docs] add function ddl docs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10732: [FLINK-14980][docs] add function ddl docs
URL: https://github.com/apache/flink/pull/10732#issuecomment-569896244
<!--
Meta data
Hash:6fd808adc772aa42c3ed9968bbd9593c28940539 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142732194 TriggerType:PUSH TriggerID:6fd808adc772aa42c3ed9968bbd9593c28940539
Hash:6fd808adc772aa42c3ed9968bbd9593c28940539 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4014 TriggerType:PUSH TriggerID:6fd808adc772aa42c3ed9968bbd9593c28940539
-->
## CI report:
* 6fd808adc772aa42c3ed9968bbd9593c28940539 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142732194) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4014)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10732:
[FLINK-14980][docs] add function ddl docs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10732: [FLINK-14980][docs] add function ddl docs
URL: https://github.com/apache/flink/pull/10732#issuecomment-569896244
<!--
Meta data
Hash:6fd808adc772aa42c3ed9968bbd9593c28940539 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142732194 TriggerType:PUSH TriggerID:6fd808adc772aa42c3ed9968bbd9593c28940539
Hash:6fd808adc772aa42c3ed9968bbd9593c28940539 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4014 TriggerType:PUSH TriggerID:6fd808adc772aa42c3ed9968bbd9593c28940539
Hash:b5c952a2c63c55776a601d3ddf9d5b703784949e Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142835136 TriggerType:PUSH TriggerID:b5c952a2c63c55776a601d3ddf9d5b703784949e
Hash:b5c952a2c63c55776a601d3ddf9d5b703784949e Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4034 TriggerType:PUSH TriggerID:b5c952a2c63c55776a601d3ddf9d5b703784949e
Hash:b5c952a2c63c55776a601d3ddf9d5b703784949e Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4034 TriggerType:MANUAL TriggerID:570134836
Hash:b5c952a2c63c55776a601d3ddf9d5b703784949e Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142835136 TriggerType:MANUAL TriggerID:570134836
-->
## CI report:
* 6fd808adc772aa42c3ed9968bbd9593c28940539 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142732194) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4014)
* b5c952a2c63c55776a601d3ddf9d5b703784949e Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142835136) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4034)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10732:
[FLINK-14980][docs] add function ddl docs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10732: [FLINK-14980][docs] add function ddl docs
URL: https://github.com/apache/flink/pull/10732#issuecomment-569896244
<!--
Meta data
Hash:6fd808adc772aa42c3ed9968bbd9593c28940539 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142732194 TriggerType:PUSH TriggerID:6fd808adc772aa42c3ed9968bbd9593c28940539
Hash:6fd808adc772aa42c3ed9968bbd9593c28940539 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4014 TriggerType:PUSH TriggerID:6fd808adc772aa42c3ed9968bbd9593c28940539
-->
## CI report:
* 6fd808adc772aa42c3ed9968bbd9593c28940539 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142732194) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4014)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] bowenli86 commented on a change in pull request #10732:
[FLINK-14980][docs] add function ddl docs
Posted by GitBox <gi...@apache.org>.
bowenli86 commented on a change in pull request #10732: [FLINK-14980][docs] add function ddl docs
URL: https://github.com/apache/flink/pull/10732#discussion_r362301768
##########
File path: docs/dev/table/sql/drop.md
##########
@@ -140,4 +141,21 @@ Dropping a non-empty database triggers an exception. Enabled by default.
**CASCADE**
-Dropping a non-empty database also drops all associated tables and functions.
\ No newline at end of file
+Dropping a non-empty database also drops all associated tables and functions.
+
+## DROP FUNCTION
+
+{% highlight sql%}
+DROP [TEMPORARY|TEMPORARY SYSTEM] FUNCTION [IF EXISTS] [catalog_name.][db_name.] function_name;
Review comment:
should be
```suggestion
DROP [TEMPORARY|TEMPORARY SYSTEM] FUNCTION [IF EXISTS] [catalog_name.][db_name.]function_name;
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10732: [FLINK-14980][docs] add
function ddl docs
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10732: [FLINK-14980][docs] add function ddl docs
URL: https://github.com/apache/flink/pull/10732#issuecomment-569896244
<!--
Meta data
Hash:6fd808adc772aa42c3ed9968bbd9593c28940539 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:6fd808adc772aa42c3ed9968bbd9593c28940539
-->
## CI report:
* 6fd808adc772aa42c3ed9968bbd9593c28940539 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10732:
[FLINK-14980][docs] add function ddl docs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10732: [FLINK-14980][docs] add function ddl docs
URL: https://github.com/apache/flink/pull/10732#issuecomment-569896244
<!--
Meta data
Hash:6fd808adc772aa42c3ed9968bbd9593c28940539 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142732194 TriggerType:PUSH TriggerID:6fd808adc772aa42c3ed9968bbd9593c28940539
Hash:6fd808adc772aa42c3ed9968bbd9593c28940539 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4014 TriggerType:PUSH TriggerID:6fd808adc772aa42c3ed9968bbd9593c28940539
Hash:b5c952a2c63c55776a601d3ddf9d5b703784949e Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142835136 TriggerType:PUSH TriggerID:b5c952a2c63c55776a601d3ddf9d5b703784949e
Hash:b5c952a2c63c55776a601d3ddf9d5b703784949e Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4034 TriggerType:PUSH TriggerID:b5c952a2c63c55776a601d3ddf9d5b703784949e
Hash:b5c952a2c63c55776a601d3ddf9d5b703784949e Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4034 TriggerType:MANUAL TriggerID:570134836
Hash:b5c952a2c63c55776a601d3ddf9d5b703784949e Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142835136 TriggerType:MANUAL TriggerID:570134836
-->
## CI report:
* 6fd808adc772aa42c3ed9968bbd9593c28940539 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142732194) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4014)
* b5c952a2c63c55776a601d3ddf9d5b703784949e Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142835136) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4034)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10732:
[FLINK-14980][docs] add function ddl docs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10732: [FLINK-14980][docs] add function ddl docs
URL: https://github.com/apache/flink/pull/10732#issuecomment-569896244
<!--
Meta data
Hash:6fd808adc772aa42c3ed9968bbd9593c28940539 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142732194 TriggerType:PUSH TriggerID:6fd808adc772aa42c3ed9968bbd9593c28940539
Hash:6fd808adc772aa42c3ed9968bbd9593c28940539 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4014 TriggerType:PUSH TriggerID:6fd808adc772aa42c3ed9968bbd9593c28940539
Hash:b5c952a2c63c55776a601d3ddf9d5b703784949e Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142835136 TriggerType:PUSH TriggerID:b5c952a2c63c55776a601d3ddf9d5b703784949e
Hash:b5c952a2c63c55776a601d3ddf9d5b703784949e Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4034 TriggerType:PUSH TriggerID:b5c952a2c63c55776a601d3ddf9d5b703784949e
-->
## CI report:
* 6fd808adc772aa42c3ed9968bbd9593c28940539 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142732194) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4014)
* b5c952a2c63c55776a601d3ddf9d5b703784949e Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142835136) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4034)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10732:
[FLINK-14980][docs] add function ddl docs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10732: [FLINK-14980][docs] add function ddl docs
URL: https://github.com/apache/flink/pull/10732#issuecomment-569896244
<!--
Meta data
Hash:6fd808adc772aa42c3ed9968bbd9593c28940539 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142732194 TriggerType:PUSH TriggerID:6fd808adc772aa42c3ed9968bbd9593c28940539
Hash:6fd808adc772aa42c3ed9968bbd9593c28940539 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4014 TriggerType:PUSH TriggerID:6fd808adc772aa42c3ed9968bbd9593c28940539
Hash:b5c952a2c63c55776a601d3ddf9d5b703784949e Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142835136 TriggerType:PUSH TriggerID:b5c952a2c63c55776a601d3ddf9d5b703784949e
Hash:b5c952a2c63c55776a601d3ddf9d5b703784949e Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4034 TriggerType:PUSH TriggerID:b5c952a2c63c55776a601d3ddf9d5b703784949e
Hash:b5c952a2c63c55776a601d3ddf9d5b703784949e Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4034 TriggerType:MANUAL TriggerID:570134836
-->
## CI report:
* 6fd808adc772aa42c3ed9968bbd9593c28940539 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142732194) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4014)
* b5c952a2c63c55776a601d3ddf9d5b703784949e Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142835136) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4034)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] bowenli86 commented on a change in pull request #10732:
[FLINK-14980][docs] add function ddl docs
Posted by GitBox <gi...@apache.org>.
bowenli86 commented on a change in pull request #10732: [FLINK-14980][docs] add function ddl docs
URL: https://github.com/apache/flink/pull/10732#discussion_r362301757
##########
File path: docs/dev/table/sql/create.md
##########
@@ -225,3 +226,24 @@ Database properties used to store extra information related to this database.
The key and value of expression `key1=val1` should both be string literal.
{% top %}
+
+## CREATE FUNCTION
+{% highlight sql%}
+CREATE [TEMPORARY|TEMPORARY SYSTEM] FUNCTION
+ [IF NOT EXISTS] [catalog_name.][db_name.]function_name
+ AS identifier [LANGUAGE JAVA|SCALA]
+{% endhighlight %}
+
+Create a catalog function that has catalog and database namespaces with the identifier and optional language tag. If a function with the same name already exists in the catalog, an exception is thrown.
+
Review comment:
maybe also document that 'identifier' for java/scala is the class name?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services