You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "eschutho (via GitHub)" <gi...@apache.org> on 2023/08/24 23:15:06 UTC

[GitHub] [superset] eschutho commented on a diff in pull request #25020: fix(embedded sdk): Remove trailing slash from passed superset domain if there is one

eschutho commented on code in PR #25020:
URL: https://github.com/apache/superset/pull/25020#discussion_r1304957771


##########
superset-embedded-sdk/package.json:
##########
@@ -1,6 +1,6 @@
 {
   "name": "@superset-ui/embedded-sdk",
-  "version": "0.1.0-alpha.9",
+  "version": "0.1.0-alpha.10",

Review Comment:
   side note, when do you think we should we consider this not an alpha feature and bump the sdk to a stable version?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org