[GitHub] [lucene-solr] dweiss commented on a change in pull request #2270: LUCENE-9708: Hunspell: support FLAG UTF-8 in absence of SET UTF-8

[GitBox <gi...@apache.org>]

dweiss commented on a change in pull request #2270:
URL: https://github.com/apache/lucene-solr/pull/2270#discussion_r567666875



##########
File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Dictionary.java
##########
@@ -1240,6 +1243,19 @@ void appendFlag(char flag, StringBuilder to) {
     }
   }
 
+  /** Used for FLAG UTF-8 on non-UTF-8 encoding */

Review comment:
       This is quite unfortunate indeed. Do I understand this right that the dictionary data is encoded as iso8859-1 but flags need to be interpreted as UTF-8? I would rename the class as Iso8859_1AsUtf8Strategy or at least provide some explanation on what's happening here in the javadoc (even if it's private).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org