You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "fuweng11 (via GitHub)" <gi...@apache.org> on 2023/05/24 11:34:40 UTC

[GitHub] [inlong] fuweng11 opened a new pull request, #8081: [INLONG-8080][Manager] Fix the total parameter found on the page is different from the actual value

fuweng11 opened a new pull request, #8081:
URL: https://github.com/apache/inlong/pull/8081

   
   
   ### Prepare a Pull Request
   
   - Fixes #8080 
   
   ### Motivation
   
   Fix the total parameter found on the page is different from the actual value.
   
   ### Modifications
   
   Fix the total parameter found on the page is different from the actual value.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [inlong] dockerzhang merged pull request #8081: [INLONG-8080][Manager] Fix the total parameter found on the page is different from the actual value

Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang merged PR #8081:
URL: https://github.com/apache/inlong/pull/8081


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [inlong] vernedeng commented on a diff in pull request #8081: [INLONG-8080][Manager] Fix the total parameter found on the page is different from the actual value

Posted by "vernedeng (via GitHub)" <gi...@apache.org>.
vernedeng commented on code in PR #8081:
URL: https://github.com/apache/inlong/pull/8081#discussion_r1205204892


##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/sink/StreamSinkServiceImpl.java:
##########
@@ -322,9 +323,11 @@ public PageResult<? extends StreamSink> listByCondition(SinkPageRequest request,
         PageHelper.startPage(request.getPageNum(), request.getPageSize());
         OrderFieldEnum.checkOrderField(request);
         OrderTypeEnum.checkOrderType(request);
-        List<StreamSinkEntity> entityPage = sinkMapper.selectByCondition(request);
+        Page<StreamSinkEntity> entityPage = (Page<StreamSinkEntity>) sinkMapper.selectByCondition(request);

Review Comment:
   Please use PageHelper to get the total number of entities.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [inlong] vernedeng commented on a diff in pull request #8081: [INLONG-8080][Manager] Fix the total parameter found on the page is different from the actual value

Posted by "vernedeng (via GitHub)" <gi...@apache.org>.
vernedeng commented on code in PR #8081:
URL: https://github.com/apache/inlong/pull/8081#discussion_r1205192011


##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/sink/StreamSinkServiceImpl.java:
##########
@@ -322,9 +323,11 @@ public PageResult<? extends StreamSink> listByCondition(SinkPageRequest request,
         PageHelper.startPage(request.getPageNum(), request.getPageSize());
         OrderFieldEnum.checkOrderField(request);
         OrderTypeEnum.checkOrderType(request);
-        List<StreamSinkEntity> entityPage = sinkMapper.selectByCondition(request);
+        Page<StreamSinkEntity> entityPage = (Page<StreamSinkEntity>) sinkMapper.selectByCondition(request);

Review Comment:
   Please use pageHelper to do paging



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org