[GitHub] [james-project] chibenwa commented on a diff in pull request #1046: JAMES-3763 BlobMailRepository: No isolation across mail repositories

[GitBox <gi...@apache.org>]

chibenwa commented on code in PR #1046:
URL: https://github.com/apache/james-project/pull/1046#discussion_r894355354


##########
server/mailrepository/mailrepository-blob/src/test/java/org/apache/james/mailrepository/blob/BlobMailRepositoryTest.java:
##########
@@ -56,4 +58,15 @@ void setup() {
     public MailRepository retrieveRepository() {
         return blobMailRepository;
     }
+
+    @Override
+    public MailRepository retrieveRepository(MailRepositoryPath path) {
+        return blobMailRepository;

Review Comment:
   
   
   Current code injecting mailRepository passes the URL to implementations via either config or constructor, and shoud have the underlying mail repository adapt its storage to the URL.
   
   I'll adapt the implem.
   
   Regards



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org