You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "Tomo Suzuki (Jira)" <ji...@apache.org> on 2019/11/18 19:15:00 UTC
[jira] [Commented] (BEAM-8627) Migrate bigtable-client-core to
1.12.1
[ https://issues.apache.org/jira/browse/BEAM-8627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16976804#comment-16976804 ]
Tomo Suzuki commented on BEAM-8627:
-----------------------------------
GcpApiSurfaceTest fails:
{noformat}
Expected: API surface to include only:
Classes in package "com.google.api.core"
Classes in package "com.google.api.client.googleapis"
Classes in package "com.google.api.client.http"
Classes in package "com.google.api.client.json"
Classes in package "com.google.api.client.util"
Classes in package "com.google.api.services.bigquery.model"
Classes in package "com.google.auth"
Classes in package "com.google.bigtable.admin.v2"
Classes in package "com.google.bigtable.v2"
Classes in package "com.google.cloud.bigquery.storage.v1beta1"
Classes in package "com.google.cloud.bigtable.config"
Classes in package "com.google.cloud.bigtable.data"
Classes in package "com.google.spanner.v1"
<class com.google.api.gax.rpc.ApiException>
<interface com.google.api.gax.longrunning.OperationFuture>
<interface com.google.api.gax.longrunning.OperationSnapshot>
<interface com.google.api.gax.paging.Page>
<interface com.google.api.gax.retrying.RetryingFuture>
<class com.google.api.gax.retrying.RetrySettings>
<class com.google.api.gax.retrying.RetrySettings$Builder>
<class com.google.api.gax.retrying.TimedAttemptSettings>
<class com.google.api.gax.retrying.TimedAttemptSettings$Builder>
<interface com.google.api.gax.rpc.StatusCode>
<class com.google.api.gax.rpc.StatusCode$Code>
<interface com.google.api.resourcenames.ResourceName>
<class com.google.cloud.bigtable.grpc.BigtableClusterName>
<class com.google.cloud.bigtable.grpc.BigtableInstanceName>
<class com.google.cloud.bigtable.grpc.BigtableTableName>
<class com.google.cloud.BaseServiceException>
<class com.google.cloud.BaseServiceException$Error>
<class com.google.cloud.BaseServiceException$ExceptionData>
<class com.google.cloud.BaseServiceException$ExceptionData$Builder>
<class com.google.cloud.RetryHelper$RetryHelperException>
<class com.google.cloud.grpc.BaseGrpcServiceException>
<class com.google.cloud.ByteArray>
<class com.google.cloud.Date>
<class com.google.cloud.Timestamp>
Classes in package "com.google.cloud.spanner"
Classes in package "com.google.spanner.admin.database.v1"
Classes in package "com.google.datastore.v1"
Classes in package "com.google.protobuf"
Classes in package "com.google.type"
Classes in package "com.fasterxml.jackson.annotation"
Classes in package "com.fasterxml.jackson.core"
Classes in package "com.fasterxml.jackson.databind"
Classes in package "io.grpc"
Classes in package "java"
Classes in package "javax"
Classes in package "org.apache.avro"
Classes in package "org.apache.beam"
Classes in package "org.apache.commons.logging"
Classes in package "org.codehaus.jackson"
Classes in package "org.joda.time"
Classes in package "org.threeten.bp"
but: The following white-listed scopes did not have matching classes on the API surface:
No <interface com.google.api.resourcenames.ResourceName>
No Classes in package "com.google.bigtable.admin.v2"
No Classes in package "com.google.cloud.bigtable.data"
{noformat}
The following code in ApiSurface made abandonedClassMatchers nonempty. getExposedToExposers tells "A map from exposed types to place where they are exposed".
{noformat}
final Predicate<Matcher<Class<?>>> matchedByExposedClasses =
classMatcher ->
FluentIterable.from(checkedApiSurface.getExposedClasses())
.anyMatch(classMatcher::matches);
// </helper_lambdas>
final ImmutableSet<Matcher<Class<?>>> matchedClassMatchers =
FluentIterable.from(allowedClasses).filter(matchedByExposedClasses).toSet();
final Sets.SetView<Matcher<Class<?>>> abandonedClassMatchers =
Sets.difference(allowedClasses, matchedClassMatchers);
{noformat}
> Migrate bigtable-client-core to 1.12.1
> --------------------------------------
>
> Key: BEAM-8627
> URL: https://issues.apache.org/jira/browse/BEAM-8627
> Project: Beam
> Issue Type: Improvement
> Components: io-java-gcp, runner-dataflow
> Reporter: Tomo Suzuki
> Assignee: Tomo Suzuki
> Priority: Major
>
> Beam currently uses Migrate bigtable-client-core to 1.8.0. The latest is 1.12.1
> [https://search.maven.org/artifact/com.google.cloud.bigtable/bigtable-client-core/1.12.1/jar]
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)