You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2019/03/03 01:02:20 UTC

Review Request 70102: Moved NULL check from cpplint into clang-tidy.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70102/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler and Tomasz Janiszewski.


Repository: mesos


Description
-------

Moved NULL check from cpplint into clang-tidy.


Diffs
-----

  support/CPPLINT.cfg PRE-CREATION 
  support/clang-tidy d448314b245a043ced0c4816628cd7c05ea8a68d 
  support/cpplint.patch 2427be87559e6dd21c8841f1719064b5d46e4fc7 
  support/cpplint.py b8b3b1a14d3ac56fa4c8e44b271b32e3308cb4e1 


Diff: https://reviews.apache.org/r/70102/diff/1/


Testing
-------

`make check`


Thanks,

Benjamin Bannier

Re: Review Request 70102: Moved NULL check from cpplint into clang-tidy.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70102/#review213381
-----------------------------------------------------------



Patch looks great!

Reviews applied: [70095, 70096, 70097, 70098, 70099, 70100, 70101, 70102]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On March 3, 2019, 9:02 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70102/
> -----------------------------------------------------------
> 
> (Updated March 3, 2019, 9:02 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Tomasz Janiszewski.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Moved NULL check from cpplint into clang-tidy.
> 
> 
> Diffs
> -----
> 
>   support/CPPLINT.cfg PRE-CREATION 
>   support/clang-tidy d448314b245a043ced0c4816628cd7c05ea8a68d 
>   support/cpplint.patch 2427be87559e6dd21c8841f1719064b5d46e4fc7 
>   support/cpplint.py b8b3b1a14d3ac56fa4c8e44b271b32e3308cb4e1 
> 
> 
> Diff: https://reviews.apache.org/r/70102/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 70102: Moved NULL check from cpplint into clang-tidy.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70102/#review213480
-----------------------------------------------------------


Ship it!




Semantics over syntax!

- Alexander Rukletsov


On March 3, 2019, 1:02 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70102/
> -----------------------------------------------------------
> 
> (Updated March 3, 2019, 1:02 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Tomasz Janiszewski.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Moved NULL check from cpplint into clang-tidy.
> 
> 
> Diffs
> -----
> 
>   support/CPPLINT.cfg PRE-CREATION 
>   support/clang-tidy d448314b245a043ced0c4816628cd7c05ea8a68d 
>   support/cpplint.patch 2427be87559e6dd21c8841f1719064b5d46e4fc7 
>   support/cpplint.py b8b3b1a14d3ac56fa4c8e44b271b32e3308cb4e1 
> 
> 
> Diff: https://reviews.apache.org/r/70102/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 70102: Moved NULL check from cpplint into clang-tidy.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70102/#review213359
-----------------------------------------------------------



Patch looks great!

Reviews applied: [70088, 70089, 70090, 70092, 70093, 70094, 70095, 70096, 70097, 70098, 70099, 70100, 70101, 70102]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On March 2, 2019, 5:02 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70102/
> -----------------------------------------------------------
> 
> (Updated March 2, 2019, 5:02 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Tomasz Janiszewski.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Moved NULL check from cpplint into clang-tidy.
> 
> 
> Diffs
> -----
> 
>   support/CPPLINT.cfg PRE-CREATION 
>   support/clang-tidy d448314b245a043ced0c4816628cd7c05ea8a68d 
>   support/cpplint.patch 2427be87559e6dd21c8841f1719064b5d46e4fc7 
>   support/cpplint.py b8b3b1a14d3ac56fa4c8e44b271b32e3308cb4e1 
> 
> 
> Diff: https://reviews.apache.org/r/70102/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 70102: Moved NULL check from cpplint into clang-tidy.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70102/#review213370
-----------------------------------------------------------



Bad review!

Reviews applied: [70102, 70101, 70100, 70099, 70098, 70097, 70096, 70095, 70094, 70093, 70092, 70090, 70089, 70088]

Error:
2019-03-03 14:31:04 URL:https://reviews.apache.org/r/70095/diff/raw/ [60854/60854] -> "70095.patch" [1]
error: patch failed: support/mesos-style.py:246
error: support/mesos-style.py: patch does not apply

- Mesos Reviewbot


On March 3, 2019, 2:02 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70102/
> -----------------------------------------------------------
> 
> (Updated March 3, 2019, 2:02 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Tomasz Janiszewski.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Moved NULL check from cpplint into clang-tidy.
> 
> 
> Diffs
> -----
> 
>   support/CPPLINT.cfg PRE-CREATION 
>   support/clang-tidy d448314b245a043ced0c4816628cd7c05ea8a68d 
>   support/cpplint.patch 2427be87559e6dd21c8841f1719064b5d46e4fc7 
>   support/cpplint.py b8b3b1a14d3ac56fa4c8e44b271b32e3308cb4e1 
> 
> 
> Diff: https://reviews.apache.org/r/70102/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 70102: Moved NULL check from cpplint into clang-tidy.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70102/#review213367
-----------------------------------------------------------



Bad review!

Reviews applied: [70102, 70101, 70100, 70099, 70098, 70097, 70096, 70095, 70094, 70093, 70092, 70090, 70089, 70088]

Error:
2019-03-03 11:11:18 URL:https://reviews.apache.org/r/70095/diff/raw/ [60854/60854] -> "70095.patch" [1]
error: patch failed: support/mesos-style.py:246
error: support/mesos-style.py: patch does not apply

- Mesos Reviewbot


On March 2, 2019, 5:02 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70102/
> -----------------------------------------------------------
> 
> (Updated March 2, 2019, 5:02 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Tomasz Janiszewski.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Moved NULL check from cpplint into clang-tidy.
> 
> 
> Diffs
> -----
> 
>   support/CPPLINT.cfg PRE-CREATION 
>   support/clang-tidy d448314b245a043ced0c4816628cd7c05ea8a68d 
>   support/cpplint.patch 2427be87559e6dd21c8841f1719064b5d46e4fc7 
>   support/cpplint.py b8b3b1a14d3ac56fa4c8e44b271b32e3308cb4e1 
> 
> 
> Diff: https://reviews.apache.org/r/70102/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 70102: Moved NULL check from cpplint into clang-tidy.

Posted by Tomasz Janiszewski <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70102/#review213390
-----------------------------------------------------------


Ship it!




Ship It!

- Tomasz Janiszewski


On Mar 3, 2019, 1:02 rano, Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70102/
> -----------------------------------------------------------
> 
> (Updated Mar 3, 2019, 1:02 rano)
> 
> 
> Review request for mesos, Benjamin Mahler and Tomasz Janiszewski.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Moved NULL check from cpplint into clang-tidy.
> 
> 
> Diffs
> -----
> 
>   support/CPPLINT.cfg PRE-CREATION 
>   support/clang-tidy d448314b245a043ced0c4816628cd7c05ea8a68d 
>   support/cpplint.patch 2427be87559e6dd21c8841f1719064b5d46e4fc7 
>   support/cpplint.py b8b3b1a14d3ac56fa4c8e44b271b32e3308cb4e1 
> 
> 
> Diff: https://reviews.apache.org/r/70102/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 70102: Moved NULL check from cpplint into clang-tidy.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70102/#review213378
-----------------------------------------------------------



Bad review!

Reviews applied: [70102, 70101, 70100, 70099, 70098, 70097, 70096, 70095]

Error:
2019-03-03 22:03:49 URL:https://reviews.apache.org/r/70095/diff/raw/ [60854/60854] -> "70095.patch" [1]
error: patch failed: support/mesos-style.py:246
error: support/mesos-style.py: patch does not apply

- Mesos Reviewbot


On March 2, 2019, 5:02 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70102/
> -----------------------------------------------------------
> 
> (Updated March 2, 2019, 5:02 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Tomasz Janiszewski.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Moved NULL check from cpplint into clang-tidy.
> 
> 
> Diffs
> -----
> 
>   support/CPPLINT.cfg PRE-CREATION 
>   support/clang-tidy d448314b245a043ced0c4816628cd7c05ea8a68d 
>   support/cpplint.patch 2427be87559e6dd21c8841f1719064b5d46e4fc7 
>   support/cpplint.py b8b3b1a14d3ac56fa4c8e44b271b32e3308cb4e1 
> 
> 
> Diff: https://reviews.apache.org/r/70102/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>