You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/04/24 10:41:12 UTC

[GitHub] [cloudstack-primate] shwstppr opened a new pull request #312: view: fix getDiagnostics response display

shwstppr opened a new pull request #312:
URL: https://github.com/apache/cloudstack-primate/pull/312


   ![Screenshot from 2020-04-24 16-07-48](https://user-images.githubusercontent.com/153340/80204045-c7224a00-8645-11ea-9a21-6b112c8c066b.png)
   ![Screenshot from 2020-04-24 16-07-21](https://user-images.githubusercontent.com/153340/80204049-c8537700-8645-11ea-8bbb-3f81e0ff4194.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] shwstppr commented on a change in pull request #312: view: fix getDiagnostics response display

Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #312:
URL: https://github.com/apache/cloudstack-primate/pull/312#discussion_r414478915



##########
File path: src/config/section/infra/routers.js
##########
@@ -102,7 +102,8 @@ export default {
         targetid: {
           value: (record) => { return record.id }
         }
-      }
+      },
+      response: (result) => { return ((result && result.diagnostics && result && result.diagnostics.url && `Please click the link to download the retrieved diagnostics: <p><a href='${result.diagnostics.url}'>${result.diagnostics.url}</a></p>`) || 'Invalid response') }

Review comment:
       @rhtyd can we perform the translation in JS files?
   I've to use string key from here, get the translated string and then replace URL. ELse I'll have to add code in Autogen to explicitly address this API response




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org