You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Chip Childers <ch...@sungard.com> on 2013/04/03 21:33:54 UTC
Re: RAT test failing in master
On Wed, Apr 03, 2013 at 12:27:57PM -0700, Rayees Namathponnan wrote:
> Hi,
>
> RAT test failing in master due to missing license, looks like its failing after adding "MidoNet Networking Plugin",
>
> Dave - can you please have a look on this ?
corrected with:
commit 4f9bdba2815510d55cbf0727f80fe57b14023022
Author: Chip Childers <ch...@gmail.com>
Date: Wed Apr 3 20:33:25 2013 +0100
Correcting missing license headers in two MidoNet plugin files
Signed-off-by: Chip Childers <ch...@gmail.com>
>
>
>
> $ git log plugins/network-elements/midonet/src/com/cloud/network/guru/MidoNetGuestNetworkGuru.java
>
> commit eddf7b9357bc18497b8cb16a6c6f3382ac52f61c
>
> Author: Dave Cahill <dc...@midokura.com>>
>
> Date: Mon Mar 25 10:56:13 2013 +0900
>
>
>
> MidoNet Networking Plugin
>
>
>
> - Supports DHCP, Source NAT, Static NAT, Firewall rules, Port Forwarding
>
> - Renamed MidokuraMidonet to MidoNet
>
> - Related Jira ticket is CLOUDSTACK-996
>
>
>
> Signed-off-by: Dave Cahill <dc...@midokura.com>>
>
> Signed-off-by: Hugo Trippaers <ht...@schubergphilis.com>>
>
>
>
> commit d392445f7e9adab7d6effd4daf0d76bb0e6f9bd9
>
> Author: Dave Cahill <dc...@midokura.com>>
>
> Date: Wed Mar 13 17:27:09 2013 +0900
>
>
>
> Rename MidoNetElement and MidoNetGuestNetworkGuru
>
>
>
> - Creating this as a separate commit so that it is marked as a rename
>
> - Over 50% code changed, so would count as a delete and add otherwise
>
>
>
> Signed-off-by: Dave Cahill <dc...@midokura.com>>
>
> Signed-off-by: Hugo Trippaers <ht...@schubergphilis.com>>
>
>
> Regards,
> Rayees
>
Re: RAT test failing in master
Posted by Chip Childers <ch...@sungard.com>.
No problem!
On Thu, Apr 04, 2013 at 07:16:28AM +0000, Hugo Trippaers wrote:
> Thanks for fixing Chip and sorry for not noticing :-(
>
> > -----Original Message-----
> > From: dcahill@midokura.jp [mailto:dcahill@midokura.jp] On Behalf Of Dave
> > Cahill
> > Sent: Thursday, April 04, 2013 3:14 AM
> > To: dev@cloudstack.apache.org
> > Subject: Re: RAT test failing in master
> >
> > Thanks for this Chip - 5 minutes from notification mail to fixed and committed
> > must be some kind of record. :)
> >
> > Dave.
> >
> >
> > On Thu, Apr 4, 2013 at 4:33 AM, Chip Childers
> > <ch...@sungard.com>wrote:
> >
> > > On Wed, Apr 03, 2013 at 12:27:57PM -0700, Rayees Namathponnan wrote:
> > > > Hi,
> > > >
> > > > RAT test failing in master due to missing license, looks like its
> > > failing after adding "MidoNet Networking Plugin",
> > > >
> > > > Dave - can you please have a look on this ?
> > >
> > > corrected with:
> > >
> > > commit 4f9bdba2815510d55cbf0727f80fe57b14023022
> > > Author: Chip Childers <ch...@gmail.com>
> > > Date: Wed Apr 3 20:33:25 2013 +0100
> > >
> > > Correcting missing license headers in two MidoNet plugin files
> > >
> > > Signed-off-by: Chip Childers <ch...@gmail.com>
> > >
> > > >
> > > >
> > > >
> > > > $ git log
> > > plugins/network-
> > elements/midonet/src/com/cloud/network/guru/MidoNetGue
> > > stNetworkGuru.java
> > > >
> > > > commit eddf7b9357bc18497b8cb16a6c6f3382ac52f61c
> > > >
> > > > Author: Dave Cahill
> > > > <dc...@midokura.com>>
> > > >
> > > > Date: Mon Mar 25 10:56:13 2013 +0900
> > > >
> > > >
> > > >
> > > > MidoNet Networking Plugin
> > > >
> > > >
> > > >
> > > > - Supports DHCP, Source NAT, Static NAT, Firewall rules, Port
> > > Forwarding
> > > >
> > > > - Renamed MidokuraMidonet to MidoNet
> > > >
> > > > - Related Jira ticket is CLOUDSTACK-996
> > > >
> > > >
> > > >
> > > > Signed-off-by: Dave Cahill <dcahill@midokura.com<mailto:
> > > dcahill@midokura.com>>
> > > >
> > > > Signed-off-by: Hugo Trippaers
> > <htrippaers@schubergphilis.com<mailto:
> > > htrippaers@schubergphilis.com>>
> > > >
> > > >
> > > >
> > > > commit d392445f7e9adab7d6effd4daf0d76bb0e6f9bd9
> > > >
> > > > Author: Dave Cahill
> > > > <dc...@midokura.com>>
> > > >
> > > > Date: Wed Mar 13 17:27:09 2013 +0900
> > > >
> > > >
> > > >
> > > > Rename MidoNetElement and MidoNetGuestNetworkGuru
> > > >
> > > >
> > > >
> > > > - Creating this as a separate commit so that it is marked as a
> > > > rename
> > > >
> > > > - Over 50% code changed, so would count as a delete and add
> > > > otherwise
> > > >
> > > >
> > > >
> > > > Signed-off-by: Dave Cahill <dcahill@midokura.com<mailto:
> > > dcahill@midokura.com>>
> > > >
> > > > Signed-off-by: Hugo Trippaers
> > <htrippaers@schubergphilis.com<mailto:
> > > htrippaers@schubergphilis.com>>
> > > >
> > > >
> > > > Regards,
> > > > Rayees
> > > >
> > >
>
RE: RAT test failing in master
Posted by Hugo Trippaers <HT...@schubergphilis.com>.
Thanks for fixing Chip and sorry for not noticing :-(
> -----Original Message-----
> From: dcahill@midokura.jp [mailto:dcahill@midokura.jp] On Behalf Of Dave
> Cahill
> Sent: Thursday, April 04, 2013 3:14 AM
> To: dev@cloudstack.apache.org
> Subject: Re: RAT test failing in master
>
> Thanks for this Chip - 5 minutes from notification mail to fixed and committed
> must be some kind of record. :)
>
> Dave.
>
>
> On Thu, Apr 4, 2013 at 4:33 AM, Chip Childers
> <ch...@sungard.com>wrote:
>
> > On Wed, Apr 03, 2013 at 12:27:57PM -0700, Rayees Namathponnan wrote:
> > > Hi,
> > >
> > > RAT test failing in master due to missing license, looks like its
> > failing after adding "MidoNet Networking Plugin",
> > >
> > > Dave - can you please have a look on this ?
> >
> > corrected with:
> >
> > commit 4f9bdba2815510d55cbf0727f80fe57b14023022
> > Author: Chip Childers <ch...@gmail.com>
> > Date: Wed Apr 3 20:33:25 2013 +0100
> >
> > Correcting missing license headers in two MidoNet plugin files
> >
> > Signed-off-by: Chip Childers <ch...@gmail.com>
> >
> > >
> > >
> > >
> > > $ git log
> > plugins/network-
> elements/midonet/src/com/cloud/network/guru/MidoNetGue
> > stNetworkGuru.java
> > >
> > > commit eddf7b9357bc18497b8cb16a6c6f3382ac52f61c
> > >
> > > Author: Dave Cahill
> > > <dc...@midokura.com>>
> > >
> > > Date: Mon Mar 25 10:56:13 2013 +0900
> > >
> > >
> > >
> > > MidoNet Networking Plugin
> > >
> > >
> > >
> > > - Supports DHCP, Source NAT, Static NAT, Firewall rules, Port
> > Forwarding
> > >
> > > - Renamed MidokuraMidonet to MidoNet
> > >
> > > - Related Jira ticket is CLOUDSTACK-996
> > >
> > >
> > >
> > > Signed-off-by: Dave Cahill <dcahill@midokura.com<mailto:
> > dcahill@midokura.com>>
> > >
> > > Signed-off-by: Hugo Trippaers
> <htrippaers@schubergphilis.com<mailto:
> > htrippaers@schubergphilis.com>>
> > >
> > >
> > >
> > > commit d392445f7e9adab7d6effd4daf0d76bb0e6f9bd9
> > >
> > > Author: Dave Cahill
> > > <dc...@midokura.com>>
> > >
> > > Date: Wed Mar 13 17:27:09 2013 +0900
> > >
> > >
> > >
> > > Rename MidoNetElement and MidoNetGuestNetworkGuru
> > >
> > >
> > >
> > > - Creating this as a separate commit so that it is marked as a
> > > rename
> > >
> > > - Over 50% code changed, so would count as a delete and add
> > > otherwise
> > >
> > >
> > >
> > > Signed-off-by: Dave Cahill <dcahill@midokura.com<mailto:
> > dcahill@midokura.com>>
> > >
> > > Signed-off-by: Hugo Trippaers
> <htrippaers@schubergphilis.com<mailto:
> > htrippaers@schubergphilis.com>>
> > >
> > >
> > > Regards,
> > > Rayees
> > >
> >
Re: RAT test failing in master
Posted by Dave Cahill <dc...@midokura.com>.
Thanks for this Chip - 5 minutes from notification mail to fixed and
committed must be some kind of record. :)
Dave.
On Thu, Apr 4, 2013 at 4:33 AM, Chip Childers <ch...@sungard.com>wrote:
> On Wed, Apr 03, 2013 at 12:27:57PM -0700, Rayees Namathponnan wrote:
> > Hi,
> >
> > RAT test failing in master due to missing license, looks like its
> failing after adding "MidoNet Networking Plugin",
> >
> > Dave - can you please have a look on this ?
>
> corrected with:
>
> commit 4f9bdba2815510d55cbf0727f80fe57b14023022
> Author: Chip Childers <ch...@gmail.com>
> Date: Wed Apr 3 20:33:25 2013 +0100
>
> Correcting missing license headers in two MidoNet plugin files
>
> Signed-off-by: Chip Childers <ch...@gmail.com>
>
> >
> >
> >
> > $ git log
> plugins/network-elements/midonet/src/com/cloud/network/guru/MidoNetGuestNetworkGuru.java
> >
> > commit eddf7b9357bc18497b8cb16a6c6f3382ac52f61c
> >
> > Author: Dave Cahill <dc...@midokura.com>>
> >
> > Date: Mon Mar 25 10:56:13 2013 +0900
> >
> >
> >
> > MidoNet Networking Plugin
> >
> >
> >
> > - Supports DHCP, Source NAT, Static NAT, Firewall rules, Port
> Forwarding
> >
> > - Renamed MidokuraMidonet to MidoNet
> >
> > - Related Jira ticket is CLOUDSTACK-996
> >
> >
> >
> > Signed-off-by: Dave Cahill <dcahill@midokura.com<mailto:
> dcahill@midokura.com>>
> >
> > Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com<mailto:
> htrippaers@schubergphilis.com>>
> >
> >
> >
> > commit d392445f7e9adab7d6effd4daf0d76bb0e6f9bd9
> >
> > Author: Dave Cahill <dc...@midokura.com>>
> >
> > Date: Wed Mar 13 17:27:09 2013 +0900
> >
> >
> >
> > Rename MidoNetElement and MidoNetGuestNetworkGuru
> >
> >
> >
> > - Creating this as a separate commit so that it is marked as a rename
> >
> > - Over 50% code changed, so would count as a delete and add otherwise
> >
> >
> >
> > Signed-off-by: Dave Cahill <dcahill@midokura.com<mailto:
> dcahill@midokura.com>>
> >
> > Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com<mailto:
> htrippaers@schubergphilis.com>>
> >
> >
> > Regards,
> > Rayees
> >
>