[Impala-ASF-CR] IMPALA-7190: Remove unsupported format writer support

["Bikramjeet Vig (Code Review)" <ge...@cloudera.org>]

Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10823 )

Change subject: IMPALA-7190: Remove unsupported format writer support
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/10823/1/be/src/exec/hdfs-table-sink.cc
File be/src/exec/hdfs-table-sink.cc:

http://gerrit.cloudera.org:8080/#/c/10823/1/be/src/exec/hdfs-table-sink.cc@484
PS1, Line 484:   }
> presumably we do this error checking at runtime rather than analysis so tha
Done. Added a test case to unsupported-writers.test


http://gerrit.cloudera.org:8080/#/c/10823/1/tests/common/test_dimensions.py
File tests/common/test_dimensions.py:

http://gerrit.cloudera.org:8080/#/c/10823/1/tests/common/test_dimensions.py@111
PS1, Line 111: # Available Exec Options:
> Let's just delete this whole comment, it's insanely stale. It's a terrible 
Done


http://gerrit.cloudera.org:8080/#/c/10823/1/tests/query_test/test_compressed_formats.py
File tests/query_test/test_compressed_formats.py:

http://gerrit.cloudera.org:8080/#/c/10823/1/tests/query_test/test_compressed_formats.py@150
PS1, Line 150:   def test_unsupported_writers(self, vector):
> I would prefer to use unique_database, and remove the drops from unsupporte
Done


http://gerrit.cloudera.org:8080/#/c/10823/1/tests/shell/test_shell_interactive.py
File tests/shell/test_shell_interactive.py:

http://gerrit.cloudera.org:8080/#/c/10823/1/tests/shell/test_shell_interactive.py@a404
PS1, Line 404: 
> This line could be left here, but check that "... not in result.stduot". Th
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/10823
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I821dc7495a901f1658daa500daf3791b386c7185
Gerrit-Change-Number: 10823
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Jul 2018 20:11:36 +0000
Gerrit-HasComments: Yes