[GitHub] [arrow] lidavidm commented on a diff in pull request #12967: ARROW-16294: [C++] Improve performance of parquet readahead

[GitBox <gi...@apache.org>]

lidavidm commented on code in PR #12967:
URL: https://github.com/apache/arrow/pull/12967#discussion_r856742557


##########
cpp/src/parquet/arrow/reader.cc:
##########
@@ -1113,15 +1146,19 @@ class RowGroupGenerator {
   ::arrow::internal::Executor* cpu_executor_;
   std::vector<int> row_groups_;
   std::vector<int> column_indices_;
+  int64_t min_rows_in_flight_;
+  std::queue<ReadRequest> in_flight_reads_;
+  int64_t rows_in_flight_;
   size_t index_;
+  size_t readahead_index_;
 };
 
 ::arrow::Result<::arrow::AsyncGenerator<std::shared_ptr<::arrow::RecordBatch>>>
 FileReaderImpl::GetRecordBatchGenerator(std::shared_ptr<FileReader> reader,
                                         const std::vector<int> row_group_indices,
                                         const std::vector<int> column_indices,
                                         ::arrow::internal::Executor* cpu_executor,
-                                        int batch_readahead) {
+                                        int rows_to_readahead) {

Review Comment:
   Should we rename this in the header too?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org