You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@felix.apache.org by fm...@apache.org on 2009/06/03 12:44:38 UTC

svn commit: r781335 - /felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/ServiceFactoryComponentManager.java

Author: fmeschbe
Date: Wed Jun  3 10:44:38 2009
New Revision: 781335

URL: http://svn.apache.org/viewvc?rev=781335&view=rev
Log:
FELIX-1185 "satisfied" state of a service factory component
is "registered" (like the delayed service component) and not
"factory" (which is only used factory components).

Modified:
    felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/ServiceFactoryComponentManager.java

Modified: felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/ServiceFactoryComponentManager.java
URL: http://svn.apache.org/viewvc/felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/ServiceFactoryComponentManager.java?rev=781335&r1=781334&r2=781335&view=diff
==============================================================================
--- felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/ServiceFactoryComponentManager.java (original)
+++ felix/trunk/scr/src/main/java/org/apache/felix/scr/impl/ServiceFactoryComponentManager.java Wed Jun  3 10:44:38 2009
@@ -93,7 +93,7 @@
      */
     public Object getService( Bundle bundle, ServiceRegistration registration )
     {
-        log( LogService.LOG_DEBUG, "DelayedServiceFactoryServiceFactory.getService()", getComponentMetadata(), null );
+        log( LogService.LOG_DEBUG, "ServiceFactory.getService()", getComponentMetadata(), null );
 
         // When the getServiceMethod is called, the implementation object must be created
 
@@ -108,11 +108,11 @@
             serviceContexts.put( service, serviceContext );
 
             // if this is the first use of this component, switch to ACTIVE state
-			if (getState() == STATE_FACTORY)
+			if (getState() == STATE_REGISTERED)
 			{
 				synchronized(this)
 				{
-					if (getState() == STATE_FACTORY)
+					if (getState() == STATE_REGISTERED)
 					{
 						changeState(Active.getInstance());
 					}
@@ -129,7 +129,7 @@
      */
     public void ungetService( Bundle bundle, ServiceRegistration registration, Object service )
     {
-        log( LogService.LOG_DEBUG, "DelayedServiceFactoryServiceFactory.ungetService()", getComponentMetadata(), null );
+        log( LogService.LOG_DEBUG, "ServiceFactory.ungetService()", getComponentMetadata(), null );
 
         // When the ungetServiceMethod is called, the implementation object must be deactivated
 
@@ -146,7 +146,7 @@
 				{
 					if (getState() == STATE_ACTIVE)
 					{
-						changeState(Factory.getInstance());
+						changeState(Registered.getInstance());
 					}
 				}
 			}