You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/26 13:26:55 UTC
[GitHub] [arrow-datafusion] alamb opened a new issue #150: Make MemoryStream public
alamb opened a new issue #150:
URL: https://github.com/apache/arrow-datafusion/issues/150
*Note*: migrated from original JIRA: https://issues.apache.org/jira/browse/ARROW-11276
I found the need to take a copy of MemoryStream for use in another project.
It would be nice if we could expose this as a supported public API so that other projects building physical operators can re-use it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb closed issue #150: Make MemoryStream public
Posted by GitBox <gi...@apache.org>.
alamb closed issue #150:
URL: https://github.com/apache/arrow-datafusion/issues/150
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] houqp commented on issue #150: Make MemoryStream public
Posted by GitBox <gi...@apache.org>.
houqp commented on issue #150:
URL: https://github.com/apache/arrow-datafusion/issues/150#issuecomment-950608480
I believe so, it is still marked as `pub(crate)`, but @alamb can confrim.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] 1nF0rmed commented on issue #150: Make MemoryStream public
Posted by GitBox <gi...@apache.org>.
1nF0rmed commented on issue #150:
URL: https://github.com/apache/arrow-datafusion/issues/150#issuecomment-950595977
Hey - is this something we are still looking at?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] 1nF0rmed edited a comment on issue #150: Make MemoryStream public
Posted by GitBox <gi...@apache.org>.
1nF0rmed edited a comment on issue #150:
URL: https://github.com/apache/arrow-datafusion/issues/150#issuecomment-953537523
@alamb if I understand correctly, the issue is looking at making [this](https://github.com/apache/arrow-datafusion/blob/295033492bbf335cdc02446cefb3751ab840f9b5/datafusion/src/physical_plan/memory.rs#L161-L171) `MemoryStream` `pub`. But there is also another reference under Ballista for the same [here](https://github.com/apache/arrow-datafusion/blob/bdae93b9365ef5892e686915250d42e927d00620/ballista/rust/core/src/memory_stream.rs#L29-L38), I assume that this is not related to the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] 1nF0rmed commented on issue #150: Make MemoryStream public
Posted by GitBox <gi...@apache.org>.
1nF0rmed commented on issue #150:
URL: https://github.com/apache/arrow-datafusion/issues/150#issuecomment-953537523
@alamb if I understand correctly, we are looking at making [this](https://github.com/apache/arrow-datafusion/blob/295033492bbf335cdc02446cefb3751ab840f9b5/datafusion/src/physical_plan/memory.rs#L161-L171) `MemoryStream` `pub`. But there is also another reference under Ballista for the same [here](https://github.com/apache/arrow-datafusion/blob/bdae93b9365ef5892e686915250d42e927d00620/ballista/rust/core/src/memory_stream.rs#L29-L38), I assume that this is not related to the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on issue #150: Make MemoryStream public
Posted by GitBox <gi...@apache.org>.
alamb commented on issue #150:
URL: https://github.com/apache/arrow-datafusion/issues/150#issuecomment-950783364
I think making `MemoryStream` `pub` and making sure it has sufficient test coverage sounds like a great idea to me 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb closed issue #150: Make MemoryStream public
Posted by GitBox <gi...@apache.org>.
alamb closed issue #150:
URL: https://github.com/apache/arrow-datafusion/issues/150
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on issue #150: Make MemoryStream public
Posted by GitBox <gi...@apache.org>.
alamb commented on issue #150:
URL: https://github.com/apache/arrow-datafusion/issues/150#issuecomment-953837996
> @alamb if I understand correctly, the issue is looking at making this MemoryStream pub. But there is also another reference under Ballista for the same here, I assume that this is not related to the issue.
That is a good find @1nF0rmed -- yes we are talking about making https://github.com/apache/arrow-datafusion/blob/295033492bbf335cdc02446cefb3751ab840f9b5/datafusion/src/physical_plan/memory.rs#L161-L171 public.
the fact that ballista has a copy/paste version of the same code is likely due to the fact that it is not `pub` lol -- so perhaps as part of the PR that makes `MemoryStream` pub we can remove the duplicate in Ballista
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org