You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/22 23:01:25 UTC
[GitHub] [airflow] jhtimmins opened a new pull request #13856: Don't add User role perms to custom roles.
jhtimmins opened a new pull request #13856:
URL: https://github.com/apache/airflow/pull/13856
<!--
Solves the problem of roles getting incorrectly populated with all permissions of the User class. Now they are auto-populated with Website.read and nothing else.
closes: #9245
related: #9245
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] davido912 commented on pull request #13856: Don't add User role perms to custom roles.
Posted by GitBox <gi...@apache.org>.
davido912 commented on pull request #13856:
URL: https://github.com/apache/airflow/pull/13856#issuecomment-766833806
I can confirm this does indeed fix the issue where a role would be populated with the USER permissions. I opened another issue that still remains. I've yet to find a fix for this but thanks for looking into this!
https://github.com/apache/airflow/issues/13891
@kaxil @jhtimmins
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #13856: Don't add User role perms to custom roles.
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #13856:
URL: https://github.com/apache/airflow/pull/13856#issuecomment-766877815
I have started seeing this warnings @jhtimmins -- after merging this to Master and running Airflow locally with it:
```
[2021-01-25 15:01:35,448] {manager.py:549} WARNING - Refused to delete permission view, assoc with role exists Airflow.can_elasticsearch Admin
[2021-01-25 15:01:35,456] {manager.py:549} WARNING - Refused to delete permission view, assoc with role exists Airflow.can_pickle_info Admin
[2021-01-25 15:01:35,462] {manager.py:549} WARNING - Refused to delete permission view, assoc with role exists Airflow.can_elasticsearch Admin
[2021-01-25 15:01:35,469] {manager.py:549} WARNING - Refused to delete permission view, assoc with role exists Airflow.can_pickle_info Admin
[2021-01-25 15:01:35,628] {manager.py:549} WARNING - Refused to delete permission view, assoc with role exists Airflow.can_elasticsearch Admin
[2021-01-25 15:01:35,635] {manager.py:549} WARNING - Refused to delete permission view, assoc with role exists Airflow.can_pickle_info Admin
[2021-01-25 15:01:35,665] {manager.py:549} WARNING - Refused to delete permission view, assoc with role exists Airflow.can_elasticsearch Admin
[2021-01-25 15:01:35,673] {manager.py:549} WARNING - Refused to delete permission view, assoc with role exists Airflow.can_pickle_info Admin
[2021-01-25 15:01:56 +0000] [389] [INFO] Handling signal: winch
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #13856: Don't add User role perms to custom roles.
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #13856:
URL: https://github.com/apache/airflow/pull/13856#issuecomment-765793523
That was quick :) -- Can you please add PR description describing the change and reference the Github issue it solves?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #13856: Don't add User role perms to custom roles.
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #13856:
URL: https://github.com/apache/airflow/pull/13856#issuecomment-766836367
Thanks @jhtimmins for the PR and @davido912 for testing it :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #13856: Don't add User role perms to custom roles.
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #13856:
URL: https://github.com/apache/airflow/pull/13856#issuecomment-765806953
cc @davido912
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #13856: Don't add User role perms to custom roles.
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #13856:
URL: https://github.com/apache/airflow/pull/13856#issuecomment-765807038
Thanks James, will take a deeper look over the weekend or Monday
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jhtimmins commented on pull request #13856: Don't add User role perms to custom roles.
Posted by GitBox <gi...@apache.org>.
jhtimmins commented on pull request #13856:
URL: https://github.com/apache/airflow/pull/13856#issuecomment-765800728
@kaxil My b, I thought I had added it. Updated!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #13856: Don't add User role perms to custom roles.
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #13856:
URL: https://github.com/apache/airflow/pull/13856#issuecomment-766836367
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil edited a comment on pull request #13856: Don't add User role perms to custom roles.
Posted by GitBox <gi...@apache.org>.
kaxil edited a comment on pull request #13856:
URL: https://github.com/apache/airflow/pull/13856#issuecomment-765807038
Thanks James, will take a deeper look over the weekend or Monday
This might fix https://github.com/apache/airflow/issues/13511 too
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #13856: Don't add User role perms to custom roles.
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #13856:
URL: https://github.com/apache/airflow/pull/13856
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #13856: Don't add User role perms to custom roles.
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #13856:
URL: https://github.com/apache/airflow/pull/13856
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] davido912 commented on pull request #13856: Don't add User role perms to custom roles.
Posted by GitBox <gi...@apache.org>.
davido912 commented on pull request #13856:
URL: https://github.com/apache/airflow/pull/13856#issuecomment-766833806
I can confirm this does indeed fix the issue where a role would be populated with the USER permissions. I opened another issue that still remains. I've yet to find a fix for this but thanks for looking into this!
https://github.com/apache/airflow/issues/13891
@kaxil @jhtimmins
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org