You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2019/11/24 19:48:37 UTC

[GitHub] [lucene-solr] epugh opened a new pull request #1033: SOLR-13965: Use Plugin to add new expressions to GraphHandler

epugh opened a new pull request #1033: SOLR-13965: Use Plugin to add new expressions to GraphHandler
URL: https://github.com/apache/lucene-solr/pull/1033
 
 
   # Description
   
   Adding new streaming expression functions is handled differently in StreamHandler from GraphHandler, and I believe they should be handled the same way.
   
   # Solution
   
   I removed the old `<streamFunctions/>` configuration in favor of using plugins in GraphHandler, which was how StreamHandler did it.
   
   # Tests
   No test changes, as there were none around this previously.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [ X] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
   - [ X] I have created a Jira issue and added the issue ID to my pull request title.
   - [ X] I am authorized to contribute this code to the ASF and have removed any code I do not have a license to distribute.
   - [ X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
   - [ X] I have developed this patch against the `master` branch.
   - [ X] I have run `ant precommit` and the appropriate test suite.
   - [ ] I have added tests for my changes.
   - [ X] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org