You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@livy.apache.org by GitBox <gi...@apache.org> on 2019/12/18 09:27:06 UTC

[GitHub] [incubator-livy] runzhiwang opened a new pull request #266: [LIVY-729] Fix livy recover the killed session

runzhiwang opened a new pull request #266: [LIVY-729] Fix livy recover the killed session
URL: https://github.com/apache/incubator-livy/pull/266
 
 
   ## What changes were proposed in this pull request?
   
   Follows are steps to reproduce the problem:
   
   1. Set livy.server.recovery.mode=recovery, and create an interactive session: session0 in yarn-cluster
   2. kill the yarn application of the session
   3. restart livy
   4. livy try to recover session0, but application has been killed and driver does not exist, so client can not connect to driver, and exception was thrown as the image.
   5. If the ip:port of the driver was reused by session1, client of session0 will try to connect to driver of session1, then driver will throw exception: Unexpected client ID.
   6. Both the exception threw by livy and driver will confuse the user, and recover a lot of killed sessions will delay the recover of alive session.
   ![image](https://user-images.githubusercontent.com/51938049/71066615-f0216280-21ad-11ea-9559-0cc0bd7d7546.png)
   
   How to fix:
   When session was killed or dead, remove the session from the store
   
   ## How was this patch tested?
   
   Existed IT and UT.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services