You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/12/13 02:33:39 UTC

[GitHub] [incubator-kyuubi] cfmcgrady commented on a change in pull request #1537: [KYUUBI #1536] Add engine conf provider

cfmcgrady commented on a change in pull request #1537:
URL: https://github.com/apache/incubator-kyuubi/pull/1537#discussion_r767377591



##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala
##########
@@ -50,6 +52,11 @@ class KyuubiSessionImpl(
     case (key, value) => sessionConf.set(key, value)
   }
 
+  sessionManager.engineConfAdvisor
+    .buildConf(user, sessionConf.getAll.asJava).asScala.foreach {
+      case (key, value) => sessionConf.set(key, value)

Review comment:
       Shall we add unit tests?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org