You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/17 10:18:59 UTC

[GitHub] [doris] mrhhsg commented on a diff in pull request #13355: [improvement](olap) try to read enough filtered rows in segment_iterator

mrhhsg commented on code in PR #13355:
URL: https://github.com/apache/doris/pull/13355#discussion_r996881116


##########
be/src/vec/columns/column_string.cpp:
##########
@@ -444,6 +445,7 @@ void ColumnString::resize(size_t n) {
     auto origin_size = size();
     if (origin_size > n) {
         offsets.resize(n);
+        chars.resize(offsets.back());

Review Comment:
   It should not be since n is smaller than origin_size.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org