You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by dongjoon-hyun <gi...@git.apache.org> on 2018/12/07 05:17:53 UTC

[GitHub] spark pull request #23225: [SPARK-26287][CORE]Don't need to create an empty ...

Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23225#discussion_r239697860
  
    --- Diff: core/src/test/java/org/apache/spark/shuffle/sort/UnsafeShuffleWriterSuite.java ---
    @@ -562,4 +562,18 @@ public void testPeakMemoryUsed() throws Exception {
         }
       }
     
    +  @Test
    +  public void writeEmptyIteratorNotCreateEmptySpillFile() throws Exception {
    --- End diff --
    
    This looks like mostly a duplication of `writeEmptyIterator`. Logically, do we need to keep both `writeEmptyIterator` and `writeEmptyIteratorNotCreateEmptySpillFile` seperately?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org