You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/01/01 22:44:17 UTC
[GitHub] [maven-surefire] Tibor17 opened a new pull request #424: Surefire shared utils,
Tibor17 opened a new pull request #424:
URL: https://github.com/apache/maven-surefire/pull/424
We are aiming for an upgrade of the version of `org.apache.maven.surefire.shared.lang3.JavaVersion` which means that we have to install/deploy **current version** of `surefire-shared-utils`.
Then we are able to implement the method `isSecurityManagerSupported()` within the module `surefire-api` using the enum `JavaVersion`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #424: Surefire shared utils,
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #424:
URL: https://github.com/apache/maven-surefire/pull/424#issuecomment-1003632660
@slawekjaranowski
I agree that comparing the Java version would be more straightaway solution. To get there I had to proceed with the first two commits. The first makes the module `surefire-shared-utils` available to our project with current project version. And then I had to upgrade `comon-lang3` of course. And the third commit is just our method in module `surefire-api`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on pull request #424: Surefire shared utils,
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on pull request #424:
URL: https://github.com/apache/maven-surefire/pull/424#issuecomment-1003690560
There is issues to link:
- SUREFIRE-1972 - Use current version of surefire-shared-utils
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #424: Surefire shared utils,
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #424:
URL: https://github.com/apache/maven-surefire/pull/424#issuecomment-1003787709
@slawekjaranowski
@eolivelli
The first commit appears in #426.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #424: Surefire shared utils,
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #424:
URL: https://github.com/apache/maven-surefire/pull/424#issuecomment-1003754837
@slawekjaranowski
Of course I can create PRs for these commits.
This draft provides everybody with context for JDK 18 fix (see the PR #422) regarding deprecated [SecurityManager](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/lang/SecurityManager.html).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #424: Surefire shared utils,
Posted by GitBox <gi...@apache.org>.
Tibor17 edited a comment on pull request #424:
URL: https://github.com/apache/maven-surefire/pull/424#issuecomment-1003632660
@slawekjaranowski
I agree that comparing the Java version would be more straightaway solution. To get there I had to proceed with the first two commits. The first makes the module `surefire-shared-utils` available to our project with current project version. And then I had to upgrade `commons-lang3` of course. And the third commit is just our method in module `surefire-api`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 closed pull request #424: Surefire shared utils,
Posted by GitBox <gi...@apache.org>.
Tibor17 closed pull request #424:
URL: https://github.com/apache/maven-surefire/pull/424
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org