You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Zoltan Chovan (Code Review)" <ge...@cloudera.org> on 2025/03/06 16:07:46 UTC

[kudu-CR] [java] Modernise codebase

Zoltan Chovan has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22589


Change subject: [java] Modernise codebase
......................................................................

[java] Modernise codebase

While reviewing the java code, I noticed that there are many instances
where not even Java 8 features are used, in this particular case: lambdas.

This change replaces many instances of unnecessary boilerplate (anonymous
methods and classes), and in a few cases replaces the ThreadLocal
initialisation with 'ThreadLocal.withInitial()'. The intent is to improve
code readability, so a few places[0][1] where lambdas could've been used, but
only with worse readability, the code was left as is. Also where possible,
lambdas were replaced by method references.

There are no functional changes, so no new tests are introduced.

[0] https://github.com/apache/kudu/blob/master/java/kudu-client/src/test/java/org/apache/kudu/client/ITClientStress.java#L116
[1] https://github.com/apache/kudu/blob/master/java/kudu-client/src/test/java/org/apache/kudu/client/ITClientStress.java#L148
// both of these would result in something like () -> () -> {..}

Change-Id: Ice41e86c666e7589662ec0c5ffa0b0e7dd493a98
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Connection.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RpcProxy.java
M java/kudu-client/src/main/java/org/apache/kudu/util/Slices.java
M java/kudu-client/src/main/java/org/apache/kudu/util/TimestampUtil.java
M java/kudu-client/src/test/java/org/apache/kudu/TestColumnSchema.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITClientStress.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthTokenReacquire.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestClientFailoverSupport.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestFlexiblePartitioning.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHandleTooBusy.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTransaction.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestMultiMasterAuthzTokens.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestMultipleLeaderFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRequestTracker.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
M java/kudu-subprocess/src/test/java/org/apache/kudu/subprocess/TestMessageIO.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/CapturingLogAppender.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/CapturingToFileLogAppender.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/TempDirUtils.java
M java/kudu-test-utils/src/test/java/org/apache/kudu/test/TestMiniKuduCluster.java
29 files changed, 358 insertions(+), 580 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/89/22589/1
-- 
To view, visit http://gerrit.cloudera.org:8080/22589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ice41e86c666e7589662ec0c5ffa0b0e7dd493a98
Gerrit-Change-Number: 22589
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>

[kudu-CR] [java] Modernise codebase

Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Alexey Serbin, Attila Bukor, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22589

to look at the new patch set (#2).

Change subject: [java] Modernise codebase
......................................................................

[java] Modernise codebase

While reviewing the java code, I noticed that there are many instances
where not even Java 8 features are used, in this particular case: lambdas.

This change replaces many instances of unnecessary boilerplate (anonymous
methods and classes), and in a few cases replaces the ThreadLocal
initialisation with 'ThreadLocal.withInitial()'. The intent is to improve
code readability, so a few places[0][1] where lambdas could've been used, but
only with worse readability, the code was left as is. Also where possible,
lambdas were replaced by method references.

There are no functional changes, so no new tests are introduced.

[0] https://github.com/apache/kudu/blob/master/java/kudu-client/src/test/java/org/apache/kudu/client/ITClientStress.java#L116
[1] https://github.com/apache/kudu/blob/master/java/kudu-client/src/test/java/org/apache/kudu/client/ITClientStress.java#L148
// both of these would result in something like () -> () -> {..}

Change-Id: Ice41e86c666e7589662ec0c5ffa0b0e7dd493a98
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Connection.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RpcProxy.java
M java/kudu-client/src/main/java/org/apache/kudu/util/Slices.java
M java/kudu-client/src/main/java/org/apache/kudu/util/TimestampUtil.java
M java/kudu-client/src/test/java/org/apache/kudu/TestColumnSchema.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITClientStress.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthTokenReacquire.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestClientFailoverSupport.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestFlexiblePartitioning.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHandleTooBusy.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTransaction.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestMultiMasterAuthzTokens.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestMultipleLeaderFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRequestTracker.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
M java/kudu-subprocess/src/test/java/org/apache/kudu/subprocess/TestMessageIO.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/CapturingLogAppender.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/CapturingToFileLogAppender.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/TempDirUtils.java
M java/kudu-test-utils/src/test/java/org/apache/kudu/test/TestMiniKuduCluster.java
29 files changed, 359 insertions(+), 577 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/89/22589/2
-- 
To view, visit http://gerrit.cloudera.org:8080/22589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ice41e86c666e7589662ec0c5ffa0b0e7dd493a98
Gerrit-Change-Number: 22589
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>

[kudu-CR] [java] Modernise codebase

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22589 )

Change subject: [java] Modernise codebase
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1142/


-- 
To view, visit http://gerrit.cloudera.org:8080/22589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice41e86c666e7589662ec0c5ffa0b0e7dd493a98
Gerrit-Change-Number: 22589
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 06 Mar 2025 16:07:53 +0000
Gerrit-HasComments: No

[kudu-CR] [java] Modernise codebase

Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/22589 )

Change subject: [java] Modernise codebase
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> There are too many warnings and style errors in PS1.  It usually a good idea to run lint-related Gradle tasks locally before submitting a patch for review if working on a code change like this.
> 
> https://jenkins.kudu.apache.org/job/build_and_test/7120/console
> 
> FAILURE: Build failed with an exception.
> 
> * What went wrong:
> Execution failed for task ':kudu-client:checkstyleTest'.
> > A failure occurred while executing org.gradle.api.plugins.quality.internal.CheckstyleAction
>    > Checkstyle rule violations were found. See the report at: file:///home/jenkins-slave/workspace/build_and_test/java/kudu-client/build/reports/checkstyle/test.html
>      Checkstyle files with violations: 5
>      Checkstyle violations by severity: [warning:40]

Yeah, I ran `./gradlew checkstyleMain` which passed, but apparently it doesn't check the test files, fixing these in the next PS.


-- 
To view, visit http://gerrit.cloudera.org:8080/22589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice41e86c666e7589662ec0c5ffa0b0e7dd493a98
Gerrit-Change-Number: 22589
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 07 Mar 2025 08:40:57 +0000
Gerrit-HasComments: No

[kudu-CR] [java] Modernise codebase

Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/22589 )

Change subject: [java] Modernise codebase
......................................................................


Patch Set 2:

> Patch Set 2: Verified-1
> 
> Build Failed 
> 
> http://jenkins.kudu.apache.org/job/pre_commit/1149/ : FAILURE

TSAN failure doesn't seem related, test failed with a timeout.


-- 
To view, visit http://gerrit.cloudera.org:8080/22589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice41e86c666e7589662ec0c5ffa0b0e7dd493a98
Gerrit-Change-Number: 22589
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 10 Mar 2025 11:18:32 +0000
Gerrit-HasComments: No

[kudu-CR] [java] Modernise codebase

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22589 )

Change subject: [java] Modernise codebase
......................................................................


Patch Set 1:

There are too many warnings and style errors in PS1.  It usually a good idea to run lint-related Gradle tasks locally before submitting a patch for review if working on a code change like this.

https://jenkins.kudu.apache.org/job/build_and_test/7120/console

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':kudu-client:checkstyleTest'.
> A failure occurred while executing org.gradle.api.plugins.quality.internal.CheckstyleAction
   > Checkstyle rule violations were found. See the report at: file:///home/jenkins-slave/workspace/build_and_test/java/kudu-client/build/reports/checkstyle/test.html
     Checkstyle files with violations: 5
     Checkstyle violations by severity: [warning:40]


-- 
To view, visit http://gerrit.cloudera.org:8080/22589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice41e86c666e7589662ec0c5ffa0b0e7dd493a98
Gerrit-Change-Number: 22589
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 06 Mar 2025 20:06:28 +0000
Gerrit-HasComments: No

[kudu-CR] [java] Modernise codebase

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22589 )

Change subject: [java] Modernise codebase
......................................................................


Patch Set 2:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1149/


-- 
To view, visit http://gerrit.cloudera.org:8080/22589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice41e86c666e7589662ec0c5ffa0b0e7dd493a98
Gerrit-Change-Number: 22589
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 07 Mar 2025 09:10:36 +0000
Gerrit-HasComments: No

[kudu-CR] [java] Modernise codebase

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22589 )

Change subject: [java] Modernise codebase
......................................................................


Patch Set 1: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1142/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/22589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice41e86c666e7589662ec0c5ffa0b0e7dd493a98
Gerrit-Change-Number: 22589
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 06 Mar 2025 16:12:08 +0000
Gerrit-HasComments: No

[kudu-CR] [java] Modernise codebase

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22589 )

Change subject: [java] Modernise codebase
......................................................................


Patch Set 2: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1149/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/22589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice41e86c666e7589662ec0c5ffa0b0e7dd493a98
Gerrit-Change-Number: 22589
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 07 Mar 2025 10:33:04 +0000
Gerrit-HasComments: No

[kudu-CR] [java] Modernise codebase

Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has abandoned this change. ( http://gerrit.cloudera.org:8080/22589 )

Change subject: [java] Modernise codebase
......................................................................


Abandoned
-- 
To view, visit http://gerrit.cloudera.org:8080/22589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ice41e86c666e7589662ec0c5ffa0b0e7dd493a98
Gerrit-Change-Number: 22589
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>