You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2018/12/11 08:39:55 UTC

[GitHub] shaofengshi commented on a change in pull request #378: KYLIN-3597 Improve code smell

shaofengshi commented on a change in pull request #378: KYLIN-3597 Improve code smell
URL: https://github.com/apache/kylin/pull/378#discussion_r240513630
 
 

 ##########
 File path: query/src/main/java/org/apache/kylin/query/relnode/visitor/TupleFilterVisitor.java
 ##########
 @@ -130,10 +130,10 @@ public TupleFilter visitCall(RexCall call) {
                 // is a trivial expr
                 return f;
             }
-            //else go to default
-        default:
             filter = new UnsupportedTupleFilter(TupleFilter.FilterOperatorEnum.UNSUPPORTED);
             break;
+        default:
 
 Review comment:
   Here has duplicated UnsupportedTupleFilter?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services