You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@velocity.apache.org by "Claude Brisson (JIRA)" <ji...@apache.org> on 2006/11/28 13:37:21 UTC
[jira] Created: (VELOCITY-502) Skip jar verification unless
"force.jar.loading" is true
Skip jar verification unless "force.jar.loading" is true
--------------------------------------------------------
Key: VELOCITY-502
URL: http://issues.apache.org/jira/browse/VELOCITY-502
Project: Velocity
Issue Type: Improvement
Components: Engine
Affects Versions: 1.5 beta2
Environment: all
Reporter: Claude Brisson
Attachments: jar-downloading.patch
When the www.iblibo.org/maven repository is down (as it seems right now, at least from here), or when you want to work form an unconnected place (yes, it still exists...), build fails because ant wants to check every jar timestamp.
The attached patch modifies this behaviour: if a jar file is already present, the repository is not hit at all (why would we have to check any timestamp anyway since version numbers are present inside filenames?!).
The new force.jar.loading property forces reloading of jar files.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Commented: (VELOCITY-502) Skip jar verification unless
"force.jar.loading" is true
Posted by "Will Glass-Husain (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/VELOCITY-502?page=comments#action_12453913 ]
Will Glass-Husain commented on VELOCITY-502:
--------------------------------------------
this means that we have three behaviors then?
-- normal - only download jars if missing
-- skip.jar.download - never download jars
-- force.jar.download -- always download jars
Is this right?
> Skip jar verification unless "force.jar.loading" is true
> --------------------------------------------------------
>
> Key: VELOCITY-502
> URL: http://issues.apache.org/jira/browse/VELOCITY-502
> Project: Velocity
> Issue Type: Improvement
> Components: Engine
> Affects Versions: 1.5 beta2
> Environment: all
> Reporter: Claude Brisson
> Attachments: jar-downloading.patch
>
>
> When the www.iblibo.org/maven repository is down (as it seems right now, at least from here), or when you want to work form an unconnected place (yes, it still exists...), build fails because ant wants to check every jar timestamp.
> The attached patch modifies this behaviour: if a jar file is already present, the repository is not hit at all (why would we have to check any timestamp anyway since version numbers are present inside filenames?!).
> The new force.jar.loading property forces reloading of jar files.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Updated: (VELOCITY-502) Skip jar verification unless
"force.jar.loading" is true
Posted by "Will Glass-Husain (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/VELOCITY-502?page=all ]
Will Glass-Husain updated VELOCITY-502:
---------------------------------------
Component/s: Build
(was: Engine)
Fix Version/s: 1.5
Priority: Minor (was: Major)
> Skip jar verification unless "force.jar.loading" is true
> --------------------------------------------------------
>
> Key: VELOCITY-502
> URL: http://issues.apache.org/jira/browse/VELOCITY-502
> Project: Velocity
> Issue Type: Improvement
> Components: Build
> Affects Versions: 1.5 beta2
> Environment: all
> Reporter: Claude Brisson
> Priority: Minor
> Fix For: 1.5
>
> Attachments: jar-downloading.patch
>
>
> When the www.iblibo.org/maven repository is down (as it seems right now, at least from here), or when you want to work form an unconnected place (yes, it still exists...), build fails because ant wants to check every jar timestamp.
> The attached patch modifies this behaviour: if a jar file is already present, the repository is not hit at all (why would we have to check any timestamp anyway since version numbers are present inside filenames?!).
> The new force.jar.loading property forces reloading of jar files.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Commented: (VELOCITY-502) Skip jar verification unless
"force.jar.loading" is true
Posted by "Claude Brisson (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/VELOCITY-502?page=comments#action_12454266 ]
Claude Brisson commented on VELOCITY-502:
-----------------------------------------
Le mardi 28 novembre 2006 à 12:14 -0800, Henning Schmiedehausen (JIRA) a écrit :
> I tried ant -Dforce.jar.loading=1 and force.jar.loading=0 with no success until I found out that it's -Dforce.jar.loading=true that works.
Ant properties allow "on","true" and "yes", but not 1... I guess you should not play lotto this week.
> [...]
> check ---> Current behaviour. Check for presence, if missing download, if existing, check timestamp.
>
Are you sure you want to keep this one? There is no point in checking timestamps of versionned filenames.
> [...]
> But I don't want to have a second (different named, booo!) property whose semantics are different
> from skip.jar.loading (here, presence is enough, for the proposed change the property must actually
> contain the 'True' value) which muddles the options that an user must go through.
I agree that the semantics should be the same, good point (I hadn't noticed this behaviour of the "unless" attribute). But I'd rather have skip.jar.loading semantics modified, because having the property "skip.jar.loading=false" still skiping jar loading looks rather confusing.
Also, your proposal seems much more difficult to document, whereas just putting
skip.jar.loading = false
force.jar.loading = false
inside build.properties is straightforward to anybody taking a look at the file.
> Skip jar verification unless "force.jar.loading" is true
> --------------------------------------------------------
>
> Key: VELOCITY-502
> URL: http://issues.apache.org/jira/browse/VELOCITY-502
> Project: Velocity
> Issue Type: Improvement
> Components: Build
> Affects Versions: 1.5 beta2
> Environment: all
> Reporter: Claude Brisson
> Priority: Minor
> Fix For: 1.5
>
> Attachments: jar-downloading.patch
>
>
> When the www.iblibo.org/maven repository is down (as it seems right now, at least from here), or when you want to work form an unconnected place (yes, it still exists...), build fails because ant wants to check every jar timestamp.
> The attached patch modifies this behaviour: if a jar file is already present, the repository is not hit at all (why would we have to check any timestamp anyway since version numbers are present inside filenames?!).
> The new force.jar.loading property forces reloading of jar files.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Closed: (VELOCITY-502) Skip jar verification unless
"force.jar.loading" is true
Posted by "Claude Brisson (JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELOCITY-502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claude Brisson closed VELOCITY-502.
-----------------------------------
> Skip jar verification unless "force.jar.loading" is true
> --------------------------------------------------------
>
> Key: VELOCITY-502
> URL: https://issues.apache.org/jira/browse/VELOCITY-502
> Project: Velocity
> Issue Type: Improvement
> Components: Build
> Affects Versions: 1.5 beta2
> Environment: all
> Reporter: Claude Brisson
> Assigned To: Claude Brisson
> Priority: Minor
> Fix For: 1.5
>
> Attachments: jar-downloading.patch
>
>
> When the www.iblibo.org/maven repository is down (as it seems right now, at least from here), or when you want to work form an unconnected place (yes, it still exists...), build fails because ant wants to check every jar timestamp.
> The attached patch modifies this behaviour: if a jar file is already present, the repository is not hit at all (why would we have to check any timestamp anyway since version numbers are present inside filenames?!).
> The new force.jar.loading property forces reloading of jar files.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Closed: (VELOCITY-502) Skip jar verification unless
"force.jar.loading" is true
Posted by "Henning Schmiedehausen (JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELOCITY-502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henning Schmiedehausen closed VELOCITY-502.
-------------------------------------------
> Skip jar verification unless "force.jar.loading" is true
> --------------------------------------------------------
>
> Key: VELOCITY-502
> URL: https://issues.apache.org/jira/browse/VELOCITY-502
> Project: Velocity
> Issue Type: Improvement
> Components: Build
> Affects Versions: 1.5 beta2
> Environment: all
> Reporter: Claude Brisson
> Assigned To: Henning Schmiedehausen
> Priority: Minor
> Fix For: 1.5
>
> Attachments: jar-downloading.patch
>
>
> When the www.iblibo.org/maven repository is down (as it seems right now, at least from here), or when you want to work form an unconnected place (yes, it still exists...), build fails because ant wants to check every jar timestamp.
> The attached patch modifies this behaviour: if a jar file is already present, the repository is not hit at all (why would we have to check any timestamp anyway since version numbers are present inside filenames?!).
> The new force.jar.loading property forces reloading of jar files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Resolved: (VELOCITY-502) Skip jar verification unless
"force.jar.loading" is true
Posted by "Henning Schmiedehausen (JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELOCITY-502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henning Schmiedehausen resolved VELOCITY-502.
---------------------------------------------
Resolution: Fixed
> Skip jar verification unless "force.jar.loading" is true
> --------------------------------------------------------
>
> Key: VELOCITY-502
> URL: https://issues.apache.org/jira/browse/VELOCITY-502
> Project: Velocity
> Issue Type: Improvement
> Components: Build
> Affects Versions: 1.5 beta2
> Environment: all
> Reporter: Claude Brisson
> Assigned To: Henning Schmiedehausen
> Priority: Minor
> Fix For: 1.5
>
> Attachments: jar-downloading.patch
>
>
> When the www.iblibo.org/maven repository is down (as it seems right now, at least from here), or when you want to work form an unconnected place (yes, it still exists...), build fails because ant wants to check every jar timestamp.
> The attached patch modifies this behaviour: if a jar file is already present, the repository is not hit at all (why would we have to check any timestamp anyway since version numbers are present inside filenames?!).
> The new force.jar.loading property forces reloading of jar files.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Commented: (VELOCITY-502) Skip jar verification unless
"force.jar.loading" is true
Posted by "Henning Schmiedehausen (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/VELOCITY-502?page=comments#action_12454099 ]
Henning Schmiedehausen commented on VELOCITY-502:
-------------------------------------------------
Hm. That is a *very* specific patch. I tried ant -Dforce.jar.loading=1 and force.jar.loading=0 with no success until I found out that it's -Dforce.jar.loading=true that works.
It is a good and useful idea, but I'm not sure if we don't already have that semantics. We don't have them automatically, I agree.
I'm actually -1 on that patch. I would agree to a patch that removes -Dskip.jar.loading and adds the following property and behaviour:
velocity.jar.download
never ---> Never go to the internet. Like skip.jar.loading= true
once ---> Proposed behaviour. Check for presence, if missing download. If existing, do nothing.
check ---> Current behaviour. Check for presence, if missing download, if existing, check timestamp.
always ---> Like "force.jar.loading"
We can argue whether "once" or "check" should be the default.
Building the jar is a rare case for our users. They only do it if the want to debug a patch or a change. In that case, you want the build succeed and not chase a wild goose because of a stale jar. If ibiblio gets in your way, add -Dskip.jar.loading
to your .build.properties. But I don't want to have a second (different named, booo!) property whose semantics are different from skip.jar.loading (here, presence is enough, for the proposed change the property must actually contain the 'True' value) which muddles the options that an user must go through.
> Skip jar verification unless "force.jar.loading" is true
> --------------------------------------------------------
>
> Key: VELOCITY-502
> URL: http://issues.apache.org/jira/browse/VELOCITY-502
> Project: Velocity
> Issue Type: Improvement
> Components: Build
> Affects Versions: 1.5 beta2
> Environment: all
> Reporter: Claude Brisson
> Priority: Minor
> Fix For: 1.5
>
> Attachments: jar-downloading.patch
>
>
> When the www.iblibo.org/maven repository is down (as it seems right now, at least from here), or when you want to work form an unconnected place (yes, it still exists...), build fails because ant wants to check every jar timestamp.
> The attached patch modifies this behaviour: if a jar file is already present, the repository is not hit at all (why would we have to check any timestamp anyway since version numbers are present inside filenames?!).
> The new force.jar.loading property forces reloading of jar files.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Reopened: (VELOCITY-502) Skip jar verification unless
"force.jar.loading" is true
Posted by "Henning Schmiedehausen (JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELOCITY-502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henning Schmiedehausen reopened VELOCITY-502:
---------------------------------------------
Assignee: Henning Schmiedehausen (was: Claude Brisson)
> Skip jar verification unless "force.jar.loading" is true
> --------------------------------------------------------
>
> Key: VELOCITY-502
> URL: https://issues.apache.org/jira/browse/VELOCITY-502
> Project: Velocity
> Issue Type: Improvement
> Components: Build
> Affects Versions: 1.5 beta2
> Environment: all
> Reporter: Claude Brisson
> Assigned To: Henning Schmiedehausen
> Priority: Minor
> Fix For: 1.5
>
> Attachments: jar-downloading.patch
>
>
> When the www.iblibo.org/maven repository is down (as it seems right now, at least from here), or when you want to work form an unconnected place (yes, it still exists...), build fails because ant wants to check every jar timestamp.
> The attached patch modifies this behaviour: if a jar file is already present, the repository is not hit at all (why would we have to check any timestamp anyway since version numbers are present inside filenames?!).
> The new force.jar.loading property forces reloading of jar files.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Commented: (VELOCITY-502) Skip jar verification unless
"force.jar.loading" is true
Posted by "Claude Brisson (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/VELOCITY-502?page=comments#action_12453915 ]
Claude Brisson commented on VELOCITY-502:
-----------------------------------------
Right.
> Skip jar verification unless "force.jar.loading" is true
> --------------------------------------------------------
>
> Key: VELOCITY-502
> URL: http://issues.apache.org/jira/browse/VELOCITY-502
> Project: Velocity
> Issue Type: Improvement
> Components: Build
> Affects Versions: 1.5 beta2
> Environment: all
> Reporter: Claude Brisson
> Priority: Minor
> Fix For: 1.5
>
> Attachments: jar-downloading.patch
>
>
> When the www.iblibo.org/maven repository is down (as it seems right now, at least from here), or when you want to work form an unconnected place (yes, it still exists...), build fails because ant wants to check every jar timestamp.
> The attached patch modifies this behaviour: if a jar file is already present, the repository is not hit at all (why would we have to check any timestamp anyway since version numbers are present inside filenames?!).
> The new force.jar.loading property forces reloading of jar files.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Updated: (VELOCITY-502) Skip jar verification unless
"force.jar.loading" is true
Posted by "Claude Brisson (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/VELOCITY-502?page=all ]
Claude Brisson updated VELOCITY-502:
------------------------------------
Attachment: jar-downloading.patch
> Skip jar verification unless "force.jar.loading" is true
> --------------------------------------------------------
>
> Key: VELOCITY-502
> URL: http://issues.apache.org/jira/browse/VELOCITY-502
> Project: Velocity
> Issue Type: Improvement
> Components: Engine
> Affects Versions: 1.5 beta2
> Environment: all
> Reporter: Claude Brisson
> Attachments: jar-downloading.patch
>
>
> When the www.iblibo.org/maven repository is down (as it seems right now, at least from here), or when you want to work form an unconnected place (yes, it still exists...), build fails because ant wants to check every jar timestamp.
> The attached patch modifies this behaviour: if a jar file is already present, the repository is not hit at all (why would we have to check any timestamp anyway since version numbers are present inside filenames?!).
> The new force.jar.loading property forces reloading of jar files.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Assigned: (VELOCITY-502) Skip jar verification unless
"force.jar.loading" is true
Posted by "Henning Schmiedehausen (JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELOCITY-502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henning Schmiedehausen reassigned VELOCITY-502:
-----------------------------------------------
Assignee: Claude Brisson
Please resolve this issue if you are satisfied with the applied patch.
> Skip jar verification unless "force.jar.loading" is true
> --------------------------------------------------------
>
> Key: VELOCITY-502
> URL: https://issues.apache.org/jira/browse/VELOCITY-502
> Project: Velocity
> Issue Type: Improvement
> Components: Build
> Affects Versions: 1.5 beta2
> Environment: all
> Reporter: Claude Brisson
> Assigned To: Claude Brisson
> Priority: Minor
> Fix For: 1.5
>
> Attachments: jar-downloading.patch
>
>
> When the www.iblibo.org/maven repository is down (as it seems right now, at least from here), or when you want to work form an unconnected place (yes, it still exists...), build fails because ant wants to check every jar timestamp.
> The attached patch modifies this behaviour: if a jar file is already present, the repository is not hit at all (why would we have to check any timestamp anyway since version numbers are present inside filenames?!).
> The new force.jar.loading property forces reloading of jar files.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Resolved: (VELOCITY-502) Skip jar verification unless
"force.jar.loading" is true
Posted by "Claude Brisson (JIRA)" <de...@velocity.apache.org>.
[ https://issues.apache.org/jira/browse/VELOCITY-502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claude Brisson resolved VELOCITY-502.
-------------------------------------
Resolution: Fixed
> Skip jar verification unless "force.jar.loading" is true
> --------------------------------------------------------
>
> Key: VELOCITY-502
> URL: https://issues.apache.org/jira/browse/VELOCITY-502
> Project: Velocity
> Issue Type: Improvement
> Components: Build
> Affects Versions: 1.5 beta2
> Environment: all
> Reporter: Claude Brisson
> Assigned To: Claude Brisson
> Priority: Minor
> Fix For: 1.5
>
> Attachments: jar-downloading.patch
>
>
> When the www.iblibo.org/maven repository is down (as it seems right now, at least from here), or when you want to work form an unconnected place (yes, it still exists...), build fails because ant wants to check every jar timestamp.
> The attached patch modifies this behaviour: if a jar file is already present, the repository is not hit at all (why would we have to check any timestamp anyway since version numbers are present inside filenames?!).
> The new force.jar.loading property forces reloading of jar files.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Commented: (VELOCITY-502) Skip jar verification unless
"force.jar.loading" is true
Posted by "Claude Brisson (JIRA)" <de...@velocity.apache.org>.
[ http://issues.apache.org/jira/browse/VELOCITY-502?page=comments#action_12460649 ]
Claude Brisson commented on VELOCITY-502:
-----------------------------------------
So what do we do here?
We have two proposals:
1.Henning's proposal:
velocity.jar.loading = never / once / check / always
(where the utility of "check" is questionnable, that would let us with "never / once / always")
2. mine:
skip.jar.loading = true / false
force.jar.loading = true / false
(including changing the rather strange current behaviour of skip.jar.loading, which is to have an effect even when set with the value "false"...)
Both are probably acceptable, and Henning's proposal is maybe more rigoureous (one parameter controlling one behaviour),
mine is maybe more self-explanatory (but allows the strange mode skip=true & force=true, where one will discover that skip has the precedence, do we
really care, sometimes we loose ourselves in details, it's incredible).
Veltools has already made a step towards option 2 (but it is not irreversible). I'd just like to close this trivial issue. Option 2 is also a little easier to implement in ant. Thoughts? If nobody react here I'll commit in option 2.
> Skip jar verification unless "force.jar.loading" is true
> --------------------------------------------------------
>
> Key: VELOCITY-502
> URL: http://issues.apache.org/jira/browse/VELOCITY-502
> Project: Velocity
> Issue Type: Improvement
> Components: Build
> Affects Versions: 1.5 beta2
> Environment: all
> Reporter: Claude Brisson
> Priority: Minor
> Fix For: 1.5
>
> Attachments: jar-downloading.patch
>
>
> When the www.iblibo.org/maven repository is down (as it seems right now, at least from here), or when you want to work form an unconnected place (yes, it still exists...), build fails because ant wants to check every jar timestamp.
> The attached patch modifies this behaviour: if a jar file is already present, the repository is not hit at all (why would we have to check any timestamp anyway since version numbers are present inside filenames?!).
> The new force.jar.loading property forces reloading of jar files.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
Re: [jira] Commented: (VELOCITY-502) Skip jar verification unless "force.jar.loading" is true
Posted by Nathan Bubna <nb...@gmail.com>.
On 12/23/06, Claude Brisson <cl...@renegat.net> wrote:
> Le samedi 23 décembre 2006 à 15:45 -0800, Nathan Bubna (JIRA) a écrit :
> > I don't really care. Both have advantages, both will work fine. If you're going to do the work, i say you should get to decide. :)
>
> That's the "new commiter" syndrom... feeling like having to ask before
> doing nasty things inside the sourcetree... it will pass... ;-)
:) well, in your defense, it is polite to give a heads up before
acting on something that was being debated. of course, for me there's
few arguments stronger than action, especially when it comes to
something inconsequential like this.
>
> Claude
>
> >
> > > Skip jar verification unless "force.jar.loading" is true
> > > --------------------------------------------------------
> > >
> > > Key: VELOCITY-502
> > > URL: http://issues.apache.org/jira/browse/VELOCITY-502
> > > Project: Velocity
> > > Issue Type: Improvement
> > > Components: Build
> > > Affects Versions: 1.5 beta2
> > > Environment: all
> > > Reporter: Claude Brisson
> > > Priority: Minor
> > > Fix For: 1.5
> > >
> > > Attachments: jar-downloading.patch
> > >
> > >
> > > When the www.iblibo.org/maven repository is down (as it seems right now, at least from here), or when you want to work form an unconnected place (yes, it still exists...), build fails because ant wants to check every jar timestamp.
> > > The attached patch modifies this behaviour: if a jar file is already present, the repository is not hit at all (why would we have to check any timestamp anyway since version numbers are present inside filenames?!).
> > > The new force.jar.loading property forces reloading of jar files.
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
> For additional commands, e-mail: dev-help@velocity.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
Re: [jira] Commented: (VELOCITY-502) Skip jar verification unless
"force.jar.loading" is true
Posted by Claude Brisson <cl...@renegat.net>.
Le samedi 23 décembre 2006 à 15:45 -0800, Nathan Bubna (JIRA) a écrit :
> I don't really care. Both have advantages, both will work fine. If you're going to do the work, i say you should get to decide. :)
That's the "new commiter" syndrom... feeling like having to ask before
doing nasty things inside the sourcetree... it will pass... ;-)
Claude
>
> > Skip jar verification unless "force.jar.loading" is true
> > --------------------------------------------------------
> >
> > Key: VELOCITY-502
> > URL: http://issues.apache.org/jira/browse/VELOCITY-502
> > Project: Velocity
> > Issue Type: Improvement
> > Components: Build
> > Affects Versions: 1.5 beta2
> > Environment: all
> > Reporter: Claude Brisson
> > Priority: Minor
> > Fix For: 1.5
> >
> > Attachments: jar-downloading.patch
> >
> >
> > When the www.iblibo.org/maven repository is down (as it seems right now, at least from here), or when you want to work form an unconnected place (yes, it still exists...), build fails because ant wants to check every jar timestamp.
> > The attached patch modifies this behaviour: if a jar file is already present, the repository is not hit at all (why would we have to check any timestamp anyway since version numbers are present inside filenames?!).
> > The new force.jar.loading property forces reloading of jar files.
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Commented: (VELOCITY-502) Skip jar verification unless
"force.jar.loading" is true
Posted by "Nathan Bubna (JIRA)" <de...@velocity.apache.org>.
[ http://issues.apache.org/jira/browse/VELOCITY-502?page=comments#action_12460669 ]
Nathan Bubna commented on VELOCITY-502:
---------------------------------------
I don't really care. Both have advantages, both will work fine. If you're going to do the work, i say you should get to decide. :)
> Skip jar verification unless "force.jar.loading" is true
> --------------------------------------------------------
>
> Key: VELOCITY-502
> URL: http://issues.apache.org/jira/browse/VELOCITY-502
> Project: Velocity
> Issue Type: Improvement
> Components: Build
> Affects Versions: 1.5 beta2
> Environment: all
> Reporter: Claude Brisson
> Priority: Minor
> Fix For: 1.5
>
> Attachments: jar-downloading.patch
>
>
> When the www.iblibo.org/maven repository is down (as it seems right now, at least from here), or when you want to work form an unconnected place (yes, it still exists...), build fails because ant wants to check every jar timestamp.
> The attached patch modifies this behaviour: if a jar file is already present, the repository is not hit at all (why would we have to check any timestamp anyway since version numbers are present inside filenames?!).
> The new force.jar.loading property forces reloading of jar files.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Commented: (VELOCITY-502) Skip jar verification unless
"force.jar.loading" is true
Posted by "Nathan Bubna (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/VELOCITY-502?page=comments#action_12454118 ]
Nathan Bubna commented on VELOCITY-502:
---------------------------------------
This is even better, but only so long as the 4 options are listed and described in build.properties above the default.
My preference for the default is definitely "once", because--like Claude--i don't see any real point in checking timestamps. Version numbers should be quite sufficient.
> Skip jar verification unless "force.jar.loading" is true
> --------------------------------------------------------
>
> Key: VELOCITY-502
> URL: http://issues.apache.org/jira/browse/VELOCITY-502
> Project: Velocity
> Issue Type: Improvement
> Components: Build
> Affects Versions: 1.5 beta2
> Environment: all
> Reporter: Claude Brisson
> Priority: Minor
> Fix For: 1.5
>
> Attachments: jar-downloading.patch
>
>
> When the www.iblibo.org/maven repository is down (as it seems right now, at least from here), or when you want to work form an unconnected place (yes, it still exists...), build fails because ant wants to check every jar timestamp.
> The attached patch modifies this behaviour: if a jar file is already present, the repository is not hit at all (why would we have to check any timestamp anyway since version numbers are present inside filenames?!).
> The new force.jar.loading property forces reloading of jar files.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org