You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "bzp2010 (via GitHub)" <gi...@apache.org> on 2025/05/18 12:44:25 UTC
[PR] test: improve typescript test suite [apisix]
bzp2010 opened a new pull request, #12226:
URL: https://github.com/apache/apisix/pull/12226
### Description
Split from #12196, modifications in functionality and testing frameworks were introduced there, making those PR not pure.
First we can merge this PR, after that rebase that PR, we can make that PR to focus on the function, also easy to backport.
### Checklist
- [x] I have explained the need for this PR and the problem it solves
- [x] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [ ] I have updated the documentation to reflect this change
- [x] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: improve typescript-based test framework [apisix]
Posted by "bzp2010 (via GitHub)" <gi...@apache.org>.
bzp2010 commented on code in PR #12226:
URL: https://github.com/apache/apisix/pull/12226#discussion_r2094768087
##########
t/ts/admin_api.ts:
##########
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import axios, { type Method, type RawAxiosRequestHeaders } from 'axios';
+
+export const request = async (
+ uri: string,
+ method: Method = 'GET',
+ body?: object,
+ headers?: RawAxiosRequestHeaders,
+) => {
+ return axios.request({
+ method,
+ // TODO: use 9180 for admin api
+ url: `http://127.0.0.1:1984/${uri}`,
+ data: body,
+ headers: {
+ 'X-API-KEY': 'edd1c9f034335f136f87ad84b625c8f1',
Review Comment:
It could be. But the hardcoded ones seem to be sufficient for now.
This is because this server is spawned by test nginx and not by the new test framework itself (it doesn't even use the standard APISIX startup process), which sucks and will be improved later so that ts test can autonomously start or stop APISIX instances (right now it has to rely on a xxx.t "shell" file to boot)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: improve typescript-based test framework [apisix]
Posted by "bzp2010 (via GitHub)" <gi...@apache.org>.
bzp2010 commented on code in PR #12226:
URL: https://github.com/apache/apisix/pull/12226#discussion_r2094768087
##########
t/ts/admin_api.ts:
##########
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import axios, { type Method, type RawAxiosRequestHeaders } from 'axios';
+
+export const request = async (
+ uri: string,
+ method: Method = 'GET',
+ body?: object,
+ headers?: RawAxiosRequestHeaders,
+) => {
+ return axios.request({
+ method,
+ // TODO: use 9180 for admin api
+ url: `http://127.0.0.1:1984/${uri}`,
+ data: body,
+ headers: {
+ 'X-API-KEY': 'edd1c9f034335f136f87ad84b625c8f1',
Review Comment:
It could be. But the hardcoded ones seem to be sufficient for now.
This is because this server is spawned by test nginx and not by the new test framework itself (it doesn't even use the standard APISIX startup process), which sucks and will be improved later so that ts test can autonomously start or stop APISIX instances (right now it has to rely on a xxx.t shell file)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: improve typescript-based test framework [apisix]
Posted by "bzp2010 (via GitHub)" <gi...@apache.org>.
bzp2010 merged PR #12226:
URL: https://github.com/apache/apisix/pull/12226
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: improve typescript-based test framework [apisix]
Posted by "SkyeYoung (via GitHub)" <gi...@apache.org>.
SkyeYoung commented on code in PR #12226:
URL: https://github.com/apache/apisix/pull/12226#discussion_r2094764629
##########
t/ts/admin_api.ts:
##########
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import axios, { type Method, type RawAxiosRequestHeaders } from 'axios';
+
+export const request = async (
+ uri: string,
+ method: Method = 'GET',
+ body?: object,
+ headers?: RawAxiosRequestHeaders,
+) => {
+ return axios.request({
+ method,
+ // TODO: use 9180 for admin api
+ url: `http://127.0.0.1:1984/${uri}`,
+ data: body,
+ headers: {
+ 'X-API-KEY': 'edd1c9f034335f136f87ad84b625c8f1',
Review Comment:
can we pick it from apisix config?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org