You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/11/18 10:43:40 UTC

[GitHub] [beam] bullet03 opened a new pull request, #24251: [Website] add lazy loading attr to images

bullet03 opened a new pull request, #24251:
URL: https://github.com/apache/beam/pull/24251

   Resolves #24250
   - add `loading="lazy"` attribute to case-study images. It doesn't decrease the speed of loading, slightly increases it. More case-studies and logos are going to be added soon, so they load only when user scrolls to them. This will improve the speed of page loading
   ------------------------
   before:
   ![before_lazy](https://user-images.githubusercontent.com/61748758/202683468-e8095d83-b48d-4357-b01f-d6ca3ac670f7.JPG)
   ![before_lazy_2](https://user-images.githubusercontent.com/61748758/202683487-58120a45-a4a9-4004-bef2-2da3b552362a.JPG)
   after:
   ![after_lazy](https://user-images.githubusercontent.com/61748758/202683541-dd73f47a-27f4-4f54-a444-63a898283236.JPG)
   ![after_lazy_1](https://user-images.githubusercontent.com/61748758/202683565-74611172-4973-4395-b090-8709df933bdc.JPG)
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] bullet03 commented on pull request #24251: [Website] add lazy loading attr to images

Posted by GitBox <gi...@apache.org>.
bullet03 commented on PR #24251:
URL: https://github.com/apache/beam/pull/24251#issuecomment-1323246402

   @aromanenko-dev, could you, please help with review of current PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] AlyaBoiko commented on pull request #24251: [Website] add lazy loading attr to images

Posted by GitBox <gi...@apache.org>.
AlyaBoiko commented on PR #24251:
URL: https://github.com/apache/beam/pull/24251#issuecomment-1320077644

   Verified, works as expected. Reviewed and tested by QA


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] aromanenko-dev merged pull request #24251: [Website] add lazy loading attr to images

Posted by GitBox <gi...@apache.org>.
aromanenko-dev merged PR #24251:
URL: https://github.com/apache/beam/pull/24251


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org