You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/19 20:29:24 UTC

[GitHub] [incubator-superset] villebro opened a new pull request #11334: chore(prophet): ignore logged warning for missing plotly package

villebro opened a new pull request #11334:
URL: https://github.com/apache/incubator-superset/pull/11334


   ### SUMMARY
   When running Prophet for the first time, the following error is logged:
   
   ```ERROR:fbprophet.plot:Importing plotly failed. Interactive plots will not work.```
   
   This PR disables this warning as recommended here: https://github.com/facebook/prophet/pull/1332#issuecomment-587184404
   
   ### TEST PLAN
   Tested locally that the error is no longer logged.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] villebro merged pull request #11334: chore(prophet): ignore logged warning for missing plotly package

Posted by GitBox <gi...@apache.org>.
villebro merged pull request #11334:
URL: https://github.com/apache/incubator-superset/pull/11334


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #11334: chore(prophet): ignore logged warning for missing plotly package

Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #11334:
URL: https://github.com/apache/incubator-superset/pull/11334#discussion_r508215936



##########
File path: superset/utils/pandas_postprocessing.py
##########
@@ -590,6 +591,9 @@ def _prophet_fit_and_predict(  # pylint: disable=too-many-arguments
     Fit a prophet model and return a DataFrame with predicted results.
     """
     try:
+        prophet_logger = logging.getLogger("fbprophet.plot")
+
+        prophet_logger.setLevel(logging.CRITICAL)

Review comment:
       I don't feel strongly about it either, but should we crank the level back up after the import?

##########
File path: superset/utils/pandas_postprocessing.py
##########
@@ -590,6 +591,9 @@ def _prophet_fit_and_predict(  # pylint: disable=too-many-arguments
     Fit a prophet model and return a DataFrame with predicted results.
     """
     try:
+        prophet_logger = logging.getLogger("fbprophet.plot")
+
+        prophet_logger.setLevel(logging.CRITICAL)

Review comment:
       I don't feel strongly about it either way, but should we crank the level back up after the import?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] villebro commented on a change in pull request #11334: chore(prophet): ignore logged warning for missing plotly package

Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #11334:
URL: https://github.com/apache/incubator-superset/pull/11334#discussion_r508233972



##########
File path: superset/utils/pandas_postprocessing.py
##########
@@ -590,6 +591,9 @@ def _prophet_fit_and_predict(  # pylint: disable=too-many-arguments
     Fit a prophet model and return a DataFrame with predicted results.
     """
     try:
+        prophet_logger = logging.getLogger("fbprophet.plot")
+
+        prophet_logger.setLevel(logging.CRITICAL)

Review comment:
       Good idea. Updated and verified that initial error stays unlogged.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org