You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/10/28 08:48:17 UTC
[GitHub] [bookkeeper] yaalsn opened a new pull request, #3586: Add code coverage report and upload to Codecov
yaalsn opened a new pull request, #3586:
URL: https://github.com/apache/bookkeeper/pull/3586
### Motivation
Bookkeeper has already added jacoco plugin but it doesn't work in Github action, and it seems original code coverage reports are uploaded to [coveralls](https://coveralls.io/github/apache/bookkeeper?branch=master) by jenkins. Currently, we use Github action, so let's try it and switch to CodeCov.
### Changes
- Add code-coverage profile in every unit test command
- Add uploading to CodeCov github action in every module's test workflow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] zymap commented on pull request #3586: Add code coverage report and upload to Codecov
Posted by GitBox <gi...@apache.org>.
zymap commented on PR #3586:
URL: https://github.com/apache/bookkeeper/pull/3586#issuecomment-1301564000
It's better to send an email about this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli merged pull request #3586: Add code coverage report and upload to Codecov
Posted by "eolivelli (via GitHub)" <gi...@apache.org>.
eolivelli merged PR #3586:
URL: https://github.com/apache/bookkeeper/pull/3586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hangc0276 commented on pull request #3586: Add code coverage report and upload to Codecov
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on PR #3586:
URL: https://github.com/apache/bookkeeper/pull/3586#issuecomment-1378345784
@yaalsn Thanks for your contribution, would you please help resolve those conflicts? thanks a lot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] yaalsn commented on pull request #3586: Add code coverage report and upload to Codecov
Posted by GitBox <gi...@apache.org>.
yaalsn commented on PR #3586:
URL: https://github.com/apache/bookkeeper/pull/3586#issuecomment-1294859234
base coverage (master branch) will be updated after this PR merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] codecov-commenter commented on pull request #3586: Add code coverage report and upload to Codecov
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3586:
URL: https://github.com/apache/bookkeeper/pull/3586#issuecomment-1294776438
# [Codecov](https://codecov.io/gh/apache/bookkeeper/pull/3586?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`master@ef31c7a`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #3586 +/- ##
=========================================
Coverage ? 47.90%
Complexity ? 5182
=========================================
Files ? 592
Lines ? 44633
Branches ? 5572
=========================================
Hits ? 21380
Misses ? 21121
Partials ? 2132
```
| Flag | Coverage Δ | |
|---|---|---|
| remaining | `42.26% <0.00%> (?)` | |
| replication | `29.74% <0.00%> (?)` | |
| tls | `21.27% <0.00%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] yaalsn commented on pull request #3586: Add code coverage report and upload to Codecov
Posted by "yaalsn (via GitHub)" <gi...@apache.org>.
yaalsn commented on PR #3586:
URL: https://github.com/apache/bookkeeper/pull/3586#issuecomment-1408072964
@hangc0276 Done, PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org