You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Nicolas Malin (JIRA)" <ji...@apache.org> on 2010/06/02 14:25:39 UTC

[jira] Created: (OFBIZ-3798) Add generic service to call xml-rpc request

Add generic service to call xml-rpc request
-------------------------------------------

                 Key: OFBIZ-3798
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3798
             Project: OFBiz
          Issue Type: New Feature
          Components: framework
    Affects Versions: SVN trunk
            Reporter: Nicolas Malin
            Priority: Minor
             Fix For: SVN trunk


I add a generic service to call xml-rpc server. The goal is to have a technical interface to make calls directly from mini-lang.

The first patch it's my draft. I don't know where I do the service definition. I add a servicedef in framework/webapp, I move service on framework/common ? any suggest are welcom ;)

Nicolas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-3798) Add xml-rpc engine on serviceengine

Posted by "Erwan de FERRIERES (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12883651#action_12883651 ] 

Erwan de FERRIERES commented on OFBIZ-3798:
-------------------------------------------

done at r959071.
Thanks Nicolas and all for reviewing !

> Add xml-rpc engine on serviceengine
> -----------------------------------
>
>                 Key: OFBIZ-3798
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3798
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Nicolas Malin
>            Assignee: Erwan de FERRIERES
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: MoveXmlRpcClassFromWebappToService.patch, svn-cmd-toMoveXmlRpcClassFromWebappToService.sh, xml-rpc-client-engine.diff, xml-rpc-engine.diff, xml-rpc.diff, XmlRpcEngine.patch
>
>
> I add a generic service to call xml-rpc server. The goal is to have a technical interface to make calls directly from mini-lang.
> The first patch it's my draft. I don't know where I do the service definition. I add a servicedef in framework/webapp, I move service on framework/common ? any suggest are welcom ;)
> Nicolas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OFBIZ-3798) Add generic service to call xml-rpc request

Posted by "Nicolas Malin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nicolas Malin updated OFBIZ-3798:
---------------------------------

    Attachment: XmlRpcEngine.patch

I recreate a patch with a new xml-rpc service engine, It's a draft because I have a problem with login and password need by xml-rpc server.

I use login.username and login.password to get values but I think it's service information. I propose to add extern-username extern-password attribut on service definition as :

 <service name="XmlRpcCallServiceExample" engine="xml-rpc" location="http://XmlRpcServer/path/to/connector" invoke="MethodName" extern-username="login" extern-password="pass">
...
</service>

any suggest ?

> Add generic service to call xml-rpc request
> -------------------------------------------
>
>                 Key: OFBIZ-3798
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3798
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Nicolas Malin
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: xml-rpc.diff, XmlRpcEngine.patch
>
>
> I add a generic service to call xml-rpc server. The goal is to have a technical interface to make calls directly from mini-lang.
> The first patch it's my draft. I don't know where I do the service definition. I add a servicedef in framework/webapp, I move service on framework/common ? any suggest are welcom ;)
> Nicolas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OFBIZ-3798) Add xml-rpc engine on serviceengine

Posted by "Erwan de FERRIERES (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erwan de FERRIERES updated OFBIZ-3798:
--------------------------------------

    Assignee: Erwan de FERRIERES

> Add xml-rpc engine on serviceengine
> -----------------------------------
>
>                 Key: OFBIZ-3798
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3798
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Nicolas Malin
>            Assignee: Erwan de FERRIERES
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: MoveXmlRpcClassFromWebappToService.patch, svn-cmd-toMoveXmlRpcClassFromWebappToService.sh, xml-rpc-client-engine.diff, xml-rpc-engine.diff, xml-rpc.diff, XmlRpcEngine.patch
>
>
> I add a generic service to call xml-rpc server. The goal is to have a technical interface to make calls directly from mini-lang.
> The first patch it's my draft. I don't know where I do the service definition. I add a servicedef in framework/webapp, I move service on framework/common ? any suggest are welcom ;)
> Nicolas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-3798) Add generic service to call xml-rpc request

Posted by "Nicolas Malin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874814#action_12874814 ] 

Nicolas Malin commented on OFBIZ-3798:
--------------------------------------

Really thanks for your return adrian and adam. 

I go in a very bad way with my generic service. If I understand your comment adam I have the following result :

<service name="XmlRpcCallServiceExample" engine="xml-rpc" location="http://XmlRpcServer/path/to/connector" invoke="MethodName">
  ...
</service>

and in mini-lang, just generic : <call-service ... > 

I think that is a good solution and I will work on XML-RPC service handler. Tks for your light ;)

> Add generic service to call xml-rpc request
> -------------------------------------------
>
>                 Key: OFBIZ-3798
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3798
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Nicolas Malin
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: xml-rpc.diff
>
>
> I add a generic service to call xml-rpc server. The goal is to have a technical interface to make calls directly from mini-lang.
> The first patch it's my draft. I don't know where I do the service definition. I add a servicedef in framework/webapp, I move service on framework/common ? any suggest are welcom ;)
> Nicolas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (OFBIZ-3798) Add xml-rpc engine on serviceengine

Posted by "Erwan de FERRIERES (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erwan de FERRIERES closed OFBIZ-3798.
-------------------------------------

    Resolution: Fixed

> Add xml-rpc engine on serviceengine
> -----------------------------------
>
>                 Key: OFBIZ-3798
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3798
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Nicolas Malin
>            Assignee: Erwan de FERRIERES
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: MoveXmlRpcClassFromWebappToService.patch, svn-cmd-toMoveXmlRpcClassFromWebappToService.sh, xml-rpc-client-engine.diff, xml-rpc-engine.diff, xml-rpc.diff, XmlRpcEngine.patch
>
>
> I add a generic service to call xml-rpc server. The goal is to have a technical interface to make calls directly from mini-lang.
> The first patch it's my draft. I don't know where I do the service definition. I add a servicedef in framework/webapp, I move service on framework/common ? any suggest are welcom ;)
> Nicolas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-3798) Add xml-rpc engine on serviceengine

Posted by "Nicolas Malin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12877070#action_12877070 ] 

Nicolas Malin commented on OFBIZ-3798:
--------------------------------------

I rename Jira for better understanding.

To resolv my problem to store information need by engine as xml-rpc I propose two solution.

1. I add config on service-engine to have a solution has :
   <engine name="xml-rpc-server1" class="org.ofbiz.service.engine.XmlRpcEngine">
        <parameter field="server.login" value="XXX"/>
        <parameter field="server.password" value="YYY"/>
   </engine>
   <engine name="xml-rpc-server2" class="org.ofbiz.service.engine.XmlRpcEngine">
        <parameter field="server.login" value="ZZZ"/>
        <parameter field="server.password" value="EEE"/>
        <parameter field="server.keys" value="AZERTY"/>
        <parameter field="server.auth" value="http://tiers.com"/>
   </engine>

and service definition :
<service name="XmlRpcCallServiceExample" engine="xml-rpc-server1" location="http://XmlRpcServer/path/to/connector" invoke="MethodName">
...
</service>

<service name="XmlRpcCallServiceExample2" engine="xml-rpc-server2" location="http://XmlRpcServer/path/to/connector" invoke="MethodName">
...
</service>

OR 

2. I add an attribute to service definition to given a properties ressources as :

<service name="XmlRpcCallServiceExample" engine="xml-rpc" location="http://XmlRpcServer/path/to/connector" invoke="MethodName" engine-config="XmlRpcServer1.properties">
...
</service>

<service name="XmlRpcCallServiceExample2" engine="xml-rpc" location="http://XmlRpcServer/path/to/connector" invoke="MethodName"> engine-config="XmlRpcServer2.properties" >
...
</service>

Config file present in hot-deploy (hors other)
XmlRpcServer1.properties :
    login=XXX
    password=YYY
XmlRpcServer2.properties :
    login=ZZZ
    password=AAA
    keys=AZERTY
    auth=http://tiers.com

The first solution give the possibility to define engine oriented on process but need change the serviceengine.xml 
The second solution is less generic than the first but more easier to custom customer server.

At your comments ;)

> Add xml-rpc engine on serviceengine
> -----------------------------------
>
>                 Key: OFBIZ-3798
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3798
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Nicolas Malin
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: xml-rpc.diff, XmlRpcEngine.patch
>
>
> I add a generic service to call xml-rpc server. The goal is to have a technical interface to make calls directly from mini-lang.
> The first patch it's my draft. I don't know where I do the service definition. I add a servicedef in framework/webapp, I move service on framework/common ? any suggest are welcom ;)
> Nicolas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OFBIZ-3798) Add xml-rpc engine on serviceengine

Posted by "Nicolas Malin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nicolas Malin updated OFBIZ-3798:
---------------------------------

    Attachment: xml-rpc-client-engine.diff

I improve engine xml-rpc call, change object list by map that contains all parameters "IN"
I add a test case that use another method to receive xml-rpc call

> Add xml-rpc engine on serviceengine
> -----------------------------------
>
>                 Key: OFBIZ-3798
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3798
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Nicolas Malin
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: MoveXmlRpcClassFromWebappToService.patch, svn-cmd-toMoveXmlRpcClassFromWebappToService.sh, xml-rpc-client-engine.diff, xml-rpc-engine.diff, xml-rpc.diff, XmlRpcEngine.patch
>
>
> I add a generic service to call xml-rpc server. The goal is to have a technical interface to make calls directly from mini-lang.
> The first patch it's my draft. I don't know where I do the service definition. I add a servicedef in framework/webapp, I move service on framework/common ? any suggest are welcom ;)
> Nicolas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-3798) Add generic service to call xml-rpc request

Posted by "Nicolas Malin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874604#action_12874604 ] 

Nicolas Malin commented on OFBIZ-3798:
--------------------------------------

Yes it's also a possibility :) but by this way, it's just generic for mini-lan not for other. I can do both solutions ;)

A call-xml-rpc with by default configuration present in config file and a generic service has I begun ?

> Add generic service to call xml-rpc request
> -------------------------------------------
>
>                 Key: OFBIZ-3798
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3798
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Nicolas Malin
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: xml-rpc.diff
>
>
> I add a generic service to call xml-rpc server. The goal is to have a technical interface to make calls directly from mini-lang.
> The first patch it's my draft. I don't know where I do the service definition. I add a servicedef in framework/webapp, I move service on framework/common ? any suggest are welcom ;)
> Nicolas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OFBIZ-3798) Add xml-rpc engine on serviceengine

Posted by "Nicolas Malin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nicolas Malin updated OFBIZ-3798:
---------------------------------

    Attachment:     (was: xml-rpc-client-engine.diff)

> Add xml-rpc engine on serviceengine
> -----------------------------------
>
>                 Key: OFBIZ-3798
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3798
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Nicolas Malin
>            Assignee: Erwan de FERRIERES
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: MoveXmlRpcClassFromWebappToService.patch, svn-cmd-toMoveXmlRpcClassFromWebappToService.sh, xmlrpc.patch
>
>
> I add a generic service to call xml-rpc server. The goal is to have a technical interface to make calls directly from mini-lang.
> The first patch it's my draft. I don't know where I do the service definition. I add a servicedef in framework/webapp, I move service on framework/common ? any suggest are welcom ;)
> Nicolas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OFBIZ-3798) Add xml-rpc engine on serviceengine

Posted by "Nicolas Malin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nicolas Malin updated OFBIZ-3798:
---------------------------------

    Attachment:     (was: xml-rpc.diff)

> Add xml-rpc engine on serviceengine
> -----------------------------------
>
>                 Key: OFBIZ-3798
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3798
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Nicolas Malin
>            Assignee: Erwan de FERRIERES
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: MoveXmlRpcClassFromWebappToService.patch, svn-cmd-toMoveXmlRpcClassFromWebappToService.sh, xmlrpc.patch
>
>
> I add a generic service to call xml-rpc server. The goal is to have a technical interface to make calls directly from mini-lang.
> The first patch it's my draft. I don't know where I do the service definition. I add a servicedef in framework/webapp, I move service on framework/common ? any suggest are welcom ;)
> Nicolas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-3798) Add generic service to call xml-rpc request

Posted by "Adam Heath (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874641#action_12874641 ] 

Adam Heath commented on OFBIZ-3798:
-----------------------------------

Having a service-engine to xml-rpc proxy is the correct approach.  Otherwise, all the various code paths scattered all over will end up having tons and tons of different ways to access abstract, generic services, and will increase the workload.  Code in ofbiz should only be concerned with talking to the entity engine, or service engine, then those two engines should be responsible for figuring out how to talk to whatever thing has been requested.

> Add generic service to call xml-rpc request
> -------------------------------------------
>
>                 Key: OFBIZ-3798
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3798
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Nicolas Malin
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: xml-rpc.diff
>
>
> I add a generic service to call xml-rpc server. The goal is to have a technical interface to make calls directly from mini-lang.
> The first patch it's my draft. I don't know where I do the service definition. I add a servicedef in framework/webapp, I move service on framework/common ? any suggest are welcom ;)
> Nicolas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-3798) Add generic service to call xml-rpc request

Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874601#action_12874601 ] 

Adrian Crum commented on OFBIZ-3798:
------------------------------------

>From my perspective, it would be nice to have a call-xml-rpc mini-language method. Could could copy and modify the existing call-service mini-language method.


> Add generic service to call xml-rpc request
> -------------------------------------------
>
>                 Key: OFBIZ-3798
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3798
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Nicolas Malin
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: xml-rpc.diff
>
>
> I add a generic service to call xml-rpc server. The goal is to have a technical interface to make calls directly from mini-lang.
> The first patch it's my draft. I don't know where I do the service definition. I add a servicedef in framework/webapp, I move service on framework/common ? any suggest are welcom ;)
> Nicolas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OFBIZ-3798) Add xml-rpc engine on serviceengine

Posted by "Nicolas Malin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nicolas Malin updated OFBIZ-3798:
---------------------------------

    Attachment: MoveXmlRpcClassFromWebappToService.patch
                xmlrpc.patch
                svn-cmd-toMoveXmlRpcClassFromWebappToService.sh

Oh my apologies Erwan for the commit that break trunk. I checked to understand why and I found a missing jar in service lib path.

With svn it's not easy to do file moving in patch. I recreate the process from scratch with updating xmlrpc apache lib from 3.0 to 3.1.2

To apply patch I use this process :
 checkout ofbiz from trunk
 cd ofbiz
 sh svn-cmd-toMoveXmlRpcClassFromWebappToService.sh
 patch -p0 < xmlrpc.patch
 patch -p0 < MoveXmlRpcClassFromWebappToService.patch
 cd framework/base/lib
 tar xmlRpcJar3.1.2.tar
 cd -; ant run-install && ant run-tests

Test successed :)

> Add xml-rpc engine on serviceengine
> -----------------------------------
>
>                 Key: OFBIZ-3798
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3798
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Nicolas Malin
>            Assignee: Erwan de FERRIERES
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: MoveXmlRpcClassFromWebappToService.patch, svn-cmd-toMoveXmlRpcClassFromWebappToService.sh, xmlrpc.patch
>
>
> I add a generic service to call xml-rpc server. The goal is to have a technical interface to make calls directly from mini-lang.
> The first patch it's my draft. I don't know where I do the service definition. I add a servicedef in framework/webapp, I move service on framework/common ? any suggest are welcom ;)
> Nicolas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (OFBIZ-3798) Add xml-rpc engine on serviceengine

Posted by "Erwan de FERRIERES (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erwan de FERRIERES closed OFBIZ-3798.
-------------------------------------

    Resolution: Fixed

Done at 959261. Thanks nicolas for the quick update.

> Add xml-rpc engine on serviceengine
> -----------------------------------
>
>                 Key: OFBIZ-3798
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3798
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Nicolas Malin
>            Assignee: Erwan de FERRIERES
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: MoveXmlRpcClassFromWebappToService.patch, svn-cmd-toMoveXmlRpcClassFromWebappToService.sh, xmlrpc.patch, xmlRpcJar3.1.2.tar
>
>
> I add a generic service to call xml-rpc server. The goal is to have a technical interface to make calls directly from mini-lang.
> The first patch it's my draft. I don't know where I do the service definition. I add a servicedef in framework/webapp, I move service on framework/common ? any suggest are welcom ;)
> Nicolas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-3798) Add xml-rpc engine on serviceengine

Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12877093#action_12877093 ] 

Adrian Crum commented on OFBIZ-3798:
------------------------------------

Nicolas,

I think it would be better if the authentication credentials were service parameters.

> Add xml-rpc engine on serviceengine
> -----------------------------------
>
>                 Key: OFBIZ-3798
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3798
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Nicolas Malin
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: xml-rpc.diff, XmlRpcEngine.patch
>
>
> I add a generic service to call xml-rpc server. The goal is to have a technical interface to make calls directly from mini-lang.
> The first patch it's my draft. I don't know where I do the service definition. I add a servicedef in framework/webapp, I move service on framework/common ? any suggest are welcom ;)
> Nicolas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (OFBIZ-3798) Add xml-rpc engine on serviceengine

Posted by "Erwan de FERRIERES (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erwan de FERRIERES reopened OFBIZ-3798:
---------------------------------------


Please take a look at this page :
http://ci.apache.org/builders/ofbiz-trunk/builds/241

> Add xml-rpc engine on serviceengine
> -----------------------------------
>
>                 Key: OFBIZ-3798
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3798
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Nicolas Malin
>            Assignee: Erwan de FERRIERES
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: MoveXmlRpcClassFromWebappToService.patch, svn-cmd-toMoveXmlRpcClassFromWebappToService.sh, xml-rpc-client-engine.diff, xml-rpc-engine.diff, xml-rpc.diff, XmlRpcEngine.patch
>
>
> I add a generic service to call xml-rpc server. The goal is to have a technical interface to make calls directly from mini-lang.
> The first patch it's my draft. I don't know where I do the service definition. I add a servicedef in framework/webapp, I move service on framework/common ? any suggest are welcom ;)
> Nicolas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OFBIZ-3798) Add xml-rpc engine on serviceengine

Posted by "Nicolas Malin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nicolas Malin updated OFBIZ-3798:
---------------------------------

    Attachment:     (was: MoveXmlRpcClassFromWebappToService.patch)

> Add xml-rpc engine on serviceengine
> -----------------------------------
>
>                 Key: OFBIZ-3798
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3798
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Nicolas Malin
>            Assignee: Erwan de FERRIERES
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: MoveXmlRpcClassFromWebappToService.patch, svn-cmd-toMoveXmlRpcClassFromWebappToService.sh, xmlrpc.patch
>
>
> I add a generic service to call xml-rpc server. The goal is to have a technical interface to make calls directly from mini-lang.
> The first patch it's my draft. I don't know where I do the service definition. I add a servicedef in framework/webapp, I move service on framework/common ? any suggest are welcom ;)
> Nicolas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (OFBIZ-3798) Add generic service to call xml-rpc request

Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874601#action_12874601 ] 

Adrian Crum edited comment on OFBIZ-3798 at 6/2/10 11:02 AM:
-------------------------------------------------------------

>From my perspective, it would be nice to have a call-xml-rpc mini-language method. You could copy and modify the existing call-service mini-language method.


      was (Author: adrianc@hlmksw.com):
    From my perspective, it would be nice to have a call-xml-rpc mini-language method. Could could copy and modify the existing call-service mini-language method.

  
> Add generic service to call xml-rpc request
> -------------------------------------------
>
>                 Key: OFBIZ-3798
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3798
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Nicolas Malin
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: xml-rpc.diff
>
>
> I add a generic service to call xml-rpc server. The goal is to have a technical interface to make calls directly from mini-lang.
> The first patch it's my draft. I don't know where I do the service definition. I add a servicedef in framework/webapp, I move service on framework/common ? any suggest are welcom ;)
> Nicolas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-3798) Add generic service to call xml-rpc request

Posted by "Scott Gray (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12876604#action_12876604 ] 

Scott Gray commented on OFBIZ-3798:
-----------------------------------

It might not hurt to take a look at the existing XmlRpcClient class in OFBiz and see if it helps with https configuration.

> Add generic service to call xml-rpc request
> -------------------------------------------
>
>                 Key: OFBIZ-3798
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3798
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Nicolas Malin
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: xml-rpc.diff, XmlRpcEngine.patch
>
>
> I add a generic service to call xml-rpc server. The goal is to have a technical interface to make calls directly from mini-lang.
> The first patch it's my draft. I don't know where I do the service definition. I add a servicedef in framework/webapp, I move service on framework/common ? any suggest are welcom ;)
> Nicolas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OFBIZ-3798) Add generic service to call xml-rpc request

Posted by "Nicolas Malin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nicolas Malin updated OFBIZ-3798:
---------------------------------

    Attachment: xml-rpc.diff

> Add generic service to call xml-rpc request
> -------------------------------------------
>
>                 Key: OFBIZ-3798
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3798
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Nicolas Malin
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: xml-rpc.diff
>
>
> I add a generic service to call xml-rpc server. The goal is to have a technical interface to make calls directly from mini-lang.
> The first patch it's my draft. I don't know where I do the service definition. I add a servicedef in framework/webapp, I move service on framework/common ? any suggest are welcom ;)
> Nicolas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-3798) Add generic service to call xml-rpc request

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12877039#action_12877039 ] 

Jacques Le Roux commented on OFBIZ-3798:
----------------------------------------

Be careful Nicolas to not add your specific .project file ;)

> Add generic service to call xml-rpc request
> -------------------------------------------
>
>                 Key: OFBIZ-3798
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3798
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Nicolas Malin
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: xml-rpc.diff, XmlRpcEngine.patch
>
>
> I add a generic service to call xml-rpc server. The goal is to have a technical interface to make calls directly from mini-lang.
> The first patch it's my draft. I don't know where I do the service definition. I add a servicedef in framework/webapp, I move service on framework/common ? any suggest are welcom ;)
> Nicolas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-3798) Add generic service to call xml-rpc request

Posted by "Malin Nicolas (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12877043#action_12877043 ] 

Malin Nicolas commented on OFBIZ-3798:
--------------------------------------

Arg, so speed :/

But it's not for inclusion, it's a draft :D (yes I know, stupid excuse ;) )

Nicolas




> Add generic service to call xml-rpc request
> -------------------------------------------
>
>                 Key: OFBIZ-3798
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3798
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Nicolas Malin
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: xml-rpc.diff, XmlRpcEngine.patch
>
>
> I add a generic service to call xml-rpc server. The goal is to have a technical interface to make calls directly from mini-lang.
> The first patch it's my draft. I don't know where I do the service definition. I add a servicedef in framework/webapp, I move service on framework/common ? any suggest are welcom ;)
> Nicolas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-3798) Add xml-rpc engine on serviceengine

Posted by "Nicolas Malin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12883895#action_12883895 ] 

Nicolas Malin commented on OFBIZ-3798:
--------------------------------------

Thanks erwan for commit and Adrian for the review/suggest

> Add xml-rpc engine on serviceengine
> -----------------------------------
>
>                 Key: OFBIZ-3798
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3798
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Nicolas Malin
>            Assignee: Erwan de FERRIERES
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: MoveXmlRpcClassFromWebappToService.patch, svn-cmd-toMoveXmlRpcClassFromWebappToService.sh, xmlrpc.patch, xmlRpcJar3.1.2.tar
>
>
> I add a generic service to call xml-rpc server. The goal is to have a technical interface to make calls directly from mini-lang.
> The first patch it's my draft. I don't know where I do the service definition. I add a servicedef in framework/webapp, I move service on framework/common ? any suggest are welcom ;)
> Nicolas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OFBIZ-3798) Add xml-rpc engine on serviceengine

Posted by "Nicolas Malin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nicolas Malin updated OFBIZ-3798:
---------------------------------

    Attachment:     (was: xml-rpc-engine.diff)

> Add xml-rpc engine on serviceengine
> -----------------------------------
>
>                 Key: OFBIZ-3798
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3798
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Nicolas Malin
>            Assignee: Erwan de FERRIERES
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: MoveXmlRpcClassFromWebappToService.patch, svn-cmd-toMoveXmlRpcClassFromWebappToService.sh, xmlrpc.patch
>
>
> I add a generic service to call xml-rpc server. The goal is to have a technical interface to make calls directly from mini-lang.
> The first patch it's my draft. I don't know where I do the service definition. I add a servicedef in framework/webapp, I move service on framework/common ? any suggest are welcom ;)
> Nicolas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OFBIZ-3798) Add xml-rpc engine on serviceengine

Posted by "Nicolas Malin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nicolas Malin updated OFBIZ-3798:
---------------------------------

    Attachment: xml-rpc-engine.diff
                MoveXmlRpcClassFromWebappToService.patch
                svn-cmd-toMoveXmlRpcClassFromWebappToService.sh

Hi, 

I finalise with youssef khaye a first release. The patch contains :
 * possibility to add technical parameters to an engine
 * Xml-Rpc engine
 * A service test : testXmlRpcClientAdd

We move xml-rpc class to service and lib to base. 
To install :
 * simple method : install neogia addons http://addons.neogia.org/addons/xml-rpc-client-engine/0.4/xml-rpc-client-engine-0.4.zip
 * a few complex : apply xml-rpc-engine.diff, execute sh script svn-cmd-toMoveXmlRpcClassFromWebappToService.sh to do svn move, and apply MoveXmlRpcClassFromWebappToService.patch to reallocate java class on good package

to test, Apply this patch, do ant, and restart ofbiz. Go to service list and execute testXmlRpcClientAdd service. 
I run ant run-test and all is ok 

> Add xml-rpc engine on serviceengine
> -----------------------------------
>
>                 Key: OFBIZ-3798
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3798
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Nicolas Malin
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: MoveXmlRpcClassFromWebappToService.patch, svn-cmd-toMoveXmlRpcClassFromWebappToService.sh, xml-rpc-engine.diff, xml-rpc.diff, XmlRpcEngine.patch
>
>
> I add a generic service to call xml-rpc server. The goal is to have a technical interface to make calls directly from mini-lang.
> The first patch it's my draft. I don't know where I do the service definition. I add a servicedef in framework/webapp, I move service on framework/common ? any suggest are welcom ;)
> Nicolas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-3798) Add generic service to call xml-rpc request

Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874617#action_12874617 ] 

Adrian Crum commented on OFBIZ-3798:
------------------------------------

I don't understand your comment - sorry.

Calling xml-rpc is no different than calling an OFBiz service, except the service is run on a remote server. So, why not set up a call-xml-rpc simple method that works just like call-service? The location attribute would contain the remote server's URL, The service-name attribute would contain the xml-rpc methodName, the in-map-name attribute specifies a Map of parameters to send to the remote service, etc. When the remote service call returns, the returned values are mapped to a result Map - just like an OFBiz service.

<call-xml-rpc location="http://someXmlRpcServer.com/path/to/xmlrpc" service-name="someService" in-map-name="xmlRpcServiceMap"/>

Doing it this way, there is no need for a generic service.


> Add generic service to call xml-rpc request
> -------------------------------------------
>
>                 Key: OFBIZ-3798
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3798
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Nicolas Malin
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: xml-rpc.diff
>
>
> I add a generic service to call xml-rpc server. The goal is to have a technical interface to make calls directly from mini-lang.
> The first patch it's my draft. I don't know where I do the service definition. I add a servicedef in framework/webapp, I move service on framework/common ? any suggest are welcom ;)
> Nicolas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OFBIZ-3798) Add xml-rpc engine on serviceengine

Posted by "Nicolas Malin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nicolas Malin updated OFBIZ-3798:
---------------------------------

    Attachment:     (was: svn-cmd-toMoveXmlRpcClassFromWebappToService.sh)

> Add xml-rpc engine on serviceengine
> -----------------------------------
>
>                 Key: OFBIZ-3798
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3798
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Nicolas Malin
>            Assignee: Erwan de FERRIERES
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: MoveXmlRpcClassFromWebappToService.patch, svn-cmd-toMoveXmlRpcClassFromWebappToService.sh, xmlrpc.patch
>
>
> I add a generic service to call xml-rpc server. The goal is to have a technical interface to make calls directly from mini-lang.
> The first patch it's my draft. I don't know where I do the service definition. I add a servicedef in framework/webapp, I move service on framework/common ? any suggest are welcom ;)
> Nicolas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-3798) Add xml-rpc engine on serviceengine

Posted by "Nicolas Malin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12877571#action_12877571 ] 

Nicolas Malin commented on OFBIZ-3798:
--------------------------------------

Hi Adrian, 

I understand your suggest but I think it's not a good solution. I explain ;)

XMLRPC Authentification or information for https connexion are a problem by engine/technology use. When a functionnal developper create a service, He should not worry about by technological environment, and if existant service are migrate, we don't change the service source code to add needs informations. For me when you migrate a service (java to xml-rpc) you just change service definition.

Currently, I have a project with three xml-rpc servers to contact, and it's possible these server change. If authentification information are set in attribute, when service move from xml-rpc to soap or json, I change in functionnal code the service call. Is why I search a solution to abstract technical information as authentification on xml-rpc server.  

This problem is the same than delegator where you can give information to database connexion or configuration by entityengine.xml but isn't not possible in serviceengine.xml to do that (maybe I miss it)
My second solution isn't good. I think it's the first solution who is the more usefull and evolutionary. Peraphs I amn't found the best solution to define it.

I will begin an addon with the first solution, I do a return it's good implementation ;)

Nicolas

> Add xml-rpc engine on serviceengine
> -----------------------------------
>
>                 Key: OFBIZ-3798
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3798
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Nicolas Malin
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: xml-rpc.diff, XmlRpcEngine.patch
>
>
> I add a generic service to call xml-rpc server. The goal is to have a technical interface to make calls directly from mini-lang.
> The first patch it's my draft. I don't know where I do the service definition. I add a servicedef in framework/webapp, I move service on framework/common ? any suggest are welcom ;)
> Nicolas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OFBIZ-3798) Add xml-rpc engine on serviceengine

Posted by "Nicolas Malin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nicolas Malin updated OFBIZ-3798:
---------------------------------

    Attachment:     (was: XmlRpcEngine.patch)

> Add xml-rpc engine on serviceengine
> -----------------------------------
>
>                 Key: OFBIZ-3798
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3798
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Nicolas Malin
>            Assignee: Erwan de FERRIERES
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: MoveXmlRpcClassFromWebappToService.patch, svn-cmd-toMoveXmlRpcClassFromWebappToService.sh, xmlrpc.patch
>
>
> I add a generic service to call xml-rpc server. The goal is to have a technical interface to make calls directly from mini-lang.
> The first patch it's my draft. I don't know where I do the service definition. I add a servicedef in framework/webapp, I move service on framework/common ? any suggest are welcom ;)
> Nicolas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-3798) Add generic service to call xml-rpc request

Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874831#action_12874831 ] 

Adrian Crum commented on OFBIZ-3798:
------------------------------------

That looks great!


> Add generic service to call xml-rpc request
> -------------------------------------------
>
>                 Key: OFBIZ-3798
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3798
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Nicolas Malin
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: xml-rpc.diff
>
>
> I add a generic service to call xml-rpc server. The goal is to have a technical interface to make calls directly from mini-lang.
> The first patch it's my draft. I don't know where I do the service definition. I add a servicedef in framework/webapp, I move service on framework/common ? any suggest are welcom ;)
> Nicolas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-3798) Add generic service to call xml-rpc request

Posted by "Nicolas Malin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12876670#action_12876670 ] 

Nicolas Malin commented on OFBIZ-3798:
--------------------------------------

Hi Scott,

I already analyse XmlRpcClient to understand how xml-rpc works in OFBiz. To support Https by service definition is in a second step, the first is how make the authentification :). My problem is where I store connexion information ? In service definition, properties by services or service group, in service attribute ? I have a preference for configuration associate to a service group that can do to define a global information for a service list that call the same extern server 

> Add generic service to call xml-rpc request
> -------------------------------------------
>
>                 Key: OFBIZ-3798
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3798
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Nicolas Malin
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: xml-rpc.diff, XmlRpcEngine.patch
>
>
> I add a generic service to call xml-rpc server. The goal is to have a technical interface to make calls directly from mini-lang.
> The first patch it's my draft. I don't know where I do the service definition. I add a servicedef in framework/webapp, I move service on framework/common ? any suggest are welcom ;)
> Nicolas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OFBIZ-3798) Add xml-rpc engine on serviceengine

Posted by "Nicolas Malin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nicolas Malin updated OFBIZ-3798:
---------------------------------

    Attachment: xmlRpcJar3.1.2.tar

I remove old path to avoid errors

> Add xml-rpc engine on serviceengine
> -----------------------------------
>
>                 Key: OFBIZ-3798
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3798
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Nicolas Malin
>            Assignee: Erwan de FERRIERES
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: MoveXmlRpcClassFromWebappToService.patch, svn-cmd-toMoveXmlRpcClassFromWebappToService.sh, xmlrpc.patch, xmlRpcJar3.1.2.tar
>
>
> I add a generic service to call xml-rpc server. The goal is to have a technical interface to make calls directly from mini-lang.
> The first patch it's my draft. I don't know where I do the service definition. I add a servicedef in framework/webapp, I move service on framework/common ? any suggest are welcom ;)
> Nicolas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-3798) Add xml-rpc engine on serviceengine

Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12883575#action_12883575 ] 

Adrian Crum commented on OFBIZ-3798:
------------------------------------

I just glanced through the latest patch and it looks okay to me. In XMLRPCClientEngine.java, the Debug info message should be changed to verbose, and there are some code formatting issues.


> Add xml-rpc engine on serviceengine
> -----------------------------------
>
>                 Key: OFBIZ-3798
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3798
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Nicolas Malin
>            Assignee: Erwan de FERRIERES
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: MoveXmlRpcClassFromWebappToService.patch, svn-cmd-toMoveXmlRpcClassFromWebappToService.sh, xml-rpc-client-engine.diff, xml-rpc-engine.diff, xml-rpc.diff, XmlRpcEngine.patch
>
>
> I add a generic service to call xml-rpc server. The goal is to have a technical interface to make calls directly from mini-lang.
> The first patch it's my draft. I don't know where I do the service definition. I add a servicedef in framework/webapp, I move service on framework/common ? any suggest are welcom ;)
> Nicolas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-3798) Add xml-rpc engine on serviceengine

Posted by "Erwan de FERRIERES (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12881652#action_12881652 ] 

Erwan de FERRIERES commented on OFBIZ-3798:
-------------------------------------------

Adam and Adrian,

since Nicolas has updated his patches, what do you think of the new code he wrote ?

Cheers,

> Add xml-rpc engine on serviceengine
> -----------------------------------
>
>                 Key: OFBIZ-3798
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3798
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Nicolas Malin
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: MoveXmlRpcClassFromWebappToService.patch, svn-cmd-toMoveXmlRpcClassFromWebappToService.sh, xml-rpc-engine.diff, xml-rpc.diff, XmlRpcEngine.patch
>
>
> I add a generic service to call xml-rpc server. The goal is to have a technical interface to make calls directly from mini-lang.
> The first patch it's my draft. I don't know where I do the service definition. I add a servicedef in framework/webapp, I move service on framework/common ? any suggest are welcom ;)
> Nicolas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OFBIZ-3798) Add xml-rpc engine on serviceengine

Posted by "Nicolas Malin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nicolas Malin updated OFBIZ-3798:
---------------------------------

    Summary: Add xml-rpc engine on serviceengine  (was: Add generic service to call xml-rpc request)

> Add xml-rpc engine on serviceengine
> -----------------------------------
>
>                 Key: OFBIZ-3798
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3798
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Nicolas Malin
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: xml-rpc.diff, XmlRpcEngine.patch
>
>
> I add a generic service to call xml-rpc server. The goal is to have a technical interface to make calls directly from mini-lang.
> The first patch it's my draft. I don't know where I do the service definition. I add a servicedef in framework/webapp, I move service on framework/common ? any suggest are welcom ;)
> Nicolas

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.