You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by witgo <gi...@git.apache.org> on 2014/12/18 04:36:37 UTC

[GitHub] spark pull request: [WIP][SPARK-4844][MLLIB]SGD should support cus...

GitHub user witgo opened a pull request:

    https://github.com/apache/spark/pull/3729

    [WIP][SPARK-4844][MLLIB]SGD should support custom sampling.

    JIRA: [SPARK-484](https://issues.apache.org/jira/browse/SPARK-4844)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/witgo/spark SPARK-4844

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/3729.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3729
    
----
commit 0282fcf458de4fe002969774fb599512c21a5e3d
Author: GuoQiang Li <wi...@qq.com>
Date:   2014-12-15T03:02:33Z

    SGD should support custom sampling.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [WIP][SPARK-4844][MLLIB]SGD should support cus...

Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the pull request:

    https://github.com/apache/spark/pull/3729#issuecomment-67601970
  
    Had an offline discussion with @witgo . The current implementation takes advantage of Parquet's serialization over Java's. However, this is too special for this particular algorithm. I asked @witgo to check the implementation of gap sampling and see how to apply it to min-batch sampling.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [WIP][SPARK-4844][MLLIB]SGD should support cus...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/3729#issuecomment-67437126
  
      [Test build #24569 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24569/consoleFull) for   PR 3729 at commit [`0282fcf`](https://github.com/apache/spark/commit/0282fcf458de4fe002969774fb599512c21a5e3d).
     * This patch merges cleanly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [WIP][SPARK-4844][MLLIB]SGD should support cus...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/3729#issuecomment-67441598
  
      [Test build #24569 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24569/consoleFull) for   PR 3729 at commit [`0282fcf`](https://github.com/apache/spark/commit/0282fcf458de4fe002969774fb599512c21a5e3d).
     * This patch **passes all tests**.
     * This patch merges cleanly.
     * This patch adds the following public classes _(experimental)_:
      * `trait Sampler `
      * `class SimpleSampler(var data: RDD[(Double, Vector)] = null,`
      * `class ExternalStorageSampler(val dataDir: String) extends Sampler `



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [WIP][SPARK-4844][MLLIB]SGD should support cus...

Posted by witgo <gi...@git.apache.org>.
Github user witgo closed the pull request at:

    https://github.com/apache/spark/pull/3729


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [WIP][SPARK-4844][MLLIB]SGD should support cus...

Posted by witgo <gi...@git.apache.org>.
Github user witgo commented on the pull request:

    https://github.com/apache/spark/pull/3729#issuecomment-67603907
  
    The PR is temporarily close.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [WIP][SPARK-4844][MLLIB]SGD should support cus...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/3729#issuecomment-67441600
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24569/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org