You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/01/30 19:27:11 UTC
[GitHub] [incubator-nuttx] acassis opened a new pull request #2781: Replace ARM_LWL_CONSOLE with generic LWL_CONSOLE
acassis opened a new pull request #2781:
URL: https://github.com/apache/incubator-nuttx/pull/2781
## Summary
Replace ARM_LWL_CONSOLE with generic LWL_CONSOLE
## Impact
Avoid duplication of LWL driver
## Testing
STM32F4Discovery
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2781: Replace ARM_LWL_CONSOLE with generic LWL_CONSOLE
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #2781:
URL: https://github.com/apache/incubator-nuttx/pull/2781
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2781: Replace ARM_LWL_CONSOLE with generic LWL_CONSOLE
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #2781:
URL: https://github.com/apache/incubator-nuttx/pull/2781#discussion_r567361586
##########
File path: boards/arm/stm32/stm32f4discovery/configs/lwl/defconfig
##########
@@ -17,7 +17,7 @@ CONFIG_ARCH_CHIP="stm32"
CONFIG_ARCH_CHIP_STM32=y
CONFIG_ARCH_CHIP_STM32F407VG=y
CONFIG_ARCH_STACKDUMP=y
-CONFIG_ARM_LWL_CONSOLE=y
+CONFIG_LWL_CONSOLE=y
Review comment:
need run tools/refresh.sh --silent
##########
File path: boards/arm/stm32/stm32ldiscovery/configs/chrono/defconfig
##########
@@ -20,7 +20,7 @@ CONFIG_ARCH_CHIP_STM32=y
CONFIG_ARCH_CHIP_STM32L152RB=y
CONFIG_ARCH_IRQBUTTONS=y
CONFIG_ARCH_STACKDUMP=y
-CONFIG_ARM_LWL_CONSOLE=y
+CONFIG_LWL_CONSOLE=y
Review comment:
need run tools/refresh.sh --silent
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on a change in pull request #2781: Replace ARM_LWL_CONSOLE with generic LWL_CONSOLE
Posted by GitBox <gi...@apache.org>.
acassis commented on a change in pull request #2781:
URL: https://github.com/apache/incubator-nuttx/pull/2781#discussion_r567417964
##########
File path: boards/arm/stm32/stm32ldiscovery/configs/chrono/defconfig
##########
@@ -20,7 +20,7 @@ CONFIG_ARCH_CHIP_STM32=y
CONFIG_ARCH_CHIP_STM32L152RB=y
CONFIG_ARCH_IRQBUTTONS=y
CONFIG_ARCH_STACKDUMP=y
-CONFIG_ARM_LWL_CONSOLE=y
+CONFIG_LWL_CONSOLE=y
Review comment:
Thank you @xiaoxiang781216 I just did it!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org