You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2016/11/28 21:23:28 UTC

[GitHub] brooklyn-server pull request #469: Remove net.java.dev.jna dependency exclus...

GitHub user aledsage opened a pull request:

    https://github.com/apache/brooklyn-server/pull/469

    Remove net.java.dev.jna dependency exclusion

    jclouds now correctly imports the dual-licensed version of jna, 
    so we can rely on that rather than excluding it ourselves.
    
    See https://github.com/jclouds/jclouds/commit/b3882cbfed873a5975d4918d1fb8b836b544c421. This is definitely in jclouds 1.9.2. (and 1.9.3 as well): see https://github.com/jclouds/jclouds/blob/rel/jclouds-1.9.2/drivers/sshj/pom.xml#L110.
    
    With this change, looking at `mvn dependency:tree -Dverbose` includes the output below, and shows that the only "jna" dependencies are version 4.1.0.
    
    ```
    [INFO] |     +- com.jcraft:jsch.agentproxy.usocket-jna:jar:0.0.8:compile
    [INFO] |     |  +- net.java.dev.jna:jna:jar:4.1.0:compile
    [INFO] |     |  \- net.java.dev.jna:jna-platform:jar:4.1.0:compile
    [INFO] |     |     \- (net.java.dev.jna:jna:jar:4.1.0:compile - omitted for duplicate)
    ```
    
    It also confirms that `jna` and `jna-platform` don't pull in any other transitive dependencies, so the upgrade from 4.0.0 to 4.1.0 shouldn't cause any problems (it just brings us in line with the versions that were actually tested in the jclouds releases!).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/brooklyn-server tidy-dependency-net.java.dev.jna

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/469.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #469
    
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #469: Remove net.java.dev.jna dependency exclus...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/brooklyn-server/pull/469


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #469: Remove net.java.dev.jna dependency exclusion

Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the issue:

    https://github.com/apache/brooklyn-server/pull/469
  
    Nice find, merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---