java 7 or 6 for trunk?

[Davide Giannella <da...@apache.org>]

Hello team,

while I was releasing 1.5.2 it complained about java 7 vs 6 and failed.

Before changing anything as there were discussions around it I want to
be double sure about this.

For trunk are we supporting java 7 onwards or are we still java 6?

Cheers
Davide

[INFO] [ERROR] Failed to execute goal
org.apache.maven.plugins:maven-javadoc-plugin:2.9:jar (attach-javadocs)
on project oak-upgrade: MavenReportException: Error while creating archive:
[INFO] [ERROR] Exit code: 1 - warning: [options] bootstrap class path
not set in conjunction with -source 1.6
[INFO] [ERROR]
/oak-upgrade/src/main/java/org/apache/jackrabbit/oak/upgrade/version/VersionablePropertiesEditor.java:142:
error: diamond operator is not supported in -source 1.6
[INFO] [ERROR] Set<String> updated = new HashSet<>();
[INFO] [ERROR] ^
[INFO] [ERROR] (use -source 7 or higher to enable diamond operator)

Re: java 7 or 6 for trunk?

[Davide Giannella <da...@apache.org>]

On 10/05/2016 15:28, Davide Giannella wrote:
> ...
> For trunk are we supporting java 7 onwards or are we still java 6?
>

https://issues.apache.org/jira/browse/OAK-4189

D.

Re: java 7 or 6 for trunk?

[Marcel Reutegger <mr...@adobe.com>]

On 10/05/16 16:28, "Davide Giannella" wrote:
>upgrade/src/main/java/org/apache/jackrabbit/oak/upgrade/version/Versionabl
>ePropertiesEditor.java:142:
>error: diamond operator is not supported in -source 1.6
>[INFO] [ERROR] Set<String> updated = new HashSet<>();
>[INFO] [ERROR] ^
>[INFO] [ERROR] (use -source 7 or higher to enable diamond operator)

hmm, I think this is a case where I personally would *not* use a Java 7
feature. as mentioned by others when the move to Java 7 was discussed,
it may make it more difficult to merge back changes to older branches.

In this case I would rather use Guava's factory methods Sets.newHashSet().

Regards
 Marcel