You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Vishal Suvagia via Review Board <no...@reviews.apache.org> on 2017/12/12 12:35:15 UTC
Review Request 64537: AMBARI-22635 : Ambari should create a dummy
core-site.xml for Ranger plugins when namenode is not installed.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64537/
-----------------------------------------------------------
Review request for Ambari, Gautam Borad, Jonathan Hurley, Jayush Luniya, Madhuvanthi Radhakrishnan, Mugdha Varadkar, and Velmurugan Periasamy.
Bugs: AMBARI-22635
https://issues.apache.org/jira/browse/AMBARI-22635
Repository: ambari
Description
-------
For Ranger plugins to work properly in kerberised environments where HDFS is not installed. We need to create a core-site.xml for Storm and Kafka plugins so that the plugins can work to fetch latest policies from with kerberised calls from Ranger.
Attached patch is for trunk branch, seperate patch for branch-2.6 is attached to Apache JIRA.
Diffs
-----
ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/package/scripts/setup_ranger_kafka.py e9719aa
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/setup_ranger_kafka.py 9aa09df
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/setup_ranger_storm.py c04496e
ambari-server/src/main/resources/common-services/STORM/1.0.1.3.0/package/scripts/setup_ranger_storm.py c04496e
Diff: https://reviews.apache.org/r/64537/diff/1/
Testing
-------
Verified with installation on Cent-OS 6.
Thanks,
Vishal Suvagia
Re: Review Request 64537: AMBARI-22635 : Ambari should create a dummy
core-site.xml for Ranger plugins when namenode is not installed.
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64537/#review193731
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On Dec. 13, 2017, 10:42 a.m., Vishal Suvagia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64537/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2017, 10:42 a.m.)
>
>
> Review request for Ambari, Gautam Borad, Jonathan Hurley, Jayush Luniya, Madhuvanthi Radhakrishnan, Mugdha Varadkar, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-22635
> https://issues.apache.org/jira/browse/AMBARI-22635
>
>
> Repository: ambari
>
>
> Description
> -------
>
> For Ranger plugins to work properly in kerberised environments where HDFS is not installed. We need to create a core-site.xml for Storm and Kafka plugins so that the plugins can work to fetch latest policies from with kerberised calls from Ranger.
> Attached patch is for trunk branch, seperate patch for branch-2.6 is attached to Apache JIRA.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py 485c1a6
> ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/package/scripts/setup_ranger_kafka.py e9719aa
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/setup_ranger_kafka.py 9aa09df
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py c486ef7
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.3.0/package/scripts/setup_ranger_knox.py c486ef7
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/setup_ranger_storm.py c04496e
> ambari-server/src/main/resources/common-services/STORM/1.0.1.3.0/package/scripts/setup_ranger_storm.py c04496e
>
>
> Diff: https://reviews.apache.org/r/64537/diff/2/
>
>
> Testing
> -------
>
> Verified with installation on Cent-OS 6.
>
>
> Thanks,
>
> Vishal Suvagia
>
>
Re: Review Request 64537: AMBARI-22635 : Ambari should create a dummy
core-site.xml for Ranger plugins when namenode is not installed.
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64537/#review193734
-----------------------------------------------------------
Ship it!
Ship It!
- Sid Wagle
On Dec. 13, 2017, 3:42 p.m., Vishal Suvagia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64537/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2017, 3:42 p.m.)
>
>
> Review request for Ambari, Gautam Borad, Jonathan Hurley, Jayush Luniya, Madhuvanthi Radhakrishnan, Mugdha Varadkar, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-22635
> https://issues.apache.org/jira/browse/AMBARI-22635
>
>
> Repository: ambari
>
>
> Description
> -------
>
> For Ranger plugins to work properly in kerberised environments where HDFS is not installed. We need to create a core-site.xml for Storm and Kafka plugins so that the plugins can work to fetch latest policies from with kerberised calls from Ranger.
> Attached patch is for trunk branch, seperate patch for branch-2.6 is attached to Apache JIRA.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py 485c1a6
> ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/package/scripts/setup_ranger_kafka.py e9719aa
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/setup_ranger_kafka.py 9aa09df
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py c486ef7
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.3.0/package/scripts/setup_ranger_knox.py c486ef7
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/setup_ranger_storm.py c04496e
> ambari-server/src/main/resources/common-services/STORM/1.0.1.3.0/package/scripts/setup_ranger_storm.py c04496e
>
>
> Diff: https://reviews.apache.org/r/64537/diff/2/
>
>
> Testing
> -------
>
> Verified with installation on Cent-OS 6.
>
>
> Thanks,
>
> Vishal Suvagia
>
>
Re: Review Request 64537: AMBARI-22635 : Ambari should create a dummy
core-site.xml for Ranger plugins when namenode is not installed.
Posted by Vishal Suvagia via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64537/
-----------------------------------------------------------
(Updated Dec. 13, 2017, 3:42 p.m.)
Review request for Ambari, Gautam Borad, Jonathan Hurley, Jayush Luniya, Madhuvanthi Radhakrishnan, Mugdha Varadkar, and Velmurugan Periasamy.
Changes
-------
Updating patch to address review comments.
Seperate patch for branch-2.6 is attached on Apache JIRA.
Bugs: AMBARI-22635
https://issues.apache.org/jira/browse/AMBARI-22635
Repository: ambari
Description
-------
For Ranger plugins to work properly in kerberised environments where HDFS is not installed. We need to create a core-site.xml for Storm and Kafka plugins so that the plugins can work to fetch latest policies from with kerberised calls from Ranger.
Attached patch is for trunk branch, seperate patch for branch-2.6 is attached to Apache JIRA.
Diffs (updated)
-----
ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py 485c1a6
ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/package/scripts/setup_ranger_kafka.py e9719aa
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/setup_ranger_kafka.py 9aa09df
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py c486ef7
ambari-server/src/main/resources/common-services/KNOX/0.5.0.3.0/package/scripts/setup_ranger_knox.py c486ef7
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/setup_ranger_storm.py c04496e
ambari-server/src/main/resources/common-services/STORM/1.0.1.3.0/package/scripts/setup_ranger_storm.py c04496e
Diff: https://reviews.apache.org/r/64537/diff/2/
Changes: https://reviews.apache.org/r/64537/diff/1-2/
Testing
-------
Verified with installation on Cent-OS 6.
Thanks,
Vishal Suvagia
Re: Review Request 64537: AMBARI-22635 : Ambari should create a dummy
core-site.xml for Ranger plugins when namenode is not installed.
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64537/#review193566
-----------------------------------------------------------
Seems like lots of code duplication, can you centralize this in a ranger function and just invoke it?
Also - shouldn't ranger just ship with a default core-site.xml in these cases? Seems kind of odd to have to create a dummy one...
- Jonathan Hurley
On Dec. 12, 2017, 7:35 a.m., Vishal Suvagia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64537/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2017, 7:35 a.m.)
>
>
> Review request for Ambari, Gautam Borad, Jonathan Hurley, Jayush Luniya, Madhuvanthi Radhakrishnan, Mugdha Varadkar, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-22635
> https://issues.apache.org/jira/browse/AMBARI-22635
>
>
> Repository: ambari
>
>
> Description
> -------
>
> For Ranger plugins to work properly in kerberised environments where HDFS is not installed. We need to create a core-site.xml for Storm and Kafka plugins so that the plugins can work to fetch latest policies from with kerberised calls from Ranger.
> Attached patch is for trunk branch, seperate patch for branch-2.6 is attached to Apache JIRA.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/package/scripts/setup_ranger_kafka.py e9719aa
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/setup_ranger_kafka.py 9aa09df
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/setup_ranger_storm.py c04496e
> ambari-server/src/main/resources/common-services/STORM/1.0.1.3.0/package/scripts/setup_ranger_storm.py c04496e
>
>
> Diff: https://reviews.apache.org/r/64537/diff/1/
>
>
> Testing
> -------
>
> Verified with installation on Cent-OS 6.
>
>
> Thanks,
>
> Vishal Suvagia
>
>
Re: Review Request 64537: AMBARI-22635 : Ambari should create a dummy
core-site.xml for Ranger plugins when namenode is not installed.
Posted by Vishal Suvagia via Review Board <no...@reviews.apache.org>.
> On Dec. 12, 2017, 4:36 p.m., Sid Wagle wrote:
> > Instead of putting empty files on the classpath isn't it easier to check for file existence on plugin side and defaul to "simple" auth?
>
> Sid Wagle wrote:
> Correction not empty I meant dummy file.
Thank-you Siddharth, that is the current behaviour for Ranger plugins, which will default to simple auth if the file is not found, however once the cluster will be kerberized the plugin should make kerberized calls to Ranger for which plugin will require core-site.xml to set security as kerberos.
- Vishal
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64537/#review193559
-----------------------------------------------------------
On Dec. 13, 2017, 3:42 p.m., Vishal Suvagia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64537/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2017, 3:42 p.m.)
>
>
> Review request for Ambari, Gautam Borad, Jonathan Hurley, Jayush Luniya, Madhuvanthi Radhakrishnan, Mugdha Varadkar, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-22635
> https://issues.apache.org/jira/browse/AMBARI-22635
>
>
> Repository: ambari
>
>
> Description
> -------
>
> For Ranger plugins to work properly in kerberised environments where HDFS is not installed. We need to create a core-site.xml for Storm and Kafka plugins so that the plugins can work to fetch latest policies from with kerberised calls from Ranger.
> Attached patch is for trunk branch, seperate patch for branch-2.6 is attached to Apache JIRA.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py 485c1a6
> ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/package/scripts/setup_ranger_kafka.py e9719aa
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/setup_ranger_kafka.py 9aa09df
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py c486ef7
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.3.0/package/scripts/setup_ranger_knox.py c486ef7
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/setup_ranger_storm.py c04496e
> ambari-server/src/main/resources/common-services/STORM/1.0.1.3.0/package/scripts/setup_ranger_storm.py c04496e
>
>
> Diff: https://reviews.apache.org/r/64537/diff/2/
>
>
> Testing
> -------
>
> Verified with installation on Cent-OS 6.
>
>
> Thanks,
>
> Vishal Suvagia
>
>
Re: Review Request 64537: AMBARI-22635 : Ambari should create a dummy
core-site.xml for Ranger plugins when namenode is not installed.
Posted by Sid Wagle <sw...@hortonworks.com>.
> On Dec. 12, 2017, 4:36 p.m., Sid Wagle wrote:
> > Instead of putting empty files on the classpath isn't it easier to check for file existence on plugin side and defaul to "simple" auth?
Correction not empty I meant dummy file.
- Sid
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64537/#review193559
-----------------------------------------------------------
On Dec. 12, 2017, 12:35 p.m., Vishal Suvagia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64537/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2017, 12:35 p.m.)
>
>
> Review request for Ambari, Gautam Borad, Jonathan Hurley, Jayush Luniya, Madhuvanthi Radhakrishnan, Mugdha Varadkar, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-22635
> https://issues.apache.org/jira/browse/AMBARI-22635
>
>
> Repository: ambari
>
>
> Description
> -------
>
> For Ranger plugins to work properly in kerberised environments where HDFS is not installed. We need to create a core-site.xml for Storm and Kafka plugins so that the plugins can work to fetch latest policies from with kerberised calls from Ranger.
> Attached patch is for trunk branch, seperate patch for branch-2.6 is attached to Apache JIRA.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/package/scripts/setup_ranger_kafka.py e9719aa
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/setup_ranger_kafka.py 9aa09df
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/setup_ranger_storm.py c04496e
> ambari-server/src/main/resources/common-services/STORM/1.0.1.3.0/package/scripts/setup_ranger_storm.py c04496e
>
>
> Diff: https://reviews.apache.org/r/64537/diff/1/
>
>
> Testing
> -------
>
> Verified with installation on Cent-OS 6.
>
>
> Thanks,
>
> Vishal Suvagia
>
>
Re: Review Request 64537: AMBARI-22635 : Ambari should create a dummy
core-site.xml for Ranger plugins when namenode is not installed.
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64537/#review193559
-----------------------------------------------------------
Instead of putting empty files on the classpath isn't it easier to check for file existence on plugin side and defaul to "simple" auth?
- Sid Wagle
On Dec. 12, 2017, 12:35 p.m., Vishal Suvagia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64537/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2017, 12:35 p.m.)
>
>
> Review request for Ambari, Gautam Borad, Jonathan Hurley, Jayush Luniya, Madhuvanthi Radhakrishnan, Mugdha Varadkar, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-22635
> https://issues.apache.org/jira/browse/AMBARI-22635
>
>
> Repository: ambari
>
>
> Description
> -------
>
> For Ranger plugins to work properly in kerberised environments where HDFS is not installed. We need to create a core-site.xml for Storm and Kafka plugins so that the plugins can work to fetch latest policies from with kerberised calls from Ranger.
> Attached patch is for trunk branch, seperate patch for branch-2.6 is attached to Apache JIRA.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/package/scripts/setup_ranger_kafka.py e9719aa
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/setup_ranger_kafka.py 9aa09df
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/setup_ranger_storm.py c04496e
> ambari-server/src/main/resources/common-services/STORM/1.0.1.3.0/package/scripts/setup_ranger_storm.py c04496e
>
>
> Diff: https://reviews.apache.org/r/64537/diff/1/
>
>
> Testing
> -------
>
> Verified with installation on Cent-OS 6.
>
>
> Thanks,
>
> Vishal Suvagia
>
>