You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/29 16:50:21 UTC
[GitHub] [spark] MaxGekk opened a new pull request, #38436: [WIP][SQL] Migrate `failAnalysis()` onto error classes
MaxGekk opened a new pull request, #38436:
URL: https://github.com/apache/spark/pull/38436
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #38436: [SPARK-40967][SQL] Migrate `failAnalysis()` onto error classes
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on code in PR #38436:
URL: https://github.com/apache/spark/pull/38436#discussion_r1008893904
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -4339,5 +4339,170 @@
"message" : [
"Drop namespace restrict is not supported"
]
+ },
+ "_LEGACY_ERROR_TEMP_2300" : {
+ "message" : [
+ "The number of lambda function arguments '<namesSize>' does not match the number of arguments expected by the higher order function '<argInfoSize>'."
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2301" : {
+ "message" : [
+ "Lambda function arguments should not have names that are semantically the same."
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2302" : {
+ "message" : [
+ "'<name>' does not support more than one sources"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2303" : {
+ "message" : [
+ "incompatible types found in column <name> for inline table"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2304" : {
+ "message" : [
+ "cannot evaluate expression <sqlExpr> in inline table definition"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2305" : {
+ "message" : [
+ "expected <numCols> columns but found <rowSize> columns in row <ri>"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2306" : {
+ "message" : [
+ "A lambda function should only be used in a higher order function. However, its class is <class>, which is not a higher order function."
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2307" : {
+ "message" : [
+ "Number of given aliases does not match number of output columns. Function name: <funcName>; number of aliases: <aliasesNum>; number of output columns: <outColsNum>."
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2308" : {
+ "message" : [
+ "could not resolve `<name>` to a table-valued function"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2309" : {
+ "message" : [
+ "cannot resolve <sqlExpr> in MERGE command given columns [<cols>]"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2310" : {
+ "message" : [
+ "'writeStream' can be called only on streaming Dataset/DataFrame"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2311" : {
+ "message" : [
+ "'writeTo' can not be called on streaming Dataset/DataFrame"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2312" : {
+ "message" : [
+ "'write' can not be called on streaming Dataset/DataFrame"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2313" : {
+ "message" : [
+ "Hint not found: <name>"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2314" : {
+ "message" : [
+ "cannot resolve '<sqlExpr>' due to argument data type mismatch: <msg>"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2315" : {
+ "message" : [
+ "cannot resolve '<sqlExpr>' due to data type mismatch: <msg><hint>"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2316" : {
+ "message" : [
+ "observed metrics should be named: <operator>"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2317" : {
+ "message" : [
+ "window expressions are not allowed in observed metrics, but found: <sqlExpr>"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2318" : {
Review Comment:
Will merge later.
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -4339,5 +4339,170 @@
"message" : [
"Drop namespace restrict is not supported"
]
+ },
+ "_LEGACY_ERROR_TEMP_2300" : {
+ "message" : [
+ "The number of lambda function arguments '<namesSize>' does not match the number of arguments expected by the higher order function '<argInfoSize>'."
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2301" : {
+ "message" : [
+ "Lambda function arguments should not have names that are semantically the same."
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2302" : {
+ "message" : [
+ "'<name>' does not support more than one sources"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2303" : {
+ "message" : [
+ "incompatible types found in column <name> for inline table"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2304" : {
+ "message" : [
+ "cannot evaluate expression <sqlExpr> in inline table definition"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2305" : {
+ "message" : [
+ "expected <numCols> columns but found <rowSize> columns in row <ri>"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2306" : {
+ "message" : [
+ "A lambda function should only be used in a higher order function. However, its class is <class>, which is not a higher order function."
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2307" : {
+ "message" : [
+ "Number of given aliases does not match number of output columns. Function name: <funcName>; number of aliases: <aliasesNum>; number of output columns: <outColsNum>."
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2308" : {
+ "message" : [
+ "could not resolve `<name>` to a table-valued function"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2309" : {
+ "message" : [
+ "cannot resolve <sqlExpr> in MERGE command given columns [<cols>]"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2310" : {
Review Comment:
Yep, later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #38436: [SPARK-40967][SQL] Migrate `failAnalysis()` onto error classes
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on code in PR #38436:
URL: https://github.com/apache/spark/pull/38436#discussion_r1008829090
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -4339,5 +4339,170 @@
"message" : [
"Drop namespace restrict is not supported"
]
+ },
+ "_LEGACY_ERROR_TEMP_2300" : {
+ "message" : [
+ "The number of lambda function arguments '<namesSize>' does not match the number of arguments expected by the higher order function '<argInfoSize>'."
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2301" : {
+ "message" : [
+ "Lambda function arguments should not have names that are semantically the same."
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2302" : {
+ "message" : [
+ "'<name>' does not support more than one sources"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2303" : {
+ "message" : [
+ "incompatible types found in column <name> for inline table"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2304" : {
+ "message" : [
+ "cannot evaluate expression <sqlExpr> in inline table definition"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2305" : {
+ "message" : [
+ "expected <numCols> columns but found <rowSize> columns in row <ri>"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2306" : {
+ "message" : [
+ "A lambda function should only be used in a higher order function. However, its class is <class>, which is not a higher order function."
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2307" : {
+ "message" : [
+ "Number of given aliases does not match number of output columns. Function name: <funcName>; number of aliases: <aliasesNum>; number of output columns: <outColsNum>."
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2308" : {
+ "message" : [
+ "could not resolve `<name>` to a table-valued function"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2309" : {
+ "message" : [
+ "cannot resolve <sqlExpr> in MERGE command given columns [<cols>]"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2310" : {
+ "message" : [
+ "'writeStream' can be called only on streaming Dataset/DataFrame"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2311" : {
+ "message" : [
+ "'writeTo' can not be called on streaming Dataset/DataFrame"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2312" : {
+ "message" : [
+ "'write' can not be called on streaming Dataset/DataFrame"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2313" : {
+ "message" : [
+ "Hint not found: <name>"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2314" : {
+ "message" : [
+ "cannot resolve '<sqlExpr>' due to argument data type mismatch: <msg>"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2315" : {
+ "message" : [
+ "cannot resolve '<sqlExpr>' due to data type mismatch: <msg><hint>"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2316" : {
+ "message" : [
+ "observed metrics should be named: <operator>"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2317" : {
+ "message" : [
+ "window expressions are not allowed in observed metrics, but found: <sqlExpr>"
Review Comment:
After reading the pr description, I think the answer is clear
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #38436: [SPARK-40967][SQL] Migrate `failAnalysis()` onto error classes
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on code in PR #38436:
URL: https://github.com/apache/spark/pull/38436#discussion_r1008893856
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -4339,5 +4339,170 @@
"message" : [
"Drop namespace restrict is not supported"
]
+ },
+ "_LEGACY_ERROR_TEMP_2300" : {
+ "message" : [
+ "The number of lambda function arguments '<namesSize>' does not match the number of arguments expected by the higher order function '<argInfoSize>'."
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2301" : {
+ "message" : [
+ "Lambda function arguments should not have names that are semantically the same."
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2302" : {
+ "message" : [
+ "'<name>' does not support more than one sources"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2303" : {
+ "message" : [
+ "incompatible types found in column <name> for inline table"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2304" : {
+ "message" : [
+ "cannot evaluate expression <sqlExpr> in inline table definition"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2305" : {
+ "message" : [
+ "expected <numCols> columns but found <rowSize> columns in row <ri>"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2306" : {
+ "message" : [
+ "A lambda function should only be used in a higher order function. However, its class is <class>, which is not a higher order function."
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2307" : {
+ "message" : [
+ "Number of given aliases does not match number of output columns. Function name: <funcName>; number of aliases: <aliasesNum>; number of output columns: <outColsNum>."
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2308" : {
+ "message" : [
+ "could not resolve `<name>` to a table-valued function"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2309" : {
+ "message" : [
+ "cannot resolve <sqlExpr> in MERGE command given columns [<cols>]"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2310" : {
+ "message" : [
+ "'writeStream' can be called only on streaming Dataset/DataFrame"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2311" : {
+ "message" : [
+ "'writeTo' can not be called on streaming Dataset/DataFrame"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2312" : {
+ "message" : [
+ "'write' can not be called on streaming Dataset/DataFrame"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2313" : {
+ "message" : [
+ "Hint not found: <name>"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2314" : {
+ "message" : [
+ "cannot resolve '<sqlExpr>' due to argument data type mismatch: <msg>"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2315" : {
+ "message" : [
+ "cannot resolve '<sqlExpr>' due to data type mismatch: <msg><hint>"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2316" : {
+ "message" : [
+ "observed metrics should be named: <operator>"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2317" : {
+ "message" : [
+ "window expressions are not allowed in observed metrics, but found: <sqlExpr>"
Review Comment:
The main goal of this PR is to assign unique names to errors. That should allow to prioritise errors, and improve most widely used in nature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #38436: [SPARK-40967][SQL] Migrate `failAnalysis()` onto error classes
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on code in PR #38436:
URL: https://github.com/apache/spark/pull/38436#discussion_r1008825685
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala:
##########
@@ -196,7 +198,8 @@ trait CheckAnalysis extends PredicateHelper with LookupCatalog {
hof.dataTypeMismatch(hof, checkRes)
case TypeCheckResult.TypeCheckFailure(message) =>
Review Comment:
Will it still match `TypeCheckResult.TypeCheckFailure(message)`?
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -4339,5 +4339,170 @@
"message" : [
"Drop namespace restrict is not supported"
]
+ },
+ "_LEGACY_ERROR_TEMP_2300" : {
+ "message" : [
+ "The number of lambda function arguments '<namesSize>' does not match the number of arguments expected by the higher order function '<argInfoSize>'."
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2301" : {
+ "message" : [
+ "Lambda function arguments should not have names that are semantically the same."
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2302" : {
+ "message" : [
+ "'<name>' does not support more than one sources"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2303" : {
+ "message" : [
+ "incompatible types found in column <name> for inline table"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2304" : {
+ "message" : [
+ "cannot evaluate expression <sqlExpr> in inline table definition"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2305" : {
+ "message" : [
+ "expected <numCols> columns but found <rowSize> columns in row <ri>"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2306" : {
+ "message" : [
+ "A lambda function should only be used in a higher order function. However, its class is <class>, which is not a higher order function."
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2307" : {
+ "message" : [
+ "Number of given aliases does not match number of output columns. Function name: <funcName>; number of aliases: <aliasesNum>; number of output columns: <outColsNum>."
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2308" : {
+ "message" : [
+ "could not resolve `<name>` to a table-valued function"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2309" : {
+ "message" : [
+ "cannot resolve <sqlExpr> in MERGE command given columns [<cols>]"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2310" : {
+ "message" : [
+ "'writeStream' can be called only on streaming Dataset/DataFrame"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2311" : {
+ "message" : [
+ "'writeTo' can not be called on streaming Dataset/DataFrame"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2312" : {
+ "message" : [
+ "'write' can not be called on streaming Dataset/DataFrame"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2313" : {
+ "message" : [
+ "Hint not found: <name>"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2314" : {
+ "message" : [
+ "cannot resolve '<sqlExpr>' due to argument data type mismatch: <msg>"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2315" : {
+ "message" : [
+ "cannot resolve '<sqlExpr>' due to data type mismatch: <msg><hint>"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2316" : {
+ "message" : [
+ "observed metrics should be named: <operator>"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2317" : {
+ "message" : [
+ "window expressions are not allowed in observed metrics, but found: <sqlExpr>"
Review Comment:
The following templates are similar. Will they be merged together in the future?
- _LEGACY_ERROR_TEMP_2317
- _LEGACY_ERROR_TEMP_2319
- _LEGACY_ERROR_TEMP_2320
- _LEGACY_ERROR_TEMP_2321
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -4339,5 +4339,170 @@
"message" : [
"Drop namespace restrict is not supported"
]
+ },
+ "_LEGACY_ERROR_TEMP_2300" : {
+ "message" : [
+ "The number of lambda function arguments '<namesSize>' does not match the number of arguments expected by the higher order function '<argInfoSize>'."
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2301" : {
+ "message" : [
+ "Lambda function arguments should not have names that are semantically the same."
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2302" : {
+ "message" : [
+ "'<name>' does not support more than one sources"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2303" : {
+ "message" : [
+ "incompatible types found in column <name> for inline table"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2304" : {
+ "message" : [
+ "cannot evaluate expression <sqlExpr> in inline table definition"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2305" : {
+ "message" : [
+ "expected <numCols> columns but found <rowSize> columns in row <ri>"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2306" : {
+ "message" : [
+ "A lambda function should only be used in a higher order function. However, its class is <class>, which is not a higher order function."
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2307" : {
+ "message" : [
+ "Number of given aliases does not match number of output columns. Function name: <funcName>; number of aliases: <aliasesNum>; number of output columns: <outColsNum>."
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2308" : {
+ "message" : [
+ "could not resolve `<name>` to a table-valued function"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2309" : {
+ "message" : [
+ "cannot resolve <sqlExpr> in MERGE command given columns [<cols>]"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2310" : {
Review Comment:
Will _LEGACY_ERROR_TEMP_2310, _LEGACY_ERROR_TEMP_2311, _LEGACY_ERROR_TEMP_2312 be merged to one?
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -4339,5 +4339,170 @@
"message" : [
"Drop namespace restrict is not supported"
]
+ },
+ "_LEGACY_ERROR_TEMP_2300" : {
+ "message" : [
+ "The number of lambda function arguments '<namesSize>' does not match the number of arguments expected by the higher order function '<argInfoSize>'."
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2301" : {
+ "message" : [
+ "Lambda function arguments should not have names that are semantically the same."
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2302" : {
+ "message" : [
+ "'<name>' does not support more than one sources"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2303" : {
+ "message" : [
+ "incompatible types found in column <name> for inline table"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2304" : {
+ "message" : [
+ "cannot evaluate expression <sqlExpr> in inline table definition"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2305" : {
+ "message" : [
+ "expected <numCols> columns but found <rowSize> columns in row <ri>"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2306" : {
+ "message" : [
+ "A lambda function should only be used in a higher order function. However, its class is <class>, which is not a higher order function."
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2307" : {
+ "message" : [
+ "Number of given aliases does not match number of output columns. Function name: <funcName>; number of aliases: <aliasesNum>; number of output columns: <outColsNum>."
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2308" : {
+ "message" : [
+ "could not resolve `<name>` to a table-valued function"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2309" : {
+ "message" : [
+ "cannot resolve <sqlExpr> in MERGE command given columns [<cols>]"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2310" : {
+ "message" : [
+ "'writeStream' can be called only on streaming Dataset/DataFrame"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2311" : {
+ "message" : [
+ "'writeTo' can not be called on streaming Dataset/DataFrame"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2312" : {
+ "message" : [
+ "'write' can not be called on streaming Dataset/DataFrame"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2313" : {
+ "message" : [
+ "Hint not found: <name>"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2314" : {
+ "message" : [
+ "cannot resolve '<sqlExpr>' due to argument data type mismatch: <msg>"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2315" : {
+ "message" : [
+ "cannot resolve '<sqlExpr>' due to data type mismatch: <msg><hint>"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2316" : {
+ "message" : [
+ "observed metrics should be named: <operator>"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2317" : {
+ "message" : [
+ "window expressions are not allowed in observed metrics, but found: <sqlExpr>"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2318" : {
Review Comment:
`_LEGACY_ERROR_TEMP_2318` and `_LEGACY_ERROR_TEMP_2322` are similar, will they merge together in the future?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #38436: [SPARK-40967][SQL] Migrate `failAnalysis()` onto error classes
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on code in PR #38436:
URL: https://github.com/apache/spark/pull/38436#discussion_r1008914087
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala:
##########
@@ -196,7 +198,8 @@ trait CheckAnalysis extends PredicateHelper with LookupCatalog {
hof.dataTypeMismatch(hof, checkRes)
case TypeCheckResult.TypeCheckFailure(message) =>
Review Comment:
When we finish all tasks of converting the type check failures to error classes, we will remove `TypeCheckResult.TypeCheckFailure()`, and as a consequence of that, we can remove all match cases, and unneeded error classes like this.
So far, there are open tasks, I wouldn't do that:
- https://issues.apache.org/jira/browse/SPARK-40371
- https://issues.apache.org/jira/browse/SPARK-40372
- https://issues.apache.org/jira/browse/SPARK-40374
- https://issues.apache.org/jira/browse/SPARK-40748
- https://issues.apache.org/jira/browse/SPARK-40749
- https://issues.apache.org/jira/browse/SPARK-40769
since there is a risk to miss something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #38436: [SPARK-40967][SQL] Migrate `failAnalysis()` onto error classes
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #38436: [SPARK-40967][SQL] Migrate `failAnalysis()` onto error classes
URL: https://github.com/apache/spark/pull/38436
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #38436: [SPARK-40967][SQL] Migrate `failAnalysis()` onto error classes
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #38436:
URL: https://github.com/apache/spark/pull/38436#issuecomment-1296187749
@srielau @cloud-fan @itholic @panbingkun @LuciferYang Please, review this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #38436: [SPARK-40967][SQL] Migrate `failAnalysis()` onto error classes
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #38436:
URL: https://github.com/apache/spark/pull/38436#issuecomment-1296583781
Merging to master. Thank you, @LuciferYang @panbingkun @itholic @cloud-fan for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org