You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2016/12/22 21:34:46 UTC
[kudu-CR] KUDU-1812. Redact calls to Slice::ToDebugString
Hello Adar Dembo, Todd Lipcon, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5568
to review the following change.
Change subject: KUDU-1812. Redact calls to Slice::ToDebugString
......................................................................
KUDU-1812. Redact calls to Slice::ToDebugString
The Slice::ToDebugString method is used pervasively to log errors in the
case of malformed inputs, which almost always can contain sensitive user
data. Unfortunately Slice::ToDebugString is part of our public client
API, so the redaction can not be done centrally in ToDebugString itself.
Change-Id: I4d1ebde79dea5cae89956b70d13f67fbc6972034
---
M src/kudu/cfile/binary_prefix_block.cc
M src/kudu/cfile/block_compression.cc
M src/kudu/cfile/bloomfile.cc
M src/kudu/cfile/cfile_reader.cc
M src/kudu/cfile/cfile_writer.cc
M src/kudu/cfile/compression_codec.cc
M src/kudu/common/encoded_key.cc
M src/kudu/common/key_encoder.h
M src/kudu/common/row_changelist.cc
M src/kudu/consensus/log_util.cc
M src/kudu/rpc/serialization.cc
M src/kudu/rpc/transfer.cc
M src/kudu/tablet/cfile_set.cc
M src/kudu/tablet/concurrent_btree.h
M src/kudu/tablet/delta_key.h
M src/kudu/tablet/diskrowset.cc
M src/kudu/tablet/lock_manager.cc
M src/kudu/tablet/rowset_info.cc
M src/kudu/util/slice.cc
19 files changed, 94 insertions(+), 71 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/5568/1
--
To view, visit http://gerrit.cloudera.org:8080/5568
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4d1ebde79dea5cae89956b70d13f67fbc6972034
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-1812. Redact calls to Slice::ToDebugString
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: KUDU-1812. Redact calls to Slice::ToDebugString
......................................................................
Patch Set 3:
(3 comments)
> I could have sworn I saw one of Dan's patches that dealt with this using KUDU_SHOULD_REDACT().
It's done in this patch.
> What about std::ostream& operator<<(std::ostream& o, const Slice& s) in slice.h, line 281?
We had one caller, I fixed it up to redact and us ToDebugString explicitly.
http://gerrit.cloudera.org:8080/#/c/5568/3//COMMIT_MSG
Commit Message:
> Is it worth adding a unit test to would verify that the data returned by Sl
I think we have coverage of this.
http://gerrit.cloudera.org:8080/#/c/5568/1/src/kudu/common/encoded_key.cc
File src/kudu/common/encoded_key.cc:
Line 188: }
> warning: don't use else after return [readability-else-after-return]
Done
http://gerrit.cloudera.org:8080/#/c/5568/1/src/kudu/common/key_encoder.h
File src/kudu/common/key_encoder.h:
Line 97: Arena* /*arena*/,
> warning: parameter 'arena' is unused [misc-unused-parameters]
Done
--
To view, visit http://gerrit.cloudera.org:8080/5568
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d1ebde79dea5cae89956b70d13f67fbc6972034
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1812. Redact calls to Slice::ToDebugString
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: KUDU-1812. Redact calls to Slice::ToDebugString
......................................................................
Patch Set 3: Code-Review+2
I looked at StringPiece's ToString() and as_string() methods. Didn't see anything worth redacting there. I also looked at calls to TRACE() and TRACE_TO(). Same results.
Dan is also looking at Slice::ToString(); there are a few calls there that deserve redaction. But as far as ToDebugString() is concerned, this patch looks good to me.
--
To view, visit http://gerrit.cloudera.org:8080/5568
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d1ebde79dea5cae89956b70d13f67fbc6972034
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] KUDU-1812. Redact calls to Slice::ToDebugString
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: KUDU-1812. Redact calls to Slice::ToDebugString
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5568
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d1ebde79dea5cae89956b70d13f67fbc6972034
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] KUDU-1812. Redact calls to Slice::ToDebugString
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5568
to look at the new patch set (#5).
Change subject: KUDU-1812. Redact calls to Slice::ToDebugString
......................................................................
KUDU-1812. Redact calls to Slice::ToDebugString
The Slice::ToDebugString method is used pervasively to log errors in the
case of malformed inputs, which almost always can contain sensitive user
data. Unfortunately Slice::ToDebugString is part of our public client
API, so the redaction can not be done centrally in ToDebugString itself.
Change-Id: I4d1ebde79dea5cae89956b70d13f67fbc6972034
---
M src/kudu/cfile/binary_prefix_block.cc
M src/kudu/cfile/block_compression.cc
M src/kudu/cfile/bloomfile.cc
M src/kudu/cfile/cfile_reader.cc
M src/kudu/cfile/cfile_writer.cc
M src/kudu/cfile/compression_codec.cc
M src/kudu/common/encoded_key.cc
M src/kudu/common/key_encoder.h
M src/kudu/common/partition-test.cc
M src/kudu/common/partition.cc
M src/kudu/common/row_changelist.cc
M src/kudu/consensus/log_util.cc
M src/kudu/rpc/serialization.cc
M src/kudu/rpc/transfer.cc
M src/kudu/tablet/cfile_set.cc
M src/kudu/tablet/concurrent_btree.h
M src/kudu/tablet/delta_key.h
M src/kudu/tablet/diskrowset.cc
M src/kudu/tablet/lock_manager.cc
M src/kudu/tablet/rowset_info.cc
M src/kudu/util/slice.cc
21 files changed, 118 insertions(+), 80 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/5568/5
--
To view, visit http://gerrit.cloudera.org:8080/5568
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4d1ebde79dea5cae89956b70d13f67fbc6972034
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-1812. Redact calls to Slice::ToDebugString
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.
Change subject: KUDU-1812. Redact calls to Slice::ToDebugString
......................................................................
KUDU-1812. Redact calls to Slice::ToDebugString
The Slice::ToDebugString method is used pervasively to log errors in the
case of malformed inputs, which almost always can contain sensitive user
data. Unfortunately Slice::ToDebugString is part of our public client
API, so the redaction can not be done centrally in ToDebugString itself.
Change-Id: I4d1ebde79dea5cae89956b70d13f67fbc6972034
Reviewed-on: http://gerrit.cloudera.org:8080/5568
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/cfile/binary_prefix_block.cc
M src/kudu/cfile/block_compression.cc
M src/kudu/cfile/bloomfile.cc
M src/kudu/cfile/cfile_reader.cc
M src/kudu/cfile/cfile_writer.cc
M src/kudu/cfile/compression_codec.cc
M src/kudu/common/encoded_key.cc
M src/kudu/common/key_encoder.h
M src/kudu/common/partition-test.cc
M src/kudu/common/partition.cc
M src/kudu/common/row_changelist.cc
M src/kudu/consensus/log_util.cc
M src/kudu/rpc/serialization.cc
M src/kudu/rpc/transfer.cc
M src/kudu/tablet/cfile_set.cc
M src/kudu/tablet/concurrent_btree.h
M src/kudu/tablet/delta_key.h
M src/kudu/tablet/diskrowset.cc
M src/kudu/tablet/lock_manager.cc
M src/kudu/tablet/rowset_info.cc
M src/kudu/util/slice.cc
21 files changed, 118 insertions(+), 80 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5568
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4d1ebde79dea5cae89956b70d13f67fbc6972034
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-1812. Redact calls to Slice::ToDebugString
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5568
to look at the new patch set (#3).
Change subject: KUDU-1812. Redact calls to Slice::ToDebugString
......................................................................
KUDU-1812. Redact calls to Slice::ToDebugString
The Slice::ToDebugString method is used pervasively to log errors in the
case of malformed inputs, which almost always can contain sensitive user
data. Unfortunately Slice::ToDebugString is part of our public client
API, so the redaction can not be done centrally in ToDebugString itself.
Change-Id: I4d1ebde79dea5cae89956b70d13f67fbc6972034
---
M src/kudu/cfile/binary_prefix_block.cc
M src/kudu/cfile/block_compression.cc
M src/kudu/cfile/bloomfile.cc
M src/kudu/cfile/cfile_reader.cc
M src/kudu/cfile/cfile_writer.cc
M src/kudu/cfile/compression_codec.cc
M src/kudu/common/encoded_key.cc
M src/kudu/common/key_encoder.h
M src/kudu/common/partition-test.cc
M src/kudu/common/partition.cc
M src/kudu/common/row_changelist.cc
M src/kudu/consensus/log_util.cc
M src/kudu/rpc/serialization.cc
M src/kudu/rpc/transfer.cc
M src/kudu/tablet/cfile_set.cc
M src/kudu/tablet/concurrent_btree.h
M src/kudu/tablet/delta_key.h
M src/kudu/tablet/diskrowset.cc
M src/kudu/tablet/lock_manager.cc
M src/kudu/tablet/rowset_info.cc
M src/kudu/util/slice.cc
21 files changed, 117 insertions(+), 79 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/5568/3
--
To view, visit http://gerrit.cloudera.org:8080/5568
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4d1ebde79dea5cae89956b70d13f67fbc6972034
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-1812. Redact calls to Slice::ToDebugString
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: KUDU-1812. Redact calls to Slice::ToDebugString
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5568
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d1ebde79dea5cae89956b70d13f67fbc6972034
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] KUDU-1812. Redact calls to Slice::ToDebugString
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: KUDU-1812. Redact calls to Slice::ToDebugString
......................................................................
Patch Set 3:
> > What about std::ostream& operator<<(std::ostream& o, const Slice&
> > s) in slice.h, line 281?
This is legit. Since it's part of the client API, we should hunt down the references and update them. Eclipse says there's only one: the big LOG(FATAL) statement in RowSetInfo::CollectOrdered().
> Also, what is the plan to deal with
>
> string OutboundTransfer::HexDump() in transfer.cc, line 242?
> Should usage of Slice::ToDebugString() be redacted in that call
> site or there is a plan to deal with OutboundTransfer::HexDump()
> at the higher levels?
I could have sworn I saw one of Dan's patches that dealt with this using KUDU_SHOULD_REDACT().
--
To view, visit http://gerrit.cloudera.org:8080/5568
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d1ebde79dea5cae89956b70d13f67fbc6972034
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] KUDU-1812. Redact calls to Slice::ToDebugString
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: KUDU-1812. Redact calls to Slice::ToDebugString
......................................................................
Patch Set 3:
What about std::ostream& operator<<(std::ostream& o, const Slice& s) in slice.h, line 281?
--
To view, visit http://gerrit.cloudera.org:8080/5568
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d1ebde79dea5cae89956b70d13f67fbc6972034
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] KUDU-1812. Redact calls to Slice::ToDebugString
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: KUDU-1812. Redact calls to Slice::ToDebugString
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5568/3//COMMIT_MSG
Commit Message:
Is it worth adding a unit test to would verify that the data returned by Slice::ToDebugString() is not redacted even if the log_redact_user_data set to 'true'?
Or it has enough indirect coverage by other tests already?
--
To view, visit http://gerrit.cloudera.org:8080/5568
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d1ebde79dea5cae89956b70d13f67fbc6972034
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1812. Redact calls to Slice::ToDebugString
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: KUDU-1812. Redact calls to Slice::ToDebugString
......................................................................
Patch Set 3:
> What about std::ostream& operator<<(std::ostream& o, const Slice&
> s) in slice.h, line 281?
Also, what is the plan to deal with
string OutboundTransfer::HexDump() in transfer.cc, line 242? Should usage of Slice::ToDebugString() be redacted in that call site or there is a plan to deal with OutboundTransfer::HexDump() at the higher levels?
--
To view, visit http://gerrit.cloudera.org:8080/5568
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d1ebde79dea5cae89956b70d13f67fbc6972034
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] KUDU-1812. Redact calls to Slice::ToDebugString
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5568
to look at the new patch set (#4).
Change subject: KUDU-1812. Redact calls to Slice::ToDebugString
......................................................................
KUDU-1812. Redact calls to Slice::ToDebugString
The Slice::ToDebugString method is used pervasively to log errors in the
case of malformed inputs, which almost always can contain sensitive user
data. Unfortunately Slice::ToDebugString is part of our public client
API, so the redaction can not be done centrally in ToDebugString itself.
Change-Id: I4d1ebde79dea5cae89956b70d13f67fbc6972034
---
M src/kudu/cfile/binary_prefix_block.cc
M src/kudu/cfile/block_compression.cc
M src/kudu/cfile/bloomfile.cc
M src/kudu/cfile/cfile_reader.cc
M src/kudu/cfile/cfile_writer.cc
M src/kudu/cfile/compression_codec.cc
M src/kudu/common/encoded_key.cc
M src/kudu/common/key_encoder.h
M src/kudu/common/partition-test.cc
M src/kudu/common/partition.cc
M src/kudu/common/row.h
M src/kudu/common/row_changelist.cc
M src/kudu/consensus/log_util.cc
M src/kudu/rpc/serialization.cc
M src/kudu/rpc/transfer.cc
M src/kudu/tablet/cfile_set.cc
M src/kudu/tablet/concurrent_btree.h
M src/kudu/tablet/delta_key.h
M src/kudu/tablet/diskrowset.cc
M src/kudu/tablet/lock_manager.cc
M src/kudu/tablet/rowset_info.cc
M src/kudu/util/slice.cc
22 files changed, 125 insertions(+), 83 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/5568/4
--
To view, visit http://gerrit.cloudera.org:8080/5568
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4d1ebde79dea5cae89956b70d13f67fbc6972034
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-1812. Redact calls to Slice::ToDebugString
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5568
to look at the new patch set (#2).
Change subject: KUDU-1812. Redact calls to Slice::ToDebugString
......................................................................
KUDU-1812. Redact calls to Slice::ToDebugString
The Slice::ToDebugString method is used pervasively to log errors in the
case of malformed inputs, which almost always can contain sensitive user
data. Unfortunately Slice::ToDebugString is part of our public client
API, so the redaction can not be done centrally in ToDebugString itself.
Change-Id: I4d1ebde79dea5cae89956b70d13f67fbc6972034
---
M src/kudu/cfile/binary_prefix_block.cc
M src/kudu/cfile/block_compression.cc
M src/kudu/cfile/bloomfile.cc
M src/kudu/cfile/cfile_reader.cc
M src/kudu/cfile/cfile_writer.cc
M src/kudu/cfile/compression_codec.cc
M src/kudu/common/encoded_key.cc
M src/kudu/common/key_encoder.h
M src/kudu/common/partition-test.cc
M src/kudu/common/partition.cc
M src/kudu/common/row_changelist.cc
M src/kudu/consensus/log_util.cc
M src/kudu/rpc/serialization.cc
M src/kudu/rpc/transfer.cc
M src/kudu/tablet/cfile_set.cc
M src/kudu/tablet/concurrent_btree.h
M src/kudu/tablet/delta_key.h
M src/kudu/tablet/diskrowset.cc
M src/kudu/tablet/lock_manager.cc
M src/kudu/tablet/rowset_info.cc
M src/kudu/util/slice.cc
21 files changed, 116 insertions(+), 78 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/5568/2
--
To view, visit http://gerrit.cloudera.org:8080/5568
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4d1ebde79dea5cae89956b70d13f67fbc6972034
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>