You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "kostacie (via GitHub)" <gi...@apache.org> on 2025/04/21 08:34:05 UTC
[PR] HDDS-12340. Remove unnecessary findbugs exclusions [ozone]
kostacie opened a new pull request, #8309:
URL: https://github.com/apache/ozone/pull/8309
## What changes were proposed in this pull request?
This PR removes unused findbugs exclusions and fixes a path to `TestKeyInputStream`.
## What is the link to the Apache JIRA
[HDDS-12340](https://issues.apache.org/jira/browse/HDDS-12340)
## How was this patch tested?
CI:
https://github.com/kostacie/ozone/actions/runs/14534927524
P.S. Build's name contains 'HDDS-10247' instead of 'HDDS-12340' by mistake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12340. Remove unnecessary findbugs exclusions [ozone]
Posted by "ivanzlenko (via GitHub)" <gi...@apache.org>.
ivanzlenko commented on code in PR #8309:
URL: https://github.com/apache/ozone/pull/8309#discussion_r2052280698
##########
hadoop-ozone/integration-test/dev-support/findbugsExcludeFile.xml:
##########
@@ -53,7 +53,7 @@
<Bug pattern="RV_RETURN_VALUE_IGNORED" />
</Match>
<Match>
- <Class name="org.apache.hadoop.ozone.client.rpc.TestKeyInputStream"/>
+ <Class name="org.apache.hadoop.ozone.client.rpc.read.TestKeyInputStream"/>
Review Comment:
It should work for test files, but I do not see any changes to org.apache.hadoop.ozone.client.rpc.read.TestKeyInputStream, so most likely this exclude does nothing previously.
So we do not need to introduce it again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12340. Remove unnecessary findbugs exclusions [ozone]
Posted by "kostacie (via GitHub)" <gi...@apache.org>.
kostacie commented on code in PR #8309:
URL: https://github.com/apache/ozone/pull/8309#discussion_r2053474826
##########
hadoop-ozone/integration-test/dev-support/findbugsExcludeFile.xml:
##########
@@ -53,7 +53,7 @@
<Bug pattern="RV_RETURN_VALUE_IGNORED" />
</Match>
<Match>
- <Class name="org.apache.hadoop.ozone.client.rpc.TestKeyInputStream"/>
+ <Class name="org.apache.hadoop.ozone.client.rpc.read.TestKeyInputStream"/>
Review Comment:
Thank you @adoroszlai for the review. The change with `hadoop-ozone/integration-test/dev-support/findbugsExcludeFile.xml` was reverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12340. Remove unnecessary findbugs exclusions [ozone]
Posted by "kostacie (via GitHub)" <gi...@apache.org>.
kostacie commented on code in PR #8309:
URL: https://github.com/apache/ozone/pull/8309#discussion_r2052237107
##########
hadoop-ozone/integration-test/dev-support/findbugsExcludeFile.xml:
##########
@@ -53,7 +53,7 @@
<Bug pattern="RV_RETURN_VALUE_IGNORED" />
</Match>
<Match>
- <Class name="org.apache.hadoop.ozone.client.rpc.TestKeyInputStream"/>
+ <Class name="org.apache.hadoop.ozone.client.rpc.read.TestKeyInputStream"/>
Review Comment:
Thanks for the review. Do you mean that this doesn't work for test files, so it's useless?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12340. Remove unnecessary findbugs exclusions [ozone]
Posted by "kostacie (via GitHub)" <gi...@apache.org>.
kostacie commented on code in PR #8309:
URL: https://github.com/apache/ozone/pull/8309#discussion_r2052311467
##########
hadoop-ozone/integration-test/dev-support/findbugsExcludeFile.xml:
##########
@@ -53,7 +53,7 @@
<Bug pattern="RV_RETURN_VALUE_IGNORED" />
</Match>
<Match>
- <Class name="org.apache.hadoop.ozone.client.rpc.TestKeyInputStream"/>
+ <Class name="org.apache.hadoop.ozone.client.rpc.read.TestKeyInputStream"/>
Review Comment:
Ok, then I'll remove it too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12340. Remove unnecessary findbugs exclusions [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #8309:
URL: https://github.com/apache/ozone/pull/8309#discussion_r2052401405
##########
hadoop-ozone/integration-test/dev-support/findbugsExcludeFile.xml:
##########
@@ -53,7 +53,7 @@
<Bug pattern="RV_RETURN_VALUE_IGNORED" />
</Match>
<Match>
- <Class name="org.apache.hadoop.ozone.client.rpc.TestKeyInputStream"/>
+ <Class name="org.apache.hadoop.ozone.client.rpc.read.TestKeyInputStream"/>
Review Comment:
#8298 removes all spotbugs suppressions in integration tests after fixing all violations. To avoid conflict, let's not change `hadoop-ozone/integration-test/dev-support/findbugsExcludeFile.xml`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12340. Remove unnecessary findbugs exclusions [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #8309:
URL: https://github.com/apache/ozone/pull/8309
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12340. Remove unnecessary findbugs exclusions [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #8309:
URL: https://github.com/apache/ozone/pull/8309#issuecomment-2820010765
Thanks @kostacie for the patch, @ivanzlenko for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12340. Remove unnecessary findbugs exclusions [ozone]
Posted by "ivanzlenko (via GitHub)" <gi...@apache.org>.
ivanzlenko commented on code in PR #8309:
URL: https://github.com/apache/ozone/pull/8309#discussion_r2052200178
##########
hadoop-ozone/integration-test/dev-support/findbugsExcludeFile.xml:
##########
@@ -53,7 +53,7 @@
<Bug pattern="RV_RETURN_VALUE_IGNORED" />
</Match>
<Match>
- <Class name="org.apache.hadoop.ozone.client.rpc.TestKeyInputStream"/>
+ <Class name="org.apache.hadoop.ozone.client.rpc.read.TestKeyInputStream"/>
Review Comment:
Look's like this exclude doesn't do much. Shall we remove it as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org