You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by devgeeks <gi...@git.apache.org> on 2017/09/13 00:00:01 UTC
[GitHub] cordova-docs pull request #728: CB-13025 Remove use of React in plugins.cord...
GitHub user devgeeks opened a pull request:
https://github.com/apache/cordova-docs/pull/728
CB-13025 Remove use of React in plugins.cordova.io
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Docs
### What does this PR do?
Switches https://plugins.cordova.io from React to Preact to comply with Apache Legal.
- uses `preact-compat` for API compatibility (tried to make the smallest
changes possible)
- uses `babel` via `babelify` instead of the deprecated `reactify` to transform
the JSX
- no longer re-renders the entire app when filtering by platforms or
sorting has changed
### What testing has been done on this change?
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/devgeeks/cordova-docs CB-13025
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-docs/pull/728.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #728
----
commit adf96528f7f4b57ecae40b98d61c14aeff93d0b8
Author: tommy-carlos williams <to...@devgeeks.org>
Date: 2017-09-12T23:47:41Z
CB-13025 Remove use of React in plugins.cordova.io
Switched to Preact
- uses `preact-compat` for API compatibility (tried to make the smallest
changes possible)
- uses `babel` via `babelify` instead of the deprecated `reactify` to transform
the JSX
- no longer re-renders the entire app when filtering by platforms or
sorting has changed
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs issue #728: CB-13025 Remove use of React in plugins.cordova.io
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:
https://github.com/apache/cordova-docs/pull/728
LGTM. Did a build of the site and tested the Plugin Search, copy to clipboard, platform filter, sort, etc, all seems to work
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request #728: CB-13025 Remove use of React in plugins.cord...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/728
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org