You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/05/15 03:54:00 UTC

[GitHub] [incubator-echarts] wf123537200 opened a new pull request #12637: fix(tooltipView): radar.tooltip.trigger.axis no effect, fix 10537

wf123537200 opened a new pull request #12637:
URL: https://github.com/apache/incubator-echarts/pull/12637


   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [x] bug fixing
   - [ ] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   fix 10537, the type='radar'>tooltip>trigger='axis', no effect
   
   
   
   ### Fixed issues
   
   #7836 
   #10537
   
   ## Details
   
   ### Before: What was the problem?
   
   ![image](https://user-images.githubusercontent.com/5130528/82009618-674a1c80-96a2-11ea-8c2a-ce5836057369.png)
   
   ### After: How is it fixed in this PR?
   
   <!-- THE RESULT AFTER FIXING AND A SIMPLE EXPLANATION ABOUT HOW IT IS FIXED. -->
   
   ![image](https://user-images.githubusercontent.com/5130528/82009653-7c26b000-96a2-11ea-84c0-0c94ddd3f6cf.png)
   <!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
   
   
   
   ## Usage
   
   ### Are there any API changes?
   
   - [ ] The API has been changed.
   
   <!-- LIST THE API CHANGES HERE -->
   
   
   
   ### Related test cases or examples to use the new APIs
   
   NA.
   
   
   
   ## Others
   
   ### Merging options
   
   - [ ] Please squash the commits into a single one when merge.
   
   ### Other information
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] wf123537200 commented on a change in pull request #12637: fix(tooltipView): radar.tooltip.trigger.axis no effect, fix 10537

Posted by GitBox <gi...@apache.org>.
wf123537200 commented on a change in pull request #12637:
URL: https://github.com/apache/incubator-echarts/pull/12637#discussion_r425554543



##########
File path: src/component/tooltip/TooltipView.js
##########
@@ -488,7 +488,7 @@ export default echarts.extendComponentView({
         ]);
 
         var tooltipTrigger = tooltipModel.get('trigger');
-        if (tooltipTrigger != null && tooltipTrigger !== 'item') {
+        if (tooltipTrigger === null || tooltipTrigger === 'none') {

Review comment:
       change like this ``` if (!tooltipTrigger || tooltipTrigger === 'none')```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #12637: fix(tooltipView): radar.tooltip.trigger.axis no effect, fix 10537

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #12637:
URL: https://github.com/apache/incubator-echarts/pull/12637#issuecomment-629011037


   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] susiwen8 commented on a change in pull request #12637: fix(tooltipView): radar.tooltip.trigger.axis no effect, fix 10537

Posted by GitBox <gi...@apache.org>.
susiwen8 commented on a change in pull request #12637:
URL: https://github.com/apache/incubator-echarts/pull/12637#discussion_r425553089



##########
File path: src/component/tooltip/TooltipView.js
##########
@@ -488,7 +488,7 @@ export default echarts.extendComponentView({
         ]);
 
         var tooltipTrigger = tooltipModel.get('trigger');
-        if (tooltipTrigger != null && tooltipTrigger !== 'item') {
+        if (tooltipTrigger === null || tooltipTrigger === 'none') {

Review comment:
       `tooltipTrigger` might be `undefined`, so it would be better to use `== null` to verify.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] wf123537200 closed pull request #12637: fix(tooltipView): radar.tooltip.trigger.axis no effect, fix 10537

Posted by GitBox <gi...@apache.org>.
wf123537200 closed pull request #12637:
URL: https://github.com/apache/incubator-echarts/pull/12637


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] susiwen8 commented on a change in pull request #12637: fix(tooltipView): radar.tooltip.trigger.axis no effect, fix 10537

Posted by GitBox <gi...@apache.org>.
susiwen8 commented on a change in pull request #12637:
URL: https://github.com/apache/incubator-echarts/pull/12637#discussion_r425553089



##########
File path: src/component/tooltip/TooltipView.js
##########
@@ -488,7 +488,7 @@ export default echarts.extendComponentView({
         ]);
 
         var tooltipTrigger = tooltipModel.get('trigger');
-        if (tooltipTrigger != null && tooltipTrigger !== 'item') {
+        if (tooltipTrigger === null || tooltipTrigger === 'none') {

Review comment:
       `tooltipTrigger` might be `undefined`, so it would be better use `== null` to verify.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org