You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/04/01 20:52:42 UTC

[GitHub] [airflow] ryanahamilton commented on a change in pull request #8046: [AIRFLOW-7048] Allow user to convert timezone in UI

ryanahamilton commented on a change in pull request #8046: [AIRFLOW-7048] Allow user to convert timezone in UI
URL: https://github.com/apache/airflow/pull/8046#discussion_r401902103
 
 

 ##########
 File path: airflow/www/static/css/main.css
 ##########
 @@ -238,6 +238,19 @@ div.square {
   box-shadow: inset 0 6px 6px rgba(0, 0, 0, 0.4);
 }
 
+#timezone-menu li > span {
 
 Review comment:
   I don't see a `span` that is a direct descendant of an `li` in the markup?
   
   Ideal to avoid generic selectors all together, use a class instead. e.g. `.timezone-menu-label`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services