You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/07/27 19:11:11 UTC
Review Request 68093: Add XFS disk isolator files to CMake.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68093/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Benjamin Mahler, James Peach, and Joseph Wu.
Bugs: MESOS-8994 and MESOS-9117
https://issues.apache.org/jira/browse/MESOS-8994
https://issues.apache.org/jira/browse/MESOS-9117
Repository: mesos
Description
-------
This adds an option to turn on the isolator, but that results in a
fatal error because we do not yet check for the required headers and
libraries.
Diffs
-----
cmake/CompilationConfigure.cmake f80c265d117c70acda95da6b943cdd3e4e477daa
src/CMakeLists.txt 10b0946d6f49c7e9c201bad6f9f1b41cc8460fe5
src/tests/CMakeLists.txt 695b6f543847d4270f7004a1768919904975d7a4
Diff: https://reviews.apache.org/r/68093/diff/1/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 68093: Add XFS disk isolator files to CMake.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68093/#review206734
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Bannier
On July 27, 2018, 9:11 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68093/
> -----------------------------------------------------------
>
> (Updated July 27, 2018, 9:11 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, James Peach, and Joseph Wu.
>
>
> Bugs: MESOS-8994 and MESOS-9117
> https://issues.apache.org/jira/browse/MESOS-8994
> https://issues.apache.org/jira/browse/MESOS-9117
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds an option to turn on the isolator, but that results in a
> fatal error because we do not yet check for the required headers and
> libraries.
>
>
> Diffs
> -----
>
> cmake/CompilationConfigure.cmake f80c265d117c70acda95da6b943cdd3e4e477daa
> src/CMakeLists.txt 10b0946d6f49c7e9c201bad6f9f1b41cc8460fe5
> src/tests/CMakeLists.txt 695b6f543847d4270f7004a1768919904975d7a4
>
>
> Diff: https://reviews.apache.org/r/68093/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>