You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ignite.apache.org by ppenguin <pr...@qq.com> on 2019/01/21 10:39:35 UTC

IGNITE-8283 CPP: Implement 'varint' solution to be configurable via BinaryConfiguration

Igniters,

I'am beginning with this task. Now the c++ implementation lacks some parts that existed in Java and C#, so the task seems a little complex. I want to discuss the details here.

Re: IGNITE-8283 CPP: Implement 'varint' solution to be configurable via BinaryConfiguration

Posted by prehistoricpenguin <pr...@qq.com>.
Thanks for reminding.




------------------ Original ------------------
From: Igor Sapego <is...@apache.org>
Date: 周三,1月 23,2019 7:00 下午
To: dev <de...@ignite.apache.org>
Subject: Re: IGNITE-8283 CPP: Implement 'varint' solution to be configurable via BinaryConfiguration



Also, remember to merge code from Ignite's master to your branch often
as I'm making some massive changes in C++ codebase currently.

Best Regards,
Igor


On Wed, Jan 23, 2019 at 1:41 PM prehistoricpenguin <
prehistoricpenguin@qq.com> wrote:

> Thanks,
> Our team is evaluating ignite now, I am going through the cpp source code
> these days.
>
>
>
>
> ------------------ Original ------------------
> From: Igor Sapego <is...@apache.org>
> Date: 周三,1月 23,2019 6:35 下午
> To: dev <de...@ignite.apache.org>
> Subject: Re: IGNITE-8283 CPP: Implement 'varint' solution to be
> configurable via BinaryConfiguration
>
>
>
> Great,
>
> Try focussing on it first. Also, do not hesitate to contact me if you have
> any questions about preparing your development environment - it may be
> a little bit difficult now, through I'm working on it's improvement.
> Best Regards,
> Igor
>
>
>
> On Wed, Jan 23, 2019 at 3:24 AM ppenguin <pr...@qq.com>
> wrote:
>
> > Hi,so now I will focus on the JNI approach, thanks for the explanation.
> >
> >
> > 发自我的iPhone
> >
> > ------------------ Original ------------------
> > From: Igor Sapego <is...@apache.org>
> > Date: 周三,1月 23,2019 1:15 上午
> > To: dev <de...@ignite.apache.org>
> > Subject: Re: IGNITE-8283 CPP: Implement 'varint' solution to be
> > configurable via BinaryConfiguration
> >
> >
> >
> > Yes, we need to add it to all thin clients, actually, and to thin
> > protocol specification.
> >
> > On the second thought, we need to implement second approach
> > anyway, as Ignite can be configured with XML. So, I'd stopped on
> > the second approach for now, as we will need it in any way.
> > Best Regards,
> > Igor
> >
> >
> >
> > On Tue, Jan 22, 2019 at 6:19 PM ppenguin <pr...@qq.com>
> > wrote:
> >
> > > Hi,Do we need to add it into the thin cpp client too?If so, I think
> we’d
> > > better choose the first method,then we can reuse the code.
> > >
> > >
> > > ------------------ Original ------------------
> > > From: Igor Sapego <is...@apache.org>
> > > Date: 周一,1月 21,2019 11:19 下午
> > > To: dev <de...@ignite.apache.org>
> > > Subject: Re: IGNITE-8283 CPP: Implement 'varint' solution to be
> > > configurable via BinaryConfiguration
> > >
> > >
> > >
> > > Hi,
> > >
> > > The obvious solution here is to add IgniteConfiguration class for C++,
> > but
> > > it looks like not an easy task.
> > >
> > > There is another solution which is more easy to implement: it is to add
> > > call
> > > to Java code, something like "isVarintActive()", which is going to be
> > > called
> > > on node startup.
> > > Best Regards,
> > > Igor
> > >
> > >
> > >
> > > On Mon, Jan 21, 2019 at 1:40 PM ppenguin <pr...@qq.com>
> > > wrote:
> > >
> > > > Igniters,
> > > >
> > > > I'am beginning with this task. Now the c++ implementation lacks some
> > > parts
> > > > that existed in Java and C#, so the task seems a little complex. I
> want
> > > to
> > > > discuss the details here.

Re: IGNITE-8283 CPP: Implement 'varint' solution to be configurable via BinaryConfiguration

Posted by Igor Sapego <is...@apache.org>.
Also, remember to merge code from Ignite's master to your branch often
as I'm making some massive changes in C++ codebase currently.

Best Regards,
Igor


On Wed, Jan 23, 2019 at 1:41 PM prehistoricpenguin <
prehistoricpenguin@qq.com> wrote:

> Thanks,
> Our team is evaluating ignite now, I am going through the cpp source code
> these days.
>
>
>
>
> ------------------ Original ------------------
> From: Igor Sapego <is...@apache.org>
> Date: 周三,1月 23,2019 6:35 下午
> To: dev <de...@ignite.apache.org>
> Subject: Re: IGNITE-8283 CPP: Implement 'varint' solution to be
> configurable via BinaryConfiguration
>
>
>
> Great,
>
> Try focussing on it first. Also, do not hesitate to contact me if you have
> any questions about preparing your development environment - it may be
> a little bit difficult now, through I'm working on it's improvement.
> Best Regards,
> Igor
>
>
>
> On Wed, Jan 23, 2019 at 3:24 AM ppenguin <pr...@qq.com>
> wrote:
>
> > Hi,so now I will focus on the JNI approach, thanks for the explanation.
> >
> >
> > 发自我的iPhone
> >
> > ------------------ Original ------------------
> > From: Igor Sapego <is...@apache.org>
> > Date: 周三,1月 23,2019 1:15 上午
> > To: dev <de...@ignite.apache.org>
> > Subject: Re: IGNITE-8283 CPP: Implement 'varint' solution to be
> > configurable via BinaryConfiguration
> >
> >
> >
> > Yes, we need to add it to all thin clients, actually, and to thin
> > protocol specification.
> >
> > On the second thought, we need to implement second approach
> > anyway, as Ignite can be configured with XML. So, I'd stopped on
> > the second approach for now, as we will need it in any way.
> > Best Regards,
> > Igor
> >
> >
> >
> > On Tue, Jan 22, 2019 at 6:19 PM ppenguin <pr...@qq.com>
> > wrote:
> >
> > > Hi,Do we need to add it into the thin cpp client too?If so, I think
> we’d
> > > better choose the first method,then we can reuse the code.
> > >
> > >
> > > ------------------ Original ------------------
> > > From: Igor Sapego <is...@apache.org>
> > > Date: 周一,1月 21,2019 11:19 下午
> > > To: dev <de...@ignite.apache.org>
> > > Subject: Re: IGNITE-8283 CPP: Implement 'varint' solution to be
> > > configurable via BinaryConfiguration
> > >
> > >
> > >
> > > Hi,
> > >
> > > The obvious solution here is to add IgniteConfiguration class for C++,
> > but
> > > it looks like not an easy task.
> > >
> > > There is another solution which is more easy to implement: it is to add
> > > call
> > > to Java code, something like "isVarintActive()", which is going to be
> > > called
> > > on node startup.
> > > Best Regards,
> > > Igor
> > >
> > >
> > >
> > > On Mon, Jan 21, 2019 at 1:40 PM ppenguin <pr...@qq.com>
> > > wrote:
> > >
> > > > Igniters,
> > > >
> > > > I'am beginning with this task. Now the c++ implementation lacks some
> > > parts
> > > > that existed in Java and C#, so the task seems a little complex. I
> want
> > > to
> > > > discuss the details here.

Re: IGNITE-8283 CPP: Implement 'varint' solution to be configurable via BinaryConfiguration

Posted by prehistoricpenguin <pr...@qq.com>.
Thanks,
Our team is evaluating ignite now, I am going through the cpp source code these days.




------------------ Original ------------------
From: Igor Sapego <is...@apache.org>
Date: 周三,1月 23,2019 6:35 下午
To: dev <de...@ignite.apache.org>
Subject: Re: IGNITE-8283 CPP: Implement 'varint' solution to be configurable via BinaryConfiguration



Great,

Try focussing on it first. Also, do not hesitate to contact me if you have
any questions about preparing your development environment - it may be
a little bit difficult now, through I'm working on it's improvement.

Best Regards,
Igor


On Wed, Jan 23, 2019 at 3:24 AM ppenguin <pr...@qq.com> wrote:

> Hi,so now I will focus on the JNI approach, thanks for the explanation.
>
>
> 发自我的iPhone
>
> ------------------ Original ------------------
> From: Igor Sapego <is...@apache.org>
> Date: 周三,1月 23,2019 1:15 上午
> To: dev <de...@ignite.apache.org>
> Subject: Re: IGNITE-8283 CPP: Implement 'varint' solution to be
> configurable via BinaryConfiguration
>
>
>
> Yes, we need to add it to all thin clients, actually, and to thin
> protocol specification.
>
> On the second thought, we need to implement second approach
> anyway, as Ignite can be configured with XML. So, I'd stopped on
> the second approach for now, as we will need it in any way.
> Best Regards,
> Igor
>
>
>
> On Tue, Jan 22, 2019 at 6:19 PM ppenguin <pr...@qq.com>
> wrote:
>
> > Hi,Do we need to add it into the thin cpp client too?If so, I think we’d
> > better choose the first method,then we can reuse the code.
> >
> >
> > ------------------ Original ------------------
> > From: Igor Sapego <is...@apache.org>
> > Date: 周一,1月 21,2019 11:19 下午
> > To: dev <de...@ignite.apache.org>
> > Subject: Re: IGNITE-8283 CPP: Implement 'varint' solution to be
> > configurable via BinaryConfiguration
> >
> >
> >
> > Hi,
> >
> > The obvious solution here is to add IgniteConfiguration class for C++,
> but
> > it looks like not an easy task.
> >
> > There is another solution which is more easy to implement: it is to add
> > call
> > to Java code, something like "isVarintActive()", which is going to be
> > called
> > on node startup.
> > Best Regards,
> > Igor
> >
> >
> >
> > On Mon, Jan 21, 2019 at 1:40 PM ppenguin <pr...@qq.com>
> > wrote:
> >
> > > Igniters,
> > >
> > > I'am beginning with this task. Now the c++ implementation lacks some
> > parts
> > > that existed in Java and C#, so the task seems a little complex. I want
> > to
> > > discuss the details here.

Re: IGNITE-8283 CPP: Implement 'varint' solution to be configurable via BinaryConfiguration

Posted by Igor Sapego <is...@apache.org>.
Great,

Try focussing on it first. Also, do not hesitate to contact me if you have
any questions about preparing your development environment - it may be
a little bit difficult now, through I'm working on it's improvement.

Best Regards,
Igor


On Wed, Jan 23, 2019 at 3:24 AM ppenguin <pr...@qq.com> wrote:

> Hi,so now I will focus on the JNI approach, thanks for the explanation.
>
>
> 发自我的iPhone
>
> ------------------ Original ------------------
> From: Igor Sapego <is...@apache.org>
> Date: 周三,1月 23,2019 1:15 上午
> To: dev <de...@ignite.apache.org>
> Subject: Re: IGNITE-8283 CPP: Implement 'varint' solution to be
> configurable via BinaryConfiguration
>
>
>
> Yes, we need to add it to all thin clients, actually, and to thin
> protocol specification.
>
> On the second thought, we need to implement second approach
> anyway, as Ignite can be configured with XML. So, I'd stopped on
> the second approach for now, as we will need it in any way.
> Best Regards,
> Igor
>
>
>
> On Tue, Jan 22, 2019 at 6:19 PM ppenguin <pr...@qq.com>
> wrote:
>
> > Hi,Do we need to add it into the thin cpp client too?If so, I think we’d
> > better choose the first method,then we can reuse the code.
> >
> >
> > ------------------ Original ------------------
> > From: Igor Sapego <is...@apache.org>
> > Date: 周一,1月 21,2019 11:19 下午
> > To: dev <de...@ignite.apache.org>
> > Subject: Re: IGNITE-8283 CPP: Implement 'varint' solution to be
> > configurable via BinaryConfiguration
> >
> >
> >
> > Hi,
> >
> > The obvious solution here is to add IgniteConfiguration class for C++,
> but
> > it looks like not an easy task.
> >
> > There is another solution which is more easy to implement: it is to add
> > call
> > to Java code, something like "isVarintActive()", which is going to be
> > called
> > on node startup.
> > Best Regards,
> > Igor
> >
> >
> >
> > On Mon, Jan 21, 2019 at 1:40 PM ppenguin <pr...@qq.com>
> > wrote:
> >
> > > Igniters,
> > >
> > > I'am beginning with this task. Now the c++ implementation lacks some
> > parts
> > > that existed in Java and C#, so the task seems a little complex. I want
> > to
> > > discuss the details here.

Re: IGNITE-8283 CPP: Implement 'varint' solution to be configurable via BinaryConfiguration

Posted by ppenguin <pr...@qq.com>.
Hi,so now I will focus on the JNI approach, thanks for the explanation.


发自我的iPhone

------------------ Original ------------------
From: Igor Sapego <is...@apache.org>
Date: 周三,1月 23,2019 1:15 上午
To: dev <de...@ignite.apache.org>
Subject: Re: IGNITE-8283 CPP: Implement 'varint' solution to be configurable via BinaryConfiguration



Yes, we need to add it to all thin clients, actually, and to thin
protocol specification.

On the second thought, we need to implement second approach
anyway, as Ignite can be configured with XML. So, I'd stopped on
the second approach for now, as we will need it in any way.

Best Regards,
Igor


On Tue, Jan 22, 2019 at 6:19 PM ppenguin <pr...@qq.com> wrote:

> Hi,Do we need to add it into the thin cpp client too?If so, I think we’d
> better choose the first method,then we can reuse the code.
>
>
> ------------------ Original ------------------
> From: Igor Sapego <is...@apache.org>
> Date: 周一,1月 21,2019 11:19 下午
> To: dev <de...@ignite.apache.org>
> Subject: Re: IGNITE-8283 CPP: Implement 'varint' solution to be
> configurable via BinaryConfiguration
>
>
>
> Hi,
>
> The obvious solution here is to add IgniteConfiguration class for C++, but
> it looks like not an easy task.
>
> There is another solution which is more easy to implement: it is to add
> call
> to Java code, something like "isVarintActive()", which is going to be
> called
> on node startup.
> Best Regards,
> Igor
>
>
>
> On Mon, Jan 21, 2019 at 1:40 PM ppenguin <pr...@qq.com>
> wrote:
>
> > Igniters,
> >
> > I'am beginning with this task. Now the c++ implementation lacks some
> parts
> > that existed in Java and C#, so the task seems a little complex. I want
> to
> > discuss the details here.

Re: IGNITE-8283 CPP: Implement 'varint' solution to be configurable via BinaryConfiguration

Posted by Igor Sapego <is...@apache.org>.
Yes, we need to add it to all thin clients, actually, and to thin
protocol specification.

On the second thought, we need to implement second approach
anyway, as Ignite can be configured with XML. So, I'd stopped on
the second approach for now, as we will need it in any way.

Best Regards,
Igor


On Tue, Jan 22, 2019 at 6:19 PM ppenguin <pr...@qq.com> wrote:

> Hi,Do we need to add it into the thin cpp client too?If so, I think we’d
> better choose the first method,then we can reuse the code.
>
>
> ------------------ Original ------------------
> From: Igor Sapego <is...@apache.org>
> Date: 周一,1月 21,2019 11:19 下午
> To: dev <de...@ignite.apache.org>
> Subject: Re: IGNITE-8283 CPP: Implement 'varint' solution to be
> configurable via BinaryConfiguration
>
>
>
> Hi,
>
> The obvious solution here is to add IgniteConfiguration class for C++, but
> it looks like not an easy task.
>
> There is another solution which is more easy to implement: it is to add
> call
> to Java code, something like "isVarintActive()", which is going to be
> called
> on node startup.
> Best Regards,
> Igor
>
>
>
> On Mon, Jan 21, 2019 at 1:40 PM ppenguin <pr...@qq.com>
> wrote:
>
> > Igniters,
> >
> > I'am beginning with this task. Now the c++ implementation lacks some
> parts
> > that existed in Java and C#, so the task seems a little complex. I want
> to
> > discuss the details here.

Re: IGNITE-8283 CPP: Implement 'varint' solution to be configurable via BinaryConfiguration

Posted by ppenguin <pr...@qq.com>.
Hi,Do we need to add it into the thin cpp client too?If so, I think we’d better choose the first method,then we can reuse the code.


------------------ Original ------------------
From: Igor Sapego <is...@apache.org>
Date: 周一,1月 21,2019 11:19 下午
To: dev <de...@ignite.apache.org>
Subject: Re: IGNITE-8283 CPP: Implement 'varint' solution to be configurable via BinaryConfiguration



Hi,

The obvious solution here is to add IgniteConfiguration class for C++, but
it looks like not an easy task.

There is another solution which is more easy to implement: it is to add call
to Java code, something like "isVarintActive()", which is going to be called
on node startup.

Best Regards,
Igor


On Mon, Jan 21, 2019 at 1:40 PM ppenguin <pr...@qq.com> wrote:

> Igniters,
>
> I'am beginning with this task. Now the c++ implementation lacks some parts
> that existed in Java and C#, so the task seems a little complex. I want to
> discuss the details here.

Re: IGNITE-8283 CPP: Implement 'varint' solution to be configurable via BinaryConfiguration

Posted by Igor Sapego <is...@apache.org>.
Hi,

The obvious solution here is to add IgniteConfiguration class for C++, but
it looks like not an easy task.

There is another solution which is more easy to implement: it is to add call
to Java code, something like "isVarintActive()", which is going to be called
on node startup.

Best Regards,
Igor


On Mon, Jan 21, 2019 at 1:40 PM ppenguin <pr...@qq.com> wrote:

> Igniters,
>
> I'am beginning with this task. Now the c++ implementation lacks some parts
> that existed in Java and C#, so the task seems a little complex. I want to
> discuss the details here.