[GitHub] [samza] shanthoosh commented on a change in pull request #991: [SAMZA-2162] - Update Table APIs to be consistent with High level Async API

[GitBox <gi...@apache.org>]

shanthoosh commented on a change in pull request #991: [SAMZA-2162] - Update Table APIs to be consistent with High level Async API
URL: https://github.com/apache/samza/pull/991#discussion_r281880283
 
 

 ##########
 File path: samza-api/src/main/java/org/apache/samza/table/AsyncReadWriteTable.java
 ##########
 @@ -39,7 +39,7 @@
    * @return completableFuture for the requested value
    * @throws NullPointerException if the specified {@code key} is {@code null}.
    */
-  CompletableFuture<V> getAsync(K key);
+  CompletionStage<V> getAsync(K key);
 
 Review comment:
   +1.
   
   This would affect for not just high-level API users, but also for any samza user who is using the `Table` API through `TaskContext` through low-level API.  
   
   Would be better not to break backwards-compatibility here just for unification. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services