You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by anubhav100 <gi...@git.apache.org> on 2018/03/22 12:13:48 UTC
[GitHub] carbondata pull request #2090: [WIP] [TEST-PR] [CARBONDATA-2268] Fixed the R...
GitHub user anubhav100 opened a pull request:
https://github.com/apache/carbondata/pull/2090
[WIP] [TEST-PR] [CARBONDATA-2268] Fixed the Random Failure of DataRetention Test Cases
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/anubhav100/incubator-carbondata CARBONDATA-2268
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2090.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2090
----
commit 63578753ea458dfa9e9c611354a5165caf8be63f
Author: anubhav100 <an...@...>
Date: 2018-03-09T08:27:22Z
added sdv test cases of external table and path
commit 9c8394c525d0d92c3b38f70fc265e30d390c5941
Author: anubhav100 <an...@...>
Date: 2018-03-22T12:11:36Z
Fixed the Random Failure of DataRetention Test Cases
----
---
[GitHub] carbondata issue #2090: [WIP] [TEST-PR] [CARBONDATA-2268] Fixed the Random F...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2090
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4523/
---
[GitHub] carbondata pull request #2090: [WIP] [TEST-PR] [CARBONDATA-2268] Fixed the R...
Posted by anubhav100 <gi...@git.apache.org>.
Github user anubhav100 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2090#discussion_r176897338
--- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/dataretention/DataRetentionConcurrencyTestCase.scala ---
@@ -18,44 +18,63 @@
package org.apache.carbondata.spark.testsuite.dataretention
import java.util
-import java.util.concurrent.{Callable, Executors, Future}
+import java.util.concurrent.{Callable, ExecutorService, Executors, Future}
import scala.collection.JavaConverters._
import org.apache.spark.sql.test.util.QueryTest
-import org.scalatest.BeforeAndAfterAll
+import org.scalatest.{BeforeAndAfterAll, BeforeAndAfterEach}
import org.apache.carbondata.core.constants.CarbonCommonConstants
+import org.apache.carbondata.core.datamap.dev.DataMapWriter
+import org.apache.carbondata.core.datamap.dev.cgdatamap.{CoarseGrainDataMap, CoarseGrainDataMapFactory}
+import org.apache.carbondata.core.datamap.{DataMapDistributable, DataMapMeta, Segment}
+import org.apache.carbondata.core.datastore.page.ColumnPage
+import org.apache.carbondata.core.metadata.AbsoluteTableIdentifier
+import org.apache.carbondata.core.metadata.schema.table.DataMapSchema
+import org.apache.carbondata.core.scan.filter.intf.ExpressionType
import org.apache.carbondata.core.util.CarbonProperties
+import org.apache.carbondata.events.Event
/**
* This class contains DataRetention concurrency test cases
*/
-class DataRetentionConcurrencyTestCase extends QueryTest with BeforeAndAfterAll {
+class DataRetentionConcurrencyTestCase extends QueryTest with BeforeAndAfterAll with BeforeAndAfterEach {
--- End diff --
@jackylk already deleted in current master hence i am closing this pr
---
[GitHub] carbondata issue #2090: [WIP] [TEST-PR] [CARBONDATA-2268] Fixed the Random F...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2090
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3279/
---
[GitHub] carbondata issue #2090: [WIP] [TEST-PR] [CARBONDATA-2268] Fixed the Random F...
Posted by anubhav100 <gi...@git.apache.org>.
Github user anubhav100 commented on the issue:
https://github.com/apache/carbondata/pull/2090
retest this please
---
[GitHub] carbondata issue #2090: [WIP] [TEST-PR] [CARBONDATA-2268] Fixed the Random F...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2090
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4507/
---
[GitHub] carbondata pull request #2090: [WIP] [TEST-PR] [CARBONDATA-2268] Fixed the R...
Posted by anubhav100 <gi...@git.apache.org>.
Github user anubhav100 closed the pull request at:
https://github.com/apache/carbondata/pull/2090
---
[GitHub] carbondata issue #2090: [WIP] [TEST-PR] [CARBONDATA-2268] Fixed the Random F...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2090
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4012/
---
[GitHub] carbondata issue #2090: [WIP] [TEST-PR] [CARBONDATA-2268] Fixed the Random F...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2090
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3291/
---
[GitHub] carbondata issue #2090: [WIP] [TEST-PR] [CARBONDATA-2268] Fixed the Random F...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2090
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4013/
---
[GitHub] carbondata issue #2090: [WIP] [TEST-PR] [CARBONDATA-2268] Fixed the Random F...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2090
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4515/
---
[GitHub] carbondata issue #2090: [WIP] [TEST-PR] [CARBONDATA-2268] Fixed the Random F...
Posted by anubhav100 <gi...@git.apache.org>.
Github user anubhav100 commented on the issue:
https://github.com/apache/carbondata/pull/2090
retest this please
---
[GitHub] carbondata issue #2090: [WIP] [TEST-PR] [CARBONDATA-2268] Fixed the Random F...
Posted by anubhav100 <gi...@git.apache.org>.
Github user anubhav100 commented on the issue:
https://github.com/apache/carbondata/pull/2090
retest this please
---
[GitHub] carbondata issue #2090: [WIP] [TEST-PR] [CARBONDATA-2268] Fixed the Random F...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2090
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3281/
---
[GitHub] carbondata issue #2090: [WIP] [TEST-PR] [CARBONDATA-2268] Fixed the Random F...
Posted by anubhav100 <gi...@git.apache.org>.
Github user anubhav100 commented on the issue:
https://github.com/apache/carbondata/pull/2090
retest this please
---
[GitHub] carbondata issue #2090: [WIP] [TEST-PR] [CARBONDATA-2268] Fixed the Random F...
Posted by anubhav100 <gi...@git.apache.org>.
Github user anubhav100 commented on the issue:
https://github.com/apache/carbondata/pull/2090
retest this please
---
[GitHub] carbondata pull request #2090: [WIP] [TEST-PR] [CARBONDATA-2268] Fixed the R...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2090#discussion_r176896518
--- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/dataretention/DataRetentionConcurrencyTestCase.scala ---
@@ -18,44 +18,63 @@
package org.apache.carbondata.spark.testsuite.dataretention
import java.util
-import java.util.concurrent.{Callable, Executors, Future}
+import java.util.concurrent.{Callable, ExecutorService, Executors, Future}
import scala.collection.JavaConverters._
import org.apache.spark.sql.test.util.QueryTest
-import org.scalatest.BeforeAndAfterAll
+import org.scalatest.{BeforeAndAfterAll, BeforeAndAfterEach}
import org.apache.carbondata.core.constants.CarbonCommonConstants
+import org.apache.carbondata.core.datamap.dev.DataMapWriter
+import org.apache.carbondata.core.datamap.dev.cgdatamap.{CoarseGrainDataMap, CoarseGrainDataMapFactory}
+import org.apache.carbondata.core.datamap.{DataMapDistributable, DataMapMeta, Segment}
+import org.apache.carbondata.core.datastore.page.ColumnPage
+import org.apache.carbondata.core.metadata.AbsoluteTableIdentifier
+import org.apache.carbondata.core.metadata.schema.table.DataMapSchema
+import org.apache.carbondata.core.scan.filter.intf.ExpressionType
import org.apache.carbondata.core.util.CarbonProperties
+import org.apache.carbondata.events.Event
/**
* This class contains DataRetention concurrency test cases
*/
-class DataRetentionConcurrencyTestCase extends QueryTest with BeforeAndAfterAll {
+class DataRetentionConcurrencyTestCase extends QueryTest with BeforeAndAfterAll with BeforeAndAfterEach {
--- End diff --
I think this testcase is not valid anymore, please delete this suite
---
[GitHub] carbondata issue #2090: [WIP] [TEST-PR] [CARBONDATA-2268] Fixed the Random F...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2090
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4509/
---
[GitHub] carbondata issue #2090: [WIP] [TEST-PR] [CARBONDATA-2268] Fixed the Random F...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2090
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4520/
---
[GitHub] carbondata issue #2090: [WIP] [TEST-PR] [CARBONDATA-2268] Fixed the Random F...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2090
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3292/
---
[GitHub] carbondata issue #2090: [WIP] [TEST-PR] [CARBONDATA-2268] Fixed the Random F...
Posted by anubhav100 <gi...@git.apache.org>.
Github user anubhav100 commented on the issue:
https://github.com/apache/carbondata/pull/2090
retest this please
---
[GitHub] carbondata issue #2090: [WIP] [TEST-PR] [CARBONDATA-2268] Fixed the Random F...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2090
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4512/
---
[GitHub] carbondata issue #2090: [WIP] [TEST-PR] [CARBONDATA-2268] Fixed the Random F...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2090
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4519/
---
[GitHub] carbondata issue #2090: [WIP] [TEST-PR] [CARBONDATA-2268] Fixed the Random F...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2090
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3295/
---
[GitHub] carbondata issue #2090: [WIP] [TEST-PR] [CARBONDATA-2268] Fixed the Random F...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2090
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3287/
---
[GitHub] carbondata issue #2090: [WIP] [TEST-PR] [CARBONDATA-2268] Fixed the Random F...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2090
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4014/
---
[GitHub] carbondata issue #2090: [WIP] [TEST-PR] [CARBONDATA-2268] Fixed the Random F...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2090
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4538/
---
[GitHub] carbondata issue #2090: [WIP] [TEST-PR] [CARBONDATA-2268] Fixed the Random F...
Posted by anubhav100 <gi...@git.apache.org>.
Github user anubhav100 commented on the issue:
https://github.com/apache/carbondata/pull/2090
retest this please
---
[GitHub] carbondata issue #2090: [WIP] [TEST-PR] [CARBONDATA-2268] Fixed the Random F...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2090
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3310/
---
[GitHub] carbondata issue #2090: [WIP] [TEST-PR] [CARBONDATA-2268] Fixed the Random F...
Posted by anubhav100 <gi...@git.apache.org>.
Github user anubhav100 commented on the issue:
https://github.com/apache/carbondata/pull/2090
retest this please
---
[GitHub] carbondata issue #2090: [WIP] [TEST-PR] [CARBONDATA-2268] Fixed the Random F...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2090
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3284/
---