You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/08/15 21:24:00 UTC

[jira] [Work logged] (BEAM-2732) State tracking in Python is inefficient and has duplicated code

     [ https://issues.apache.org/jira/browse/BEAM-2732?focusedWorklogId=135158&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-135158 ]

ASF GitHub Bot logged work on BEAM-2732:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 15/Aug/18 21:23
            Start Date: 15/Aug/18 21:23
    Worklog Time Spent: 10m 
      Work Description: charlesccychen commented on a change in pull request #5356: [BEAM-2732][BEAM-4028] Logging relies on StateSampler for context
URL: https://github.com/apache/beam/pull/5356#discussion_r210414347
 
 

 ##########
 File path: sdks/python/apache_beam/runners/worker/logger.py
 ##########
 @@ -34,7 +34,6 @@ class _PerThreadWorkerData(threading.local):
 
   def __init__(self):
     super(_PerThreadWorkerData, self).__init__()
-    # TODO(robertwb): Consider starting with an initial (ignored) ~20 elements
 
 Review comment:
   Part of this TODO was accidentally deleted.  Please fix.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 135158)
    Time Spent: 19h 20m  (was: 19h 10m)

> State tracking in Python is inefficient and has duplicated code
> ---------------------------------------------------------------
>
>                 Key: BEAM-2732
>                 URL: https://issues.apache.org/jira/browse/BEAM-2732
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py-core
>            Reporter: Pablo Estrada
>            Assignee: Pablo Estrada
>            Priority: Major
>             Fix For: 2.6.0
>
>          Time Spent: 19h 20m
>  Remaining Estimate: 0h
>
> e.g logging and metrics keep state separately. State tracking should be unified.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)