You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/27 18:19:01 UTC

[GitHub] [flink] zentol commented on a change in pull request #17535: [FLINK-24609][akka][build] Use same Scala properties as root pom

zentol commented on a change in pull request #17535:
URL: https://github.com/apache/flink/pull/17535#discussion_r737732539



##########
File path: flink-rpc/flink-rpc-akka/pom.xml
##########
@@ -35,8 +35,8 @@ under the License.
 
 	<properties>
 		<akka.version>2.6.15</akka.version>
-		<akka.scala.binary.version>2.12</akka.scala.binary.version>
-		<akka.scala.version>2.12.7</akka.scala.version>
+		<scala.binary.version>2.12</scala.binary.version>
+		<scala.version>2.12.7</scala.version>

Review comment:
       Because we want to use a specific version. If we add support for Scala 2.13 (which entails adding a profile which sets scala.[binary.]version), we still want to use 2.12 here because the RPC system it self-contained and independent from the APIs.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org