You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "pivotal-eshu (GitHub)" <gi...@apache.org> on 2018/11/15 22:47:16 UTC
[GitHub] [geode] pivotal-eshu opened pull request #2861: GEODE-6061:
Add more test coverage on function with transaction.
[ Full content available at: https://github.com/apache/geode/pull/2861 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] pivotal-eshu closed pull request #2861: GEODE-6061:
Add more test coverage on function with transaction.
Posted by "pivotal-eshu (GitHub)" <gi...@apache.org>.
[ pull request closed by pivotal-eshu ]
[ Full content available at: https://github.com/apache/geode/pull/2861 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] agingade commented on pull request #2861:
GEODE-6061: Add more test coverage on function with transaction.
Posted by "agingade (GitHub)" <gi...@apache.org>.
We could remove this. If we are not creating persistent regions.
[ Full content available at: https://github.com/apache/geode/pull/2861 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] agingade commented on pull request #2861:
GEODE-6061: Add more test coverage on function with transaction.
Posted by "agingade (GitHub)" <gi...@apache.org>.
We could change method name to indicate data is not changed after the rollback.
[ Full content available at: https://github.com/apache/geode/pull/2861 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] agingade commented on pull request #2861:
GEODE-6061: Add more test coverage on function with transaction.
Posted by "agingade (GitHub)" <gi...@apache.org>.
We can add rollback in method name to indicate tx rollback is performed as part this method.
[ Full content available at: https://github.com/apache/geode/pull/2861 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] agingade commented on pull request #2861:
GEODE-6061: Add more test coverage on function with transaction.
Posted by "agingade (GitHub)" <gi...@apache.org>.
To be clear, we can change it to partitioned-region and non-partitioned-region
[ Full content available at: https://github.com/apache/geode/pull/2861 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org