You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/07/26 01:27:05 UTC
[GitHub] [skywalking] jmjoy opened a new issue, #9384: [Feature] About log collecting and meter(Metrics) reports skywalking-rust.
jmjoy opened a new issue, #9384:
URL: https://github.com/apache/skywalking/issues/9384
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
Mentioned in <https://github.com/apache/skywalking/issues/9297#issuecomment-1188532431>, the features of the next version of skywalking-rust.
### Use case
_No response_
### Related issues
_No response_
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #9384: [Feature] About log collecting and meter(Metrics) reports skywalking-rust.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #9384:
URL: https://github.com/apache/skywalking/issues/9384#issuecomment-1221211063
> I have some doubts about metric, where will the metric data be displayed on the UI?
Nearly all data on the pages? You need to follow MAL to pre-process metrics
- https://skywalking.apache.org/docs/main/latest/en/concepts-and-designs/mal/
- https://skywalking.apache.org/docs/main/latest/en/setup/backend/backend-meter/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] jmjoy commented on issue #9384: [Feature] About log collecting and meter(Metrics) reports skywalking-rust.
Posted by GitBox <gi...@apache.org>.
jmjoy commented on issue #9384:
URL: https://github.com/apache/skywalking/issues/9384#issuecomment-1221209481
I have some doubts about metric, where will the metric data be displayed on the UI?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] jmjoy commented on issue #9384: [Feature] About log collecting and meter(Metrics) reports skywalking-rust.
Posted by GitBox <gi...@apache.org>.
jmjoy commented on issue #9384:
URL: https://github.com/apache/skywalking/issues/9384#issuecomment-1194864792
Is the log collecting means [Span::add_log](https://docs.rs/skywalking/latest/skywalking/context/span/struct.Span.html#method.add_log)?
If yes, it's already done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Feature] About log collecting and meter(Metrics) reports skywalking-rust. [skywalking]
Posted by "4t145 (via GitHub)" <gi...@apache.org>.
4t145 commented on issue #9384:
URL: https://github.com/apache/skywalking/issues/9384#issuecomment-2011645959
Tokio [tracing](https://crates.io/crates/tracing) is the most widely used trace framework in the Rust world. I'am not demand that the crate [skywalking-rust](https://github.com/jmjoy/skywalking-rust) to support tokio tracing. I ask because the creator of this issue [jmjoy](https://github.com/jmjoy) mentioned that he was thinking about to integrate crate [skywalking-rust](https://github.com/jmjoy/skywalking-rust) with tokio tracing there like what [tracing-opentelemetry](https://crates.io/crates/tracing-opentelemetry) (maybe it's a new crate named `tracing-skywalking`) do. Since opentelemetry has been well supported in tokio traicng I wonder if there is the same thing in skywalking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Feature] About log collecting and meter(Metrics) reports skywalking-rust. [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on issue #9384:
URL: https://github.com/apache/skywalking/issues/9384#issuecomment-2011590674
> > For logging, I want to implement it by integrate with the tokio log framework [tracing](https://crates.io/crates/tracing), add the grpc subscriber and some filed in log, such as:
> > ```rust
> > // The GrpcSubscriber implement `tracing::Subscriber`.
> > let subscriber = skywalking::logging::GrpcSubscriber::new();
> >
> > tracing::subscriber::set_global_default(subscriber);
> >
> > let trace_context = create_the_trace_context();
> >
> > info!("some log", skywalking.ctx = trace_context);
> > ```
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > Because tracing is not only a log framework, but also a trace framework, so in the future, I want to integrate skywalking Tracer with [tracing](https://crates.io/crates/tracing), like [tracing-opentelemetry](https://crates.io/crates/tracing-opentelemetry).
>
> Sorry to bother you but do we have any tokio tracing subscriber layer implemente by now? Is there any hint if I want to intergrate skywallking-rust with tokio tracing?
What is that tracing doing? If it only does pure tracing such as Zipkin, I am afraid, that is not enough for SkyWalking's requirements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #9384: [Feature] About log collecting and meter(Metrics) reports skywalking-rust.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #9384:
URL: https://github.com/apache/skywalking/issues/9384#issuecomment-1200703322
You could create APIs fot native logging/tracing integration, and provide a shell on the APIs for tokio tracing. This would be helpful to set up APIs boundaries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] jmjoy commented on issue #9384: [Feature] About log collecting and meter(Metrics) reports skywalking-rust.
Posted by GitBox <gi...@apache.org>.
jmjoy commented on issue #9384:
URL: https://github.com/apache/skywalking/issues/9384#issuecomment-1200700576
For logging, I want to implement it by integrate with the tokio log framework [tracing](https://crates.io/crates/tracing), add the grpc subscriber and some filed in log, such as:
```rust
// The GrpcSubscriber implement `tracing::Subscriber`.
let subscriber = skywalking::logging::GrpcSubscriber::new();
tracing::subscriber::set_global_default(subscriber);
let trace_context = create_the_trace_context();
info!("some log", skywalking.ctx = trace_context);
```
Because tracing is not only a log framework, but also a trace framework, so in the future, I want to integrate skywalking Tracer with [tracing](https://crates.io/crates/tracing), like [tracing-opentelemetry](https://crates.io/crates/tracing-opentelemetry).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #9384: [Feature] About log collecting and meter(Metrics) reports skywalking-rust.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #9384:
URL: https://github.com/apache/skywalking/issues/9384#issuecomment-1226817278
Log APIs - https://github.com/apache/skywalking-rust/pull/41
Metrics APIs - https://github.com/apache/skywalking-rust/pull/44
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Feature] About log collecting and meter(Metrics) reports skywalking-rust. [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on issue #9384:
URL: https://github.com/apache/skywalking/issues/9384#issuecomment-2011651461
> Tokio [tracing](https://crates.io/crates/tracing) is the most widely used trace framework in the Rust world. I'am not demanding that the crate [skywalking-rust](https://github.com/jmjoy/skywalking-rust) to support tokio tracing. I ask because the creator of this issue [jmjoy](https://github.com/jmjoy) mentioned that he was thinking about to integrate crate [skywalking-rust](https://github.com/jmjoy/skywalking-rust) with tokio tracing there like what [tracing-opentelemetry](https://crates.io/crates/tracing-opentelemetry) do (maybe it's a new crate named `tracing-skywalking`). Since opentelemetry has been well supported in tokio traicng I wonder if there is the same thing in skywalking.
That is a new thing. But at least, this is not a thing we discussed here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] jmjoy commented on issue #9384: [Feature] About log collecting and meter(Metrics) reports skywalking-rust.
Posted by GitBox <gi...@apache.org>.
jmjoy commented on issue #9384:
URL: https://github.com/apache/skywalking/issues/9384#issuecomment-1211930729
Add logging:
https://github.com/apache/skywalking-rust/pull/41
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #9384: [Feature] About log collecting and meter(Metrics) reports skywalking-rust.
Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #9384: [Feature] About log collecting and meter(Metrics) reports skywalking-rust.
URL: https://github.com/apache/skywalking/issues/9384
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #9384: [Feature] About log collecting and meter(Metrics) reports skywalking-rust.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #9384:
URL: https://github.com/apache/skywalking/issues/9384#issuecomment-1194946371
No, it isn't. Log collecting mean logs with trace context could be reported through grpc log API. It is less expensive than including in spans. Also, you would be able to search logs without trace ID.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Feature] About log collecting and meter(Metrics) reports skywalking-rust. [skywalking]
Posted by "4t145 (via GitHub)" <gi...@apache.org>.
4t145 commented on issue #9384:
URL: https://github.com/apache/skywalking/issues/9384#issuecomment-2011575152
> For logging, I want to implement it by integrate with the tokio log framework [tracing](https://crates.io/crates/tracing), add the grpc subscriber and some filed in log, such as:
>
> ```rust
> // The GrpcSubscriber implement `tracing::Subscriber`.
> let subscriber = skywalking::logging::GrpcSubscriber::new();
>
> tracing::subscriber::set_global_default(subscriber);
>
> let trace_context = create_the_trace_context();
>
> info!("some log", skywalking.ctx = trace_context);
> ```
>
> Because tracing is not only a log framework, but also a trace framework, so in the future, I want to integrate skywalking Tracer with [tracing](https://crates.io/crates/tracing), like [tracing-opentelemetry](https://crates.io/crates/tracing-opentelemetry).
Sorry to bother you but do we have any tokio tracing subscriber layer implemente by now? Is there any hint if I want to intergrate skywallking-rust with tokio tracing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] jmjoy commented on issue #9384: [Feature] About log collecting and meter(Metrics) reports skywalking-rust.
Posted by GitBox <gi...@apache.org>.
jmjoy commented on issue #9384:
URL: https://github.com/apache/skywalking/issues/9384#issuecomment-1221218577
> You could take a look for k8s, virtual machine(linux), and MySQL server monitoring.
:ok_hand:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #9384: [Feature] About log collecting and meter(Metrics) reports skywalking-rust.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #9384:
URL: https://github.com/apache/skywalking/issues/9384#issuecomment-1221217977
You could take a look for k8s, virtual machine(linux), and MySQL server monitoring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org