You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2015/12/01 12:42:53 UTC
Review Request 40818: Fixed flaky test
(AvailableResourcesAfterRescinding).
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40818/
-----------------------------------------------------------
Review request for mesos, Joris Van Remoortere and Vinod Kone.
Repository: mesos
Description
-------
Addendum to b2b0eedc7371cd294b715fc91312989919d57c7a
Diffs
-----
src/tests/master_quota_tests.cpp 481298361574008b2cf9d213c908deb633393e31
Diff: https://reviews.apache.org/r/40818/diff/
Testing
-------
Two test setups on Mac OS X 10.10.4.
`GTEST_FILTER="*AvailableResourcesAfterRescinding*" ./bin/mesos-tests.sh --gtest_repeat=1000` *with* `allocation_interval` set to `50ms`
The probability of a batch allocation between rescinding and `Shutdown()` is low.
`GTEST_FILTER="*AvailableResourcesAfterRescinding*" ./bin/mesos-tests.sh --gtest_repeat=1000` *with* simulation of slow CI
A batch allocation between rescinding and `Shutdown()` is triggered by inserting the following lines after resources are recovered:
```
Clock::pause();
Clock::advance(flags.allocation_timeout);
Clock::settle();
Clock::resume();
```
Thanks,
Alexander Rukletsov
Re: Review Request 40818: Fixed flaky test
(AvailableResourcesAfterRescinding).
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40818/#review108553
-----------------------------------------------------------
Patch looks great!
Reviews applied: [40818]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 1, 2015, 4:52 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40818/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2015, 4:52 p.m.)
>
>
> Review request for mesos, Joris Van Remoortere and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Addendum to b2b0eedc7371cd294b715fc91312989919d57c7a
>
>
> Diffs
> -----
>
> src/tests/master_quota_tests.cpp 481298361574008b2cf9d213c908deb633393e31
>
> Diff: https://reviews.apache.org/r/40818/diff/
>
>
> Testing
> -------
>
> Two test setups on Mac OS X 10.10.4.
>
> `GTEST_FILTER="*AvailableResourcesAfterRescinding*" ./bin/mesos-tests.sh --gtest_repeat=1000` *with* `allocation_interval` set to `50ms`
> The probability of a batch allocation between rescinding and `Shutdown()` is low.
>
>
> `GTEST_FILTER="*AvailableResourcesAfterRescinding*" ./bin/mesos-tests.sh --gtest_repeat=1000` *with* simulation of slow CI
> A batch allocation between rescinding and `Shutdown()` is triggered by inserting the following lines after resources are recovered:
> ```
> Clock::pause();
> Clock::advance(flags.allocation_timeout);
> Clock::settle();
> Clock::resume();
> ```
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 40818: Fixed flaky test
(AvailableResourcesAfterRescinding).
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40818/#review108682
-----------------------------------------------------------
Ship it!
After our discussion offline, I suggest we remove these expectations for now. They require a significant amount of documentation, and don't really test anything as they only span the length of some helper functions.
- Joris Van Remoortere
On Dec. 1, 2015, 4:52 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40818/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2015, 4:52 p.m.)
>
>
> Review request for mesos, Joris Van Remoortere and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Addendum to b2b0eedc7371cd294b715fc91312989919d57c7a
>
>
> Diffs
> -----
>
> src/tests/master_quota_tests.cpp 481298361574008b2cf9d213c908deb633393e31
>
> Diff: https://reviews.apache.org/r/40818/diff/
>
>
> Testing
> -------
>
> Two test setups on Mac OS X 10.10.4.
>
> `GTEST_FILTER="*AvailableResourcesAfterRescinding*" ./bin/mesos-tests.sh --gtest_repeat=1000` *with* `allocation_interval` set to `50ms`
> The probability of a batch allocation between rescinding and `Shutdown()` is low.
>
>
> `GTEST_FILTER="*AvailableResourcesAfterRescinding*" ./bin/mesos-tests.sh --gtest_repeat=1000` *with* simulation of slow CI
> A batch allocation between rescinding and `Shutdown()` is triggered by inserting the following lines after resources are recovered:
> ```
> Clock::pause();
> Clock::advance(flags.allocation_timeout);
> Clock::settle();
> Clock::resume();
> ```
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 40818: Fixed flaky test
(AvailableResourcesAfterRescinding).
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40818/
-----------------------------------------------------------
(Updated Dec. 1, 2015, 4:52 p.m.)
Review request for mesos, Joris Van Remoortere and Vinod Kone.
Changes
-------
Removed non-ascii chars. Courtesy of Neil and https://reviews.apache.org/r/40799/
Repository: mesos
Description
-------
Addendum to b2b0eedc7371cd294b715fc91312989919d57c7a
Diffs (updated)
-----
src/tests/master_quota_tests.cpp 481298361574008b2cf9d213c908deb633393e31
Diff: https://reviews.apache.org/r/40818/diff/
Testing
-------
Two test setups on Mac OS X 10.10.4.
`GTEST_FILTER="*AvailableResourcesAfterRescinding*" ./bin/mesos-tests.sh --gtest_repeat=1000` *with* `allocation_interval` set to `50ms`
The probability of a batch allocation between rescinding and `Shutdown()` is low.
`GTEST_FILTER="*AvailableResourcesAfterRescinding*" ./bin/mesos-tests.sh --gtest_repeat=1000` *with* simulation of slow CI
A batch allocation between rescinding and `Shutdown()` is triggered by inserting the following lines after resources are recovered:
```
Clock::pause();
Clock::advance(flags.allocation_timeout);
Clock::settle();
Clock::resume();
```
Thanks,
Alexander Rukletsov
Re: Review Request 40818: Fixed flaky test
(AvailableResourcesAfterRescinding).
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40818/#review108517
-----------------------------------------------------------
Patch looks great!
Reviews applied: [40818]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 1, 2015, 11:42 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40818/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2015, 11:42 a.m.)
>
>
> Review request for mesos, Joris Van Remoortere and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Addendum to b2b0eedc7371cd294b715fc91312989919d57c7a
>
>
> Diffs
> -----
>
> src/tests/master_quota_tests.cpp 481298361574008b2cf9d213c908deb633393e31
>
> Diff: https://reviews.apache.org/r/40818/diff/
>
>
> Testing
> -------
>
> Two test setups on Mac OS X 10.10.4.
>
> `GTEST_FILTER="*AvailableResourcesAfterRescinding*" ./bin/mesos-tests.sh --gtest_repeat=1000` *with* `allocation_interval` set to `50ms`
> The probability of a batch allocation between rescinding and `Shutdown()` is low.
>
>
> `GTEST_FILTER="*AvailableResourcesAfterRescinding*" ./bin/mesos-tests.sh --gtest_repeat=1000` *with* simulation of slow CI
> A batch allocation between rescinding and `Shutdown()` is triggered by inserting the following lines after resources are recovered:
> ```
> Clock::pause();
> Clock::advance(flags.allocation_timeout);
> Clock::settle();
> Clock::resume();
> ```
>
>
> Thanks,
>
> Alexander Rukletsov
>
>