You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by dg...@hyperreal.org on 1998/03/26 22:17:42 UTC
cvs commit: apache-1.3/src/include http_core.h httpd.h
dgaudet 98/03/26 13:17:42
Modified: src CHANGES
src/include http_core.h httpd.h
Log:
I think it was Marc that pointed this out ages ago... I don't remember.
We need to mark various bitfields as signed to follow the spec.
Revision Changes Path
1.736 +4 -0 apache-1.3/src/CHANGES
Index: CHANGES
===================================================================
RCS file: /export/home/cvs/apache-1.3/src/CHANGES,v
retrieving revision 1.735
retrieving revision 1.736
diff -u -r1.735 -r1.736
--- CHANGES 1998/03/26 21:08:35 1.735
+++ CHANGES 1998/03/26 21:17:37 1.736
@@ -1,5 +1,9 @@
Changes with Apache 1.3b6
+ *) ANSI C doesn't guarantee that "int foo : 2" in a structure will
+ be a signed bitfield. So mark a few bitfields as signed to
+ ensure correct code. [Dean Gaudet]
+
*) The default for HostnameLookups was changed to Off, but there
was a problem and it wasn't taking effect. [Dean Gaudet]
1.40 +3 -3 apache-1.3/src/include/http_core.h
Index: http_core.h
===================================================================
RCS file: /export/home/cvs/apache-1.3/src/include/http_core.h,v
retrieving revision 1.39
retrieving revision 1.40
diff -u -r1.39 -r1.40
--- http_core.h 1998/03/17 19:38:40 1.39
+++ http_core.h 1998/03/26 21:17:40 1.40
@@ -184,11 +184,11 @@
#define HOSTNAME_LOOKUP_ON 1
#define HOSTNAME_LOOKUP_DOUBLE 2
#define HOSTNAME_LOOKUP_UNSET 3
- int hostname_lookups : 4;
+ unsigned int hostname_lookups : 4;
- int do_rfc1413 : 2; /* See if client is advertising a username? */
+ signed int do_rfc1413 : 2; /* See if client is advertising a username? */
- int content_md5 : 2; /* calculate Content-MD5? */
+ signed int content_md5 : 2; /* calculate Content-MD5? */
unsigned use_canonical_name : 2; /* bit 0 = on/off, bit 1 = unset/set */
1.200 +2 -2 apache-1.3/src/include/httpd.h
Index: httpd.h
===================================================================
RCS file: /export/home/cvs/apache-1.3/src/include/httpd.h,v
retrieving revision 1.199
retrieving revision 1.200
diff -u -r1.199 -r1.200
--- httpd.h 1998/03/17 07:54:13 1.199
+++ httpd.h 1998/03/26 21:17:40 1.200
@@ -722,10 +722,10 @@
char *auth_type; /* Ditto. */
unsigned aborted:1; /* Are we still talking? */
- int keepalive:2; /* Are we using HTTP Keep-Alive?
+ signed int keepalive:2; /* Are we using HTTP Keep-Alive?
* -1 fatal error, 0 undecided, 1 yes */
unsigned keptalive:1; /* Did we use HTTP Keep-Alive? */
- int double_reverse:2; /* have we done double-reverse DNS?
+ signed int double_reverse:2;/* have we done double-reverse DNS?
* -1 yes/failure, 0 not yet, 1 yes/success */
int keepalives; /* How many times have we used it? */
};